From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.5 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BD273C433E0 for ; Tue, 9 Feb 2021 00:04:00 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 58FB564E9A for ; Tue, 9 Feb 2021 00:04:00 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 58FB564E9A Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:59964 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1l9GVb-0006dj-AA for qemu-devel@archiver.kernel.org; Mon, 08 Feb 2021 19:03:59 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:53272) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1l9EzA-0006cF-3w for qemu-devel@nongnu.org; Mon, 08 Feb 2021 17:26:25 -0500 Received: from mail-pf1-x436.google.com ([2607:f8b0:4864:20::436]:37921) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1l9Ez6-00089f-Tc for qemu-devel@nongnu.org; Mon, 08 Feb 2021 17:26:23 -0500 Received: by mail-pf1-x436.google.com with SMTP id d26so9398923pfn.5 for ; Mon, 08 Feb 2021 14:26:20 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=QpfyIkRHWT85deH5cOU4LJWRgKAZYY7uj042U/QtehU=; b=vxxAzg2v+LPrwvUpuhNOMGJOG2Gq5pKpzTTL6p8vEMgLhEKQf7S0XwtVYiaPFm5z3w sqy43drnIFirGm14m971hNyFxMWcuYz/9qZknH0EHl4Ir3ounpBUuazTDWbmJjN6wvm4 914tRQ43IpNnIBSJqGK9pT72ttsvqWIzmXc5gV9tTggRKCG0SDTNY58we9tfK4Hqy2Aq h7Vkv/W9X/FrJI3rCnu+yCVaWMON+bIYxoz2UOyYUlsHEGj5+Fv10to3hEfhWv7l64/R e/HE8JkLzBA4554KOns338vMTM8bW6B18dK/6bz9GVbFGrZfjckNLINDZZgCTsbqEPwe Vbaw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=QpfyIkRHWT85deH5cOU4LJWRgKAZYY7uj042U/QtehU=; b=qqd+Dp/yhS3CgM0lfLBg1dIcQrHFxxxdDrPbiBOqAevmCTEcBSGr+LVkPxoNA2IUtS qRfOJI9Uer1ziwiLPY+uNIfNhLXpCZTJ2r30+8o7tI9Tbm3B0az1CD/mVTaL6dHfDH7f r2dDJ7LKD/Nf1sFoiKe38EqsP4tyXh6JIetTbPhmue6caizeE0tKuVW7Wwyb0Oy1nwtA 8UfEbL3RkPmnr9ii+jpiwc8NAVuuYsM0ECtJnQovKgrQclgroBIZlRPFY9meOBQHqb+C 3vT3NSKI+pvNM9V8AUgdQKUyCGjYx3m1shGn2BMKfy/RvW15tbtpC2sfVrCvIpO5uJER Rjkw== X-Gm-Message-State: AOAM530OmFEO74GWHni6YUQOMapFfuzXjE0T3id+ifwNHkrnKz3spgqX Bzas8iTN94HVMmqVVvuC7Wf6WyetRCeVKw== X-Google-Smtp-Source: ABdhPJxdGYTOws5DWnpPfjOJZaSutsN39eKof+t54J081m2qtbE1sO38QkllA6lcpfcfeklGB/ckHQ== X-Received: by 2002:a63:e310:: with SMTP id f16mr19554224pgh.160.1612823179289; Mon, 08 Feb 2021 14:26:19 -0800 (PST) Received: from [192.168.1.11] (174-21-150-71.tukw.qwest.net. [174.21.150.71]) by smtp.gmail.com with ESMTPSA id g9sm20319097pfr.94.2021.02.08.14.26.17 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 08 Feb 2021 14:26:18 -0800 (PST) Subject: Re: [PATCH v2 02/15] tcg/arm: Add host vector framework To: Peter Maydell References: <20210208024625.271018-1-richard.henderson@linaro.org> <20210208024625.271018-3-richard.henderson@linaro.org> <8f830dcb-2769-ca7d-460f-6095a5a47c1b@linaro.org> From: Richard Henderson Message-ID: Date: Mon, 8 Feb 2021 14:26:15 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Received-SPF: pass client-ip=2607:f8b0:4864:20::436; envelope-from=richard.henderson@linaro.org; helo=mail-pf1-x436.google.com X-Spam_score_int: -23 X-Spam_score: -2.4 X-Spam_bar: -- X-Spam_report: (-2.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, NICE_REPLY_A=-0.265, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: QEMU Developers Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 2/8/21 11:30 AM, Peter Maydell wrote: > On Mon, 8 Feb 2021 at 18:58, Richard Henderson > wrote: >> >> On 2/8/21 10:28 AM, Peter Maydell wrote: >>> On Mon, 8 Feb 2021 at 17:53, Peter Maydell wrote: >>>> The AAPCS says that q4-q7 are preserved across calls. >>> >>> Speaking of which, doesn't that mean we also need to >>> save and restore q4-q7 in tcg_target_qemu_prologue() >>> if we might be generating neon insns? (It doesn't look like >>> aarch64's prologue does this, which seems like a bug.) >> >> I just put them on the reserved list so that they don't get used. >> >>> tcg_regset_reset_reg(tcg_target_call_clobber_regs, TCG_REG_V8); >> ... >>> tcg_regset_reset_reg(tcg_target_call_clobber_regs, TCG_REG_V15); > > I'm confused. That's not the reserved list, it's the call-clobber > list Oops. It's actually done by not adding them to tcg_target_reg_alloc_order. /* V8 - V15 are call-saved, and skipped. */ Which works as well, I suppose. I dunno which makes more sense. r~