From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 529DCC636D3 for ; Mon, 6 Feb 2023 19:18:12 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pP6zc-0006oN-4k; Mon, 06 Feb 2023 14:17:32 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pP6zG-0006n0-4u for qemu-devel@nongnu.org; Mon, 06 Feb 2023 14:17:30 -0500 Received: from mail-pf1-x42c.google.com ([2607:f8b0:4864:20::42c]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pP6zE-00017M-4W for qemu-devel@nongnu.org; Mon, 06 Feb 2023 14:17:09 -0500 Received: by mail-pf1-x42c.google.com with SMTP id n2so9149906pfo.3 for ; Mon, 06 Feb 2023 11:17:07 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=M77PmTTuHS2VyDvgrVyimi5pdY4ZRAlDugEZHT2trqQ=; b=OPqQdXcGsJBxLVnbp/t4cFE4rfFG0qx8GqYyXd+vi9mxj3sk+v/+oP80Y1rT3b/j7A 0s68JlGPCpo/+/sKkOHWvj/oTcTy8nBDCu8SYGA4uKgWYrcqvWz6/CRItV+VqaLhiy0C 9WbRRvwbYGkAZvQF5Rc4nnzqHuCgrzntk1LEFOuj65LEbMU1bXYiGPWOjwEh3P0wHB8X NSYphI+E2C91nbFd6PheBSt3iX3SJk3myO3W7q85iPe4HXCBaCTz2Bu9WCp7F3mupl+A upWZD6EaATQ9/5u34e1W+QqhfXa4hXShK6f0/Tv1B7dGOxm/A/EbRyVvDDjI8RYRS3hq fO5Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=M77PmTTuHS2VyDvgrVyimi5pdY4ZRAlDugEZHT2trqQ=; b=D5erTAHp19EzKgtWVRcjn1BffqgNi8dV5noxpW0nuhHODSB+/ne9XjlFUvDNMy1C5r 2i+m5CqdaZrmIsVf4FzJYbqv7HAL2SZhlsXxmJvhhim7ooivkdjCOpwPvWxHS1gbimBG EplpbHxnkVzJrW+jd62rQzgABxSGRQbo6EAXXuFx/8r+BcWu6ZE1iXGFXHAmIFOtbaW6 zNuKi/1nD3EyBNX92FqzILbGVIy+BfILsRvjy5NrBOmDZSp4K1oLGrPPblLY9F6Spckn JpCZb4zZ2tAfPn6ypG95NCRRSBvU929ok6pnkHyBptDra/jss0lVpXFdkgehuEK+l0+N sQRw== X-Gm-Message-State: AO0yUKXySldnjajCsBPVVESFzSVQwKuomnGmWznHZf43x2f5E7PT3+Ci Pj3UPaPeBu4kYny2shXzeez7MA== X-Google-Smtp-Source: AK7set8I+1dmO1P1fVcelQelVf2ZA12xJg+yNk3pzet7+mSFb2iNlzXNkKsZ2E1Oq5NvDaklUXpQ5w== X-Received: by 2002:a62:1792:0:b0:592:705a:5a5e with SMTP id 140-20020a621792000000b00592705a5a5emr449132pfx.9.1675711026451; Mon, 06 Feb 2023 11:17:06 -0800 (PST) Received: from [192.168.101.227] (rrcs-74-87-59-234.west.biz.rr.com. [74.87.59.234]) by smtp.gmail.com with ESMTPSA id i22-20020aa787d6000000b005998a75dbc5sm5177239pfo.2.2023.02.06.11.17.05 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 06 Feb 2023 11:17:05 -0800 (PST) Message-ID: Date: Mon, 6 Feb 2023 09:17:02 -1000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.2 Subject: Re: [PATCH 6/9] target/arm: Restrict CPUARMState::nvic to sysemu and store as NVICState* Content-Language: en-US To: =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= , qemu-devel@nongnu.org Cc: qemu-arm@nongnu.org, Peter Maydell References: <20230206121714.85084-1-philmd@linaro.org> <20230206121714.85084-7-philmd@linaro.org> <888efe85-b495-41c6-742e-70e9a0a5dfe1@linaro.org> <55a05bd4-5dd9-6880-2d61-22c31298d1bf@linaro.org> From: Richard Henderson In-Reply-To: <55a05bd4-5dd9-6880-2d61-22c31298d1bf@linaro.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=2607:f8b0:4864:20::42c; envelope-from=richard.henderson@linaro.org; helo=mail-pf1-x42c.google.com X-Spam_score_int: -31 X-Spam_score: -3.2 X-Spam_bar: --- X-Spam_report: (-3.2 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, NICE_REPLY_A=-1.148, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org On 2/6/23 09:00, Philippe Mathieu-Daudé wrote: > On 6/2/23 19:57, Richard Henderson wrote: >> On 2/6/23 02:17, Philippe Mathieu-Daudé wrote: >>> There is no point in using a void pointer to access the NVIC. >>> Use the real type to avoid casting it while debugging. >>> >>> Signed-off-by: Philippe Mathieu-Daudé >>> --- >> >> This is doing several things at once.  The nvic interface change needn't be done >> simultaneously. > > You mean this change? > > -typedef struct NVICState NVICState; > -DECLARE_INSTANCE_CHECKER(NVICState, NVIC, > -                         TYPE_NVIC) > +OBJECT_DECLARE_SIMPLE_TYPE(NVICState, NVIC) > > This is a No-OP, converting from the older DECLARE_INSTANCE_CHECKER > style to the newer OBJECT_DECLARE_SIMPLE_TYPE. But OK, unrelated, I'll > remove it from the patch. That and the movement of cpu->nvic into the ifdef. r~