From: Paolo Bonzini <pbonzini@redhat.com>
To: P J P <ppandit@redhat.com>
Cc: Qemu Developers <qemu-devel@nongnu.org>,
Li Qiang <liqiang6-s@360.cn>, Laszlo Ersek <lersek@redhat.com>
Subject: Re: [Qemu-devel] [PATCH v3] scsi: esp: check length before dma read
Date: Wed, 15 Jun 2016 20:27:21 +0200 [thread overview]
Message-ID: <e026215c-c578-0ca2-8e24-a2090df311b1@redhat.com> (raw)
In-Reply-To: <alpine.LFD.2.20.1606152243100.27734@wniryva>
On 15/06/2016 19:18, P J P wrote:
> Hello Paolo,
>
> +-- On Wed, 15 Jun 2016, Paolo Bonzini wrote --+
> | Actually, the commit message is wrong. The length parameter cannot
> | exceed the buffer size anymore.
>
> It wouldn't exceed after this patch, right? Is it possible 'esp_do_dma' is
> called via 'esp_transfer_data' with 's->do_cmd' set? 'len' isn't checked
> there.
No, it's not possible; see the discussion in reply to v1.
Paolo
prev parent reply other threads:[~2016-06-15 18:27 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-15 16:16 [Qemu-devel] [PATCH v3] scsi: esp: check length before dma read P J P
2016-06-15 16:34 ` Paolo Bonzini
2016-06-15 16:36 ` Paolo Bonzini
2016-06-15 17:18 ` P J P
2016-06-15 18:27 ` Paolo Bonzini [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e026215c-c578-0ca2-8e24-a2090df311b1@redhat.com \
--to=pbonzini@redhat.com \
--cc=lersek@redhat.com \
--cc=liqiang6-s@360.cn \
--cc=ppandit@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).