From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:50730) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1c4qeR-0002b4-Pw for qemu-devel@nongnu.org; Thu, 10 Nov 2016 09:48:32 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1c4qeO-0001kX-0b for qemu-devel@nongnu.org; Thu, 10 Nov 2016 09:48:27 -0500 Received: from mx0b-001b2d01.pphosted.com ([148.163.158.5]:43802 helo=mx0a-001b2d01.pphosted.com) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1c4qeN-0001kA-QD for qemu-devel@nongnu.org; Thu, 10 Nov 2016 09:48:23 -0500 Received: from pps.filterd (m0098419.ppops.net [127.0.0.1]) by mx0b-001b2d01.pphosted.com (8.16.0.17/8.16.0.17) with SMTP id uAAEj0Gs085668 for ; Thu, 10 Nov 2016 09:48:23 -0500 Received: from e06smtp05.uk.ibm.com (e06smtp05.uk.ibm.com [195.75.94.101]) by mx0b-001b2d01.pphosted.com with ESMTP id 26mr1eyd4t-1 (version=TLSv1.2 cipher=AES256-SHA bits=256 verify=NOT) for ; Thu, 10 Nov 2016 09:48:22 -0500 Received: from localhost by e06smtp05.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Thu, 10 Nov 2016 14:48:21 -0000 Received: from b06cxnps4074.portsmouth.uk.ibm.com (d06relay11.portsmouth.uk.ibm.com [9.149.109.196]) by d06dlp03.portsmouth.uk.ibm.com (Postfix) with ESMTP id 950731B08061 for ; Thu, 10 Nov 2016 14:50:32 +0000 (GMT) Received: from d06av03.portsmouth.uk.ibm.com (d06av03.portsmouth.uk.ibm.com [9.149.37.213]) by b06cxnps4074.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id uAAEmJI030408804 for ; Thu, 10 Nov 2016 14:48:19 GMT Received: from d06av03.portsmouth.uk.ibm.com (localhost [127.0.0.1]) by d06av03.portsmouth.uk.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id uAAEmIhS009059 for ; Thu, 10 Nov 2016 07:48:18 -0700 References: <1477850917-1214-1-git-send-email-mst@redhat.com> <1477850917-1214-13-git-send-email-mst@redhat.com> <925e80d1-f936-4519-9490-9c40d129392e@de.ibm.com> <75f9936a-443a-79ee-8e44-ff4b93ab66bc@redhat.com> From: Christian Borntraeger Date: Thu, 10 Nov 2016 15:48:17 +0100 MIME-Version: 1.0 In-Reply-To: <75f9936a-443a-79ee-8e44-ff4b93ab66bc@redhat.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Message-Id: Subject: Re: [Qemu-devel] [PULL 12/47] virtio: remove ioeventfd_disabled altogether List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini , "Michael S. Tsirkin" , qemu-devel@nongnu.org Cc: Cornelia Huck , Peter Maydell On 11/10/2016 03:38 PM, Paolo Bonzini wrote: > > > On 10/11/2016 15:35, Christian Borntraeger wrote: >> On 10/30/2016 10:23 PM, Michael S. Tsirkin wrote: >>> From: Paolo Bonzini >>> >>> Now that there is not anymore a switch from the generic ioeventfd handler >>> to the dataplane handler, virtio_bus_set_host_notifier(assign=true) is >>> always called with !bus->ioeventfd_started, hence virtio_bus_stop_ioeventfd >>> does nothing in this case. Move the invocation to vhost.c, which is the >>> only place that needs it. >>> >>> Reviewed-by: Cornelia Huck >>> Signed-off-by: Paolo Bonzini >>> Reviewed-by: Michael S. Tsirkin >>> Signed-off-by: Michael S. Tsirkin >>> --- >>> include/hw/virtio/virtio-bus.h | 6 ------ >>> hw/virtio/vhost.c | 3 +++ >>> hw/virtio/virtio-bus.c | 23 ++++++++--------------- >>> 3 files changed, 11 insertions(+), 21 deletions(-) >> >> This breaks vhost-net for s390/kvm after rebooting the guest. (ping fails and >> ifconfig shows no packets is TXed) >> >> Any idea? > > Patch from Felipe: > [PATCH v2] vhost: Update 'ioeventfd_started' with host notifiers > > Paolo Yes, that fixes the issue