From: Marcin Juszkiewicz <marcin.juszkiewicz@linaro.org>
To: Niklas Cassel <nks@flawful.org>, John Snow <jsnow@redhat.com>,
Kevin Wolf <kwolf@redhat.com>
Cc: qemu-block@nongnu.org, qemu-devel@nongnu.org,
Damien Le Moal <dlemoal@kernel.org>,
Michael Tokarev <mjt@tls.msk.ru>,
Niklas Cassel <niklas.cassel@wdc.com>
Subject: Re: [PATCH v3] hw/ide/ahci: fix legacy software reset
Date: Thu, 9 Nov 2023 08:16:15 +0100 [thread overview]
Message-ID: <e036e998-597c-441f-8c8a-569e2350b30a@linaro.org> (raw)
In-Reply-To: <20231108222657.117984-1-nks@flawful.org>
W dniu 8.11.2023 o 23:26, Niklas Cassel pisze:
> From: Niklas Cassel <niklas.cassel@wdc.com>
> This fixes an issue for FreeBSD where the device would fail to reset.
> The problem was not noticed in Linux, because Linux uses a COMRESET
> instead of a legacy software reset by default.
>
> Fixes: e2a5d9b3d9c3 ("hw/ide/ahci: simplify and document PxCI handling")
> Reported-by: Marcin Juszkiewicz <marcin.juszkiewicz@linaro.org>
> Signed-off-by: Niklas Cassel <niklas.cassel@wdc.com>
Tested-by: Marcin Juszkiewicz <marcin.juszkiewicz@linaro.org>
FreeBSD 14-rc3 boots fine on AArch64 with this patch:
Trying to mount root from cd9660:/dev/iso9660/14_0_RC3_AARCH64_BO [ro]...
cd0 at ahcich0 bus 0 scbus0 target 0 lun 0
cd0: <QEMU QEMU DVD-ROM 2.5+> Removable CD-ROM SCSI device
cd0: Serial Number QM00001
cd0: 150.000MB/s transfers (SATA 1.x, UDMA5, ATAPI 12bytes, PIO 8192bytes)
cd0: 347MB (177954 2048 byte sectors)
ada0 at ahcich1 bus 0 scbus1 target 0 lun 0
ada0: <QEMU HARDDISK 2.5+> ATA-7 SATA device
ada0: Serial Number QM00003
ada0: 150.000MB/s transfers (SATA 1.x, UDMA5, PIO 8192bytes)
ada0: Command Queueing enabled
ada0: 504MB (1032192 512 byte sectors)
ada1 at ahcich2 bus 0 scbus2 target 0 lun 0
ada1: <QEMU HARDDISK 2.5+> ATA-7 SATA device
ada1: Serial Number QM00005
ada1: 150.000MB/s transfers (SATA 1.x, UDMA5, PIO 8192bytes)
ada1: Command Queueing enabled
ada1: 8192MB (16777216 512 byte sectors)
next prev parent reply other threads:[~2023-11-09 7:17 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-08 22:26 [PATCH v3] hw/ide/ahci: fix legacy software reset Niklas Cassel
2023-11-09 7:16 ` Marcin Juszkiewicz [this message]
2023-11-10 9:51 ` Kevin Wolf
2023-11-18 7:34 ` Michael Tokarev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e036e998-597c-441f-8c8a-569e2350b30a@linaro.org \
--to=marcin.juszkiewicz@linaro.org \
--cc=dlemoal@kernel.org \
--cc=jsnow@redhat.com \
--cc=kwolf@redhat.com \
--cc=mjt@tls.msk.ru \
--cc=niklas.cassel@wdc.com \
--cc=nks@flawful.org \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).