From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.2 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 56A74C433E0 for ; Fri, 12 Feb 2021 23:14:54 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B3DB464DEB for ; Fri, 12 Feb 2021 23:14:53 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B3DB464DEB Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:33692 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lAheG-0001hn-Nb for qemu-devel@archiver.kernel.org; Fri, 12 Feb 2021 18:14:52 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:35208) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lAhdN-00012X-BY for qemu-devel@nongnu.org; Fri, 12 Feb 2021 18:13:58 -0500 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:45946) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1lAhdH-0002N3-Cr for qemu-devel@nongnu.org; Fri, 12 Feb 2021 18:13:57 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1613171628; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=u5VluzrXdvX8x7x6QlYHtRLXnx6hvxw0XZYPAazSTpE=; b=c2jYj/jFaIsEshxuPWYQUcPoHN+irlVMSdjifDJ0IwSqMB5mYQ8jAvGw+eTQnIXwpNsSNc yqcq/ZPVU+8CsqYRstNw/6JjBA7Y8lfq+8Xlo80nfXFx3LaL4TYpUfYAm6zIK+i9GVdkOc EjYJwjHmXvm/PzsHxrZwieYWm0ibrUg= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-571-5Mw2wsMMNQCqnxNk_Uc1xg-1; Fri, 12 Feb 2021 18:13:44 -0500 X-MC-Unique: 5Mw2wsMMNQCqnxNk_Uc1xg-1 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id DC6CB801965; Fri, 12 Feb 2021 23:13:42 +0000 (UTC) Received: from [10.3.114.150] (ovpn-114-150.phx2.redhat.com [10.3.114.150]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 9C01A6E51F; Fri, 12 Feb 2021 23:13:38 +0000 (UTC) To: Vladimir Sementsov-Ogievskiy , qemu-block@nongnu.org References: <20210202124956.63146-1-vsementsov@virtuozzo.com> <20210202124956.63146-4-vsementsov@virtuozzo.com> From: Eric Blake Organization: Red Hat, Inc. Subject: Re: [PATCH v7 03/14] block: check return value of bdrv_open_child and drop error propagation Message-ID: Date: Fri, 12 Feb 2021 17:13:37 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.0 MIME-Version: 1.0 In-Reply-To: <20210202124956.63146-4-vsementsov@virtuozzo.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=eblake@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=216.205.24.124; envelope-from=eblake@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -34 X-Spam_score: -3.5 X-Spam_bar: --- X-Spam_report: (-3.5 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.569, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, NICE_REPLY_A=-0.119, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: kwolf@redhat.com, berto@igalia.com, pavel.dovgaluk@ispras.ru, qemu-devel@nongnu.org, armbru@redhat.com, Greg Kurz , stefanha@redhat.com, pbonzini@redhat.com, mreitz@redhat.com, jsnow@redhat.com, ari@tuxera.com Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 2/2/21 6:49 AM, Vladimir Sementsov-Ogievskiy wrote: > This patch is generated by cocci script: > > @@ > symbol bdrv_open_child, errp, local_err; > expression file; > @@ > > file = bdrv_open_child(..., > - &local_err > + errp > ); > - if (local_err) > + if (!file) > { > ... > - error_propagate(errp, local_err); > ... > } > > with command > > spatch --sp-file x.cocci --macro-file scripts/cocci-macro-file.h \ > --in-place --no-show-diff --max-width 80 --use-gitgrep block With this patch applied, 'check unit-test' fails with: Running test test-replication Unexpected error in bdrv_open_driver() at ../block.c:1481: Could not open '/tmp/p_local_disk.z1Ugyc': Invalid argument ERROR test-replication - missing test plan Directly reverting it has ripple effect on later patches in the series. Running test-replication under gdb gives this backtrace: Thread 1 "test-replicatio" received signal SIGABRT, Aborted. 0x00007ffff6f6f9d5 in raise () from /lib64/libc.so.6 (gdb) bt #0 0x00007ffff6f6f9d5 in raise () from /lib64/libc.so.6 #1 0x00007ffff6f588a4 in abort () from /lib64/libc.so.6 #2 0x00005555556ad820 in error_handle_fatal ( errp=0x555555790568 , err=0x555555859010) at ../util/error.c:40 #3 0x00005555556ae3cf in error_propagate ( dst_errp=0x555555790568 , local_err=0x555555859010) at ../util/error.c:286 #4 0x000055555558cc9e in bdrv_img_create ( filename=0x555555822500 "/tmp/p_local_disk.DVFoWt", fmt=0x5555556e809a "qcow2", base_filename=0x0, base_fmt=0x0, options=0x0, img_size=67108864, flags=2, quiet=true, errp=0x555555790568 ) at ../block.c:6312 > > Signed-off-by: Vladimir Sementsov-Ogievskiy > Reviewed-by: Greg Kurz > Reviewed-by: Alberto Garcia > --- > block/blkdebug.c | 6 ++---- > block/blklogwrites.c | 10 ++++------ > block/blkreplay.c | 6 ++---- > block/blkverify.c | 11 ++++------- > block/qcow2.c | 5 ++--- > block/quorum.c | 6 ++---- > 6 files changed, 16 insertions(+), 28 deletions(-) And this diffstat doesn't immediately tell me what ended up violating the assumptions of error_abort. As such, at this point I'm temporarily dropping the remainder of the series from my bitmaps queue, and only including patches 1 and 2 in my next pull request. Looking forward to v8. -- Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3226 Virtualization: qemu.org | libvirt.org