Re: [PATCH 1/1] MAINTAINERS: Add Python library stanza

[John Snow <jsnow@redhat.com>]

On 7/13/20 9:35 AM, Alex Bennée wrote:
> 
> John Snow <jsnow@redhat.com> writes:
> 
>> I'm proposing that I split the actual Python library off from the other
>> miscellaneous python scripts we have and declare it maintained. Add
>> myself as a maintainer of this folder, along with Cleber.
>>
>> Signed-off-by: John Snow <jsnow@redhat.com>
>> ---
>>  MAINTAINERS | 9 ++++++++-
>>  1 file changed, 8 insertions(+), 1 deletion(-)
>>
>> diff --git a/MAINTAINERS b/MAINTAINERS
>> index 6aa54f7f8f..fe1dcd5a76 100644
>> --- a/MAINTAINERS
>> +++ b/MAINTAINERS
>> @@ -2280,11 +2280,18 @@ S: Maintained
>>  F: include/sysemu/cryptodev*.h
>>  F: backends/cryptodev*.c
>>  
>> +Python library
>> +M: John Snow <jsnow@redhat.com>
>> +M: Cleber Rosa <crosa@redhat.com>
>> +R: Eduardo Habkost <ehabkost@redhat.com>
>> +S: Maintained
>> +F: python/*
> 
> I don't think that's equivalent to what you drop bellow:
> 
>     F:	drivers/net/	all files in and below drivers/net
>     F:	drivers/net/*	all files in drivers/net, but not below
> 
> So I think you should drop the *
> 

I didn't realize that, thanks for correcting it.

>> +T: git https://gitlab.com/jsnow/qemu.git python
>> +
>>  Python scripts
>>  M: Eduardo Habkost <ehabkost@redhat.com>
>>  M: Cleber Rosa <crosa@redhat.com>
>>  S: Odd fixes
>> -F: python/qemu/*py
>>  F: scripts/*.py
>>  F: tests/*.py
> 
> Otherwise:
> 
> Reviewed-by: Alex Bennée <alex.bennee@linaro.org>
> 

I swear I talked to Cleber and Eduardo before sending this, we'll wait
for them to say hi :)