From: Eric Blake <eblake@redhat.com>
To: Roman Kagan <rvkagan@yandex-team.ru>, qemu-devel@nongnu.org
Cc: "Kevin Wolf" <kwolf@redhat.com>, "Fam Zheng" <fam@euphon.net>,
"Stefano Stabellini" <sstabellini@kernel.org>,
"Daniel P. Berrangé" <berrange@redhat.com>,
"Eduardo Habkost" <ehabkost@redhat.com>,
qemu-block@nongnu.org, "Paul Durrant" <paul@xen.org>,
"John Snow" <jsnow@redhat.com>,
"Michael S. Tsirkin" <mst@redhat.com>,
"Laurent Vivier" <laurent@vivier.eu>,
"Max Reitz" <mreitz@redhat.com>,
"Keith Busch" <kbusch@kernel.org>,
"Gerd Hoffmann" <kraxel@redhat.com>,
"Stefan Hajnoczi" <stefanha@redhat.com>,
"Paolo Bonzini" <pbonzini@redhat.com>,
"Anthony Perard" <anthony.perard@citrix.com>,
xen-devel@lists.xenproject.org,
"Philippe Mathieu-Daudé" <philmd@redhat.com>
Subject: Re: [PATCH v6 2/5] block: consolidate blocksize properties consistency checks
Date: Wed, 27 May 2020 09:36:14 -0500 [thread overview]
Message-ID: <e087aca6-1612-6bc4-9a0a-0c5c69fb2b74@redhat.com> (raw)
In-Reply-To: <20200527124511.986099-3-rvkagan@yandex-team.ru>
On 5/27/20 7:45 AM, Roman Kagan wrote:
> Several block device properties related to blocksize configuration must
> be in certain relationship WRT each other: physical block must be no
> smaller than logical block; min_io_size, opt_io_size, and
> discard_granularity must be a multiple of a logical block.
>
> To ensure these requirements are met, add corresponding consistency
> checks to blkconf_blocksizes, adjusting its signature to communicate
> possible error to the caller. Also remove the now redundant consistency
> checks from the specific devices.
>
> Signed-off-by: Roman Kagan <rvkagan@yandex-team.ru>
> ---
Reviewed-by: Eric Blake <eblake@redhat.com>
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3226
Virtualization: qemu.org | libvirt.org
next prev parent reply other threads:[~2020-05-27 14:37 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-27 12:45 [PATCH v6 0/5] block: enhance handling of size-related BlockConf properties Roman Kagan
2020-05-27 12:45 ` [PATCH v6 1/5] virtio-blk: store opt_io_size with correct size Roman Kagan
2020-05-27 12:45 ` [PATCH v6 2/5] block: consolidate blocksize properties consistency checks Roman Kagan
2020-05-27 14:36 ` Eric Blake [this message]
2020-05-28 7:22 ` Paul Durrant
2020-05-27 12:45 ` [PATCH v6 3/5] qdev-properties: blocksize: use same limits in code and description Roman Kagan
2020-05-27 14:37 ` Eric Blake
2020-05-27 12:45 ` [PATCH v6 4/5] block: make size-related BlockConf properties accept size suffixes Roman Kagan
2020-05-27 14:50 ` Eric Blake
2020-05-27 20:53 ` Roman Kagan
2020-05-27 21:03 ` Eric Blake
2020-05-27 12:45 ` [PATCH v6 5/5] block: lift blocksize property limit to 2 MiB Roman Kagan
2020-05-27 14:52 ` Eric Blake
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e087aca6-1612-6bc4-9a0a-0c5c69fb2b74@redhat.com \
--to=eblake@redhat.com \
--cc=anthony.perard@citrix.com \
--cc=berrange@redhat.com \
--cc=ehabkost@redhat.com \
--cc=fam@euphon.net \
--cc=jsnow@redhat.com \
--cc=kbusch@kernel.org \
--cc=kraxel@redhat.com \
--cc=kwolf@redhat.com \
--cc=laurent@vivier.eu \
--cc=mreitz@redhat.com \
--cc=mst@redhat.com \
--cc=paul@xen.org \
--cc=pbonzini@redhat.com \
--cc=philmd@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=rvkagan@yandex-team.ru \
--cc=sstabellini@kernel.org \
--cc=stefanha@redhat.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).