From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 67B63C433FF for ; Wed, 14 Aug 2019 16:25:07 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 417E020665 for ; Wed, 14 Aug 2019 16:25:07 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 417E020665 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:34108 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1hxw5C-000179-5h for qemu-devel@archiver.kernel.org; Wed, 14 Aug 2019 12:25:06 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:50900) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1hxw3g-0000EF-2S for qemu-devel@nongnu.org; Wed, 14 Aug 2019 12:23:32 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hxw3f-0000Jh-5U for qemu-devel@nongnu.org; Wed, 14 Aug 2019 12:23:31 -0400 Received: from mx1.redhat.com ([209.132.183.28]:53338) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hxw3c-0000Fv-Dz; Wed, 14 Aug 2019 12:23:28 -0400 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 8A8223175289; Wed, 14 Aug 2019 16:23:27 +0000 (UTC) Received: from dresden.str.redhat.com (unknown [10.40.205.121]) by smtp.corp.redhat.com (Postfix) with ESMTPS id C1AAF81E3B; Wed, 14 Aug 2019 16:23:23 +0000 (UTC) To: Vladimir Sementsov-Ogievskiy , qemu-devel@nongnu.org, qemu-block@nongnu.org References: <20190730141826.709849-1-vsementsov@virtuozzo.com> <20190730141826.709849-4-vsementsov@virtuozzo.com> From: Max Reitz Openpgp: preference=signencrypt Autocrypt: addr=mreitz@redhat.com; prefer-encrypt=mutual; keydata= mQENBFXOJlcBCADEyyhOTsoa/2ujoTRAJj4MKA21dkxxELVj3cuILpLTmtachWj7QW+TVG8U /PsMCFbpwsQR7oEy8eHHZwuGQsNpEtNC2G/L8Yka0BIBzv7dEgrPzIu+W3anZXQW4702+uES U29G8TP/NGfXRRHGlbBIH9KNUnOSUD2vRtpOLXkWsV5CN6vQFYgQfFvmp5ZpPeUe6xNplu8V mcTw8OSEDW/ZnxJc8TekCKZSpdzYoxfzjm7xGmZqB18VFwgJZlIibt1HE0EB4w5GsD7x5ekh awIe3RwoZgZDLQMdOitJ1tUc8aqaxvgA4tz6J6st8D8pS//m1gAoYJWGwwIVj1DjTYLtABEB AAG0HU1heCBSZWl0eiA8bXJlaXR6QHJlZGhhdC5jb20+iQFTBBMBCAA9AhsDBQkSzAMABQsJ CAcCBhUICQoLAgQWAgMBAh4BAheABQJVzie5FRhoa3A6Ly9rZXlzLmdudXBnLm5ldAAKCRD0 B9sAYdXPQDcIB/9uNkbYEex1rHKz3mr12uxYMwLOOFY9fstP5aoVJQ1nWQVB6m2cfKGdcRe1 2/nFaHSNAzT0NnKz2MjhZVmcrpyd2Gp2QyISCfb1FbT82GMtXFj1wiHmPb3CixYmWGQUUh+I AvUqsevLA+WihgBUyaJq/vuDVM1/K9Un+w+Tz5vpeMidlIsTYhcsMhn0L9wlCjoucljvbDy/ 8C9L2DUdgi3XTa0ORKeflUhdL4gucWoAMrKX2nmPjBMKLgU7WLBc8AtV+84b9OWFML6NEyo4 4cP7cM/07VlJK53pqNg5cHtnWwjHcbpGkQvx6RUx6F1My3y52vM24rNUA3+ligVEgPYBuQEN BFXOJlcBCADAmcVUNTWT6yLWQHvxZ0o47KCP8OcLqD+67T0RCe6d0LP8GsWtrJdeDIQk+T+F xO7DolQPS6iQ6Ak2/lJaPX8L0BkEAiMuLCKFU6Bn3lFOkrQeKp3u05wCSV1iKnhg0UPji9V2 W5eNfy8F4ZQHpeGUGy+liGXlxqkeRVhLyevUqfU0WgNqAJpfhHSGpBgihUupmyUg7lfUPeRM DzAN1pIqoFuxnN+BRHdAecpsLcbR8sQddXmDg9BpSKozO/JyBmaS1RlquI8HERQoe6EynJhd 64aICHDfj61rp+/0jTIcevxIIAzW70IadoS/y3DVIkuhncgDBvGbF3aBtjrJVP+5ABEBAAGJ ASUEGAEIAA8FAlXOJlcCGwwFCRLMAwAACgkQ9AfbAGHVz0CbFwf9F/PXxQR9i4N0iipISYjU sxVdjJOM2TMut+ZZcQ6NSMvhZ0ogQxJ+iEQ5OjnIputKvPVd5U7WRh+4lF1lB/NQGrGZQ1ic alkj6ocscQyFwfib+xIe9w8TG1CVGkII7+TbS5pXHRxZH1niaRpoi/hYtgzkuOPp35jJyqT/ /ELbqQTDAWcqtJhzxKLE/ugcOMK520dJDeb6x2xVES+S5LXby0D4juZlvUj+1fwZu+7Io5+B bkhSVPb/QdOVTpnz7zWNyNw+OONo1aBUKkhq2UIByYXgORPFnbfMY7QWHcjpBVw9MgC4tGeF R4bv+1nAMMxKmb5VvQCExr0eFhJUAHAhVg== Message-ID: Date: Wed, 14 Aug 2019 18:23:21 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 MIME-Version: 1.0 In-Reply-To: <20190730141826.709849-4-vsementsov@virtuozzo.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="20KaJuJD2m0DVCCHJIRgxsmTZDPMJrB60" X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.49]); Wed, 14 Aug 2019 16:23:27 +0000 (UTC) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.132.183.28 Subject: Re: [Qemu-devel] [PATCH v2 3/4] block/qcow2: refactor qcow2_co_pwritev_part X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: kwolf@redhat.com, den@openvz.org, armbru@redhat.com, stefanha@redhat.com Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --20KaJuJD2m0DVCCHJIRgxsmTZDPMJrB60 Content-Type: multipart/mixed; boundary="AOCATZJ4w1fyRAhSUgTKoQup8BENOGB70"; protected-headers="v1" From: Max Reitz To: Vladimir Sementsov-Ogievskiy , qemu-devel@nongnu.org, qemu-block@nongnu.org Cc: armbru@redhat.com, eblake@redhat.com, kwolf@redhat.com, den@openvz.org, stefanha@redhat.com Message-ID: Subject: Re: [PATCH v2 3/4] block/qcow2: refactor qcow2_co_pwritev_part References: <20190730141826.709849-1-vsementsov@virtuozzo.com> <20190730141826.709849-4-vsementsov@virtuozzo.com> In-Reply-To: <20190730141826.709849-4-vsementsov@virtuozzo.com> --AOCATZJ4w1fyRAhSUgTKoQup8BENOGB70 Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: quoted-printable On 30.07.19 16:18, Vladimir Sementsov-Ogievskiy wrote: > Similarly to previous commit, prepare for parallelizing write-loop > iterations. >=20 > Signed-off-by: Vladimir Sementsov-Ogievskiy > --- > block/qcow2.c | 150 +++++++++++++++++++++++++++++---------------------= > 1 file changed, 88 insertions(+), 62 deletions(-) >=20 > diff --git a/block/qcow2.c b/block/qcow2.c > index 7fa71968b2..37766b8b7c 100644 > --- a/block/qcow2.c > +++ b/block/qcow2.c [...] > + * l2meta - if not NULL, qcow2_co_do_pwritev() will consume it. Calle= r must not > + * use it somehow after qcow2_co_pwritev_task() call [...] > + l2meta =3D NULL; /* l2meta is consumed by qcow2_co_do_pwritev(= ) */ By the way, qcow2_co_do_pwritev() does not exist. :-) Max --AOCATZJ4w1fyRAhSUgTKoQup8BENOGB70-- --20KaJuJD2m0DVCCHJIRgxsmTZDPMJrB60 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEEkb62CjDbPohX0Rgp9AfbAGHVz0AFAl1UNXkACgkQ9AfbAGHV z0B2JQgAkdrhM8DNA5nzo156A+fzSN+d8AjqYJEmFe6Q5GeuP0OScABFShUxlZtO H0RLLM9nWQmUTmCVgdQfISLS5XRNFqb75cVSVMPjatLvGyWQX1KyNazUgAgr6PcL 6fMiR5X0SBgMF+cxlZtC/gD/jA4dzvBuJsx1Vmct8GQPJ0ZzhnolyaT7DHXtk4Vl TBuXIalrxsMzPfAgIeu5guoHWosXhcxrtCQCX3hNx3Y+dHFMNLSis6f0KjxLIgND suXb4kX8Om46dittJ7npge0PEWZXZsUpUhQYCHwp7GygcTPrICd5nPNZr9O9juHv 7TFVvnBGyKW7U3wPmrwK/4KZOaEAww== =QFFJ -----END PGP SIGNATURE----- --20KaJuJD2m0DVCCHJIRgxsmTZDPMJrB60--