Re: [PATCH 1/1] scripts: fix broken error path in modinfo-collect.py

["Philippe Mathieu-Daudé" <philmd@linaro.org>]

On 3/12/25 23:01, Denis V. Lunev via wrote:
> sys.stderr.print is dropped long ago and should not be used. Official
> replacement is sys.stderr.write
> 
> The problem has been found debugging building on some fancy platform
> derived from Debian.
> 
> Signed-off-by: Denis V. Lunev <den@openvz.org>
> CC: John Snow <jsnow@redhat.com>
> CC: Cleber Rosa <crosa@redhat.com>
> ---
>   scripts/modinfo-collect.py | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/scripts/modinfo-collect.py b/scripts/modinfo-collect.py
> index 6ebaea989d..db78b16c1f 100644
> --- a/scripts/modinfo-collect.py
> +++ b/scripts/modinfo-collect.py
> @@ -41,7 +41,7 @@ def main(args):
>       for obj in args:
>           entry = compile_commands.get(obj, None)
>           if not entry:
> -            sys.stderr.print('modinfo: Could not find object file', obj)
> +            sys.stderr.write(f'modinfo: Could not find object file {obj}')

Missing trailing '\n'? Otherwise,

Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>

>               sys.exit(1)
>           src = entry['file']
>           if not src.endswith('.c'):