qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] linux-user/riscv: change default cpu to 'max'
@ 2023-10-20  7:45 Daniel Henrique Barboza
  2023-10-20 14:08 ` Philippe Mathieu-Daudé
                   ` (3 more replies)
  0 siblings, 4 replies; 7+ messages in thread
From: Daniel Henrique Barboza @ 2023-10-20  7:45 UTC (permalink / raw)
  To: qemu-devel
  Cc: qemu-riscv, alistair.francis, bmeng, liweiwei, zhiwei_liu, palmer,
	Daniel Henrique Barboza, Richard Henderson

Commit f57d5f8004 deprecated the 'any' CPU type but failed to change the
default CPU for linux-user. The result is that all linux-users
invocations that doesn't specify a different CPU started to show a
deprecation warning:

$ ./build/qemu-riscv64  ./foo-novect.out
qemu-riscv64: warning: The 'any' CPU is deprecated and will be removed in the future.

Change the default CPU for RISC-V linux-user from 'any' to 'max'.

Reported-by: Richard Henderson <richard.henderson@linaro.org>
Fixes: f57d5f8004 ("target/riscv: deprecate the 'any' CPU type")
Signed-off-by: Daniel Henrique Barboza <dbarboza@ventanamicro.com>
---
 linux-user/riscv/target_elf.h | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/linux-user/riscv/target_elf.h b/linux-user/riscv/target_elf.h
index 9dd65652ee..dedd5956f3 100644
--- a/linux-user/riscv/target_elf.h
+++ b/linux-user/riscv/target_elf.h
@@ -9,7 +9,6 @@
 #define RISCV_TARGET_ELF_H
 static inline const char *cpu_get_model(uint32_t eflags)
 {
-    /* TYPE_RISCV_CPU_ANY */
-    return "any";
+    return "max";
 }
 #endif
-- 
2.41.0



^ permalink raw reply related	[flat|nested] 7+ messages in thread

* Re: [PATCH] linux-user/riscv: change default cpu to 'max'
  2023-10-20  7:45 [PATCH] linux-user/riscv: change default cpu to 'max' Daniel Henrique Barboza
@ 2023-10-20 14:08 ` Philippe Mathieu-Daudé
  2023-10-20 16:06 ` Richard Henderson
                   ` (2 subsequent siblings)
  3 siblings, 0 replies; 7+ messages in thread
From: Philippe Mathieu-Daudé @ 2023-10-20 14:08 UTC (permalink / raw)
  To: Daniel Henrique Barboza, qemu-devel
  Cc: qemu-riscv, alistair.francis, bmeng, liweiwei, zhiwei_liu, palmer,
	Richard Henderson

On 20/10/23 09:45, Daniel Henrique Barboza wrote:
> Commit f57d5f8004 deprecated the 'any' CPU type but failed to change the
> default CPU for linux-user. The result is that all linux-users
> invocations that doesn't specify a different CPU started to show a
> deprecation warning:
> 
> $ ./build/qemu-riscv64  ./foo-novect.out
> qemu-riscv64: warning: The 'any' CPU is deprecated and will be removed in the future.
> 
> Change the default CPU for RISC-V linux-user from 'any' to 'max'.
> 
> Reported-by: Richard Henderson <richard.henderson@linaro.org>
> Fixes: f57d5f8004 ("target/riscv: deprecate the 'any' CPU type")
> Signed-off-by: Daniel Henrique Barboza <dbarboza@ventanamicro.com>
> ---
>   linux-user/riscv/target_elf.h | 3 +--
>   1 file changed, 1 insertion(+), 2 deletions(-)

Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>



^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [PATCH] linux-user/riscv: change default cpu to 'max'
  2023-10-20  7:45 [PATCH] linux-user/riscv: change default cpu to 'max' Daniel Henrique Barboza
  2023-10-20 14:08 ` Philippe Mathieu-Daudé
@ 2023-10-20 16:06 ` Richard Henderson
  2023-10-23  1:10 ` Alistair Francis
  2023-10-23  1:14 ` Alistair Francis
  3 siblings, 0 replies; 7+ messages in thread
From: Richard Henderson @ 2023-10-20 16:06 UTC (permalink / raw)
  To: Daniel Henrique Barboza, qemu-devel
  Cc: qemu-riscv, alistair.francis, bmeng, liweiwei, zhiwei_liu, palmer

On 10/20/23 00:45, Daniel Henrique Barboza wrote:
> Commit f57d5f8004 deprecated the 'any' CPU type but failed to change the
> default CPU for linux-user. The result is that all linux-users
> invocations that doesn't specify a different CPU started to show a
> deprecation warning:
> 
> $ ./build/qemu-riscv64  ./foo-novect.out
> qemu-riscv64: warning: The 'any' CPU is deprecated and will be removed in the future.
> 
> Change the default CPU for RISC-V linux-user from 'any' to 'max'.
> 
> Reported-by: Richard Henderson <richard.henderson@linaro.org>
> Fixes: f57d5f8004 ("target/riscv: deprecate the 'any' CPU type")
> Signed-off-by: Daniel Henrique Barboza <dbarboza@ventanamicro.com>

Reviewed-by: Richard Henderson <richard.henderson@linaro.org>

r~


^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [PATCH] linux-user/riscv: change default cpu to 'max'
  2023-10-20  7:45 [PATCH] linux-user/riscv: change default cpu to 'max' Daniel Henrique Barboza
  2023-10-20 14:08 ` Philippe Mathieu-Daudé
  2023-10-20 16:06 ` Richard Henderson
@ 2023-10-23  1:10 ` Alistair Francis
  2023-10-23  1:14 ` Alistair Francis
  3 siblings, 0 replies; 7+ messages in thread
From: Alistair Francis @ 2023-10-23  1:10 UTC (permalink / raw)
  To: Daniel Henrique Barboza
  Cc: qemu-devel, qemu-riscv, alistair.francis, bmeng, liweiwei,
	zhiwei_liu, palmer, Richard Henderson

On Fri, Oct 20, 2023 at 5:46 PM Daniel Henrique Barboza
<dbarboza@ventanamicro.com> wrote:
>
> Commit f57d5f8004 deprecated the 'any' CPU type but failed to change the
> default CPU for linux-user. The result is that all linux-users
> invocations that doesn't specify a different CPU started to show a
> deprecation warning:
>
> $ ./build/qemu-riscv64  ./foo-novect.out
> qemu-riscv64: warning: The 'any' CPU is deprecated and will be removed in the future.
>
> Change the default CPU for RISC-V linux-user from 'any' to 'max'.
>
> Reported-by: Richard Henderson <richard.henderson@linaro.org>
> Fixes: f57d5f8004 ("target/riscv: deprecate the 'any' CPU type")
> Signed-off-by: Daniel Henrique Barboza <dbarboza@ventanamicro.com>

Reviewed-by: Alistair Francis <alistair.francis@wdc.com>

Alistair

> ---
>  linux-user/riscv/target_elf.h | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/linux-user/riscv/target_elf.h b/linux-user/riscv/target_elf.h
> index 9dd65652ee..dedd5956f3 100644
> --- a/linux-user/riscv/target_elf.h
> +++ b/linux-user/riscv/target_elf.h
> @@ -9,7 +9,6 @@
>  #define RISCV_TARGET_ELF_H
>  static inline const char *cpu_get_model(uint32_t eflags)
>  {
> -    /* TYPE_RISCV_CPU_ANY */
> -    return "any";
> +    return "max";
>  }
>  #endif
> --
> 2.41.0
>
>


^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [PATCH] linux-user/riscv: change default cpu to 'max'
  2023-10-20  7:45 [PATCH] linux-user/riscv: change default cpu to 'max' Daniel Henrique Barboza
                   ` (2 preceding siblings ...)
  2023-10-23  1:10 ` Alistair Francis
@ 2023-10-23  1:14 ` Alistair Francis
  2023-11-03 13:43   ` Peter Maydell
  3 siblings, 1 reply; 7+ messages in thread
From: Alistair Francis @ 2023-10-23  1:14 UTC (permalink / raw)
  To: Daniel Henrique Barboza
  Cc: qemu-devel, qemu-riscv, alistair.francis, bmeng, liweiwei,
	zhiwei_liu, palmer, Richard Henderson

On Fri, Oct 20, 2023 at 5:46 PM Daniel Henrique Barboza
<dbarboza@ventanamicro.com> wrote:
>
> Commit f57d5f8004 deprecated the 'any' CPU type but failed to change the
> default CPU for linux-user. The result is that all linux-users
> invocations that doesn't specify a different CPU started to show a
> deprecation warning:
>
> $ ./build/qemu-riscv64  ./foo-novect.out
> qemu-riscv64: warning: The 'any' CPU is deprecated and will be removed in the future.
>
> Change the default CPU for RISC-V linux-user from 'any' to 'max'.
>
> Reported-by: Richard Henderson <richard.henderson@linaro.org>
> Fixes: f57d5f8004 ("target/riscv: deprecate the 'any' CPU type")
> Signed-off-by: Daniel Henrique Barboza <dbarboza@ventanamicro.com>

Thanks!

Applied to riscv-to-apply.next

Alistair

> ---
>  linux-user/riscv/target_elf.h | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/linux-user/riscv/target_elf.h b/linux-user/riscv/target_elf.h
> index 9dd65652ee..dedd5956f3 100644
> --- a/linux-user/riscv/target_elf.h
> +++ b/linux-user/riscv/target_elf.h
> @@ -9,7 +9,6 @@
>  #define RISCV_TARGET_ELF_H
>  static inline const char *cpu_get_model(uint32_t eflags)
>  {
> -    /* TYPE_RISCV_CPU_ANY */
> -    return "any";
> +    return "max";
>  }
>  #endif
> --
> 2.41.0
>
>


^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [PATCH] linux-user/riscv: change default cpu to 'max'
  2023-10-23  1:14 ` Alistair Francis
@ 2023-11-03 13:43   ` Peter Maydell
  2023-11-06  0:12     ` Alistair Francis
  0 siblings, 1 reply; 7+ messages in thread
From: Peter Maydell @ 2023-11-03 13:43 UTC (permalink / raw)
  To: Alistair Francis
  Cc: Daniel Henrique Barboza, qemu-devel, qemu-riscv, alistair.francis,
	bmeng, liweiwei, zhiwei_liu, palmer, Richard Henderson,
	Alex Bennée

On Mon, 23 Oct 2023 at 02:15, Alistair Francis <alistair23@gmail.com> wrote:
>
> On Fri, Oct 20, 2023 at 5:46 PM Daniel Henrique Barboza
> <dbarboza@ventanamicro.com> wrote:
> >
> > Commit f57d5f8004 deprecated the 'any' CPU type but failed to change the
> > default CPU for linux-user. The result is that all linux-users
> > invocations that doesn't specify a different CPU started to show a
> > deprecation warning:
> >
> > $ ./build/qemu-riscv64  ./foo-novect.out
> > qemu-riscv64: warning: The 'any' CPU is deprecated and will be removed in the future.
> >
> > Change the default CPU for RISC-V linux-user from 'any' to 'max'.
> >
> > Reported-by: Richard Henderson <richard.henderson@linaro.org>
> > Fixes: f57d5f8004 ("target/riscv: deprecate the 'any' CPU type")
> > Signed-off-by: Daniel Henrique Barboza <dbarboza@ventanamicro.com>
>
> Thanks!
>
> Applied to riscv-to-apply.next

Hi -- did this patch get lost along the way? It doesn't seem to
be upstream yet.

thanks
-- PMM


^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [PATCH] linux-user/riscv: change default cpu to 'max'
  2023-11-03 13:43   ` Peter Maydell
@ 2023-11-06  0:12     ` Alistair Francis
  0 siblings, 0 replies; 7+ messages in thread
From: Alistair Francis @ 2023-11-06  0:12 UTC (permalink / raw)
  To: Peter Maydell
  Cc: Daniel Henrique Barboza, qemu-devel, qemu-riscv, alistair.francis,
	bmeng, liweiwei, zhiwei_liu, palmer, Richard Henderson,
	Alex Bennée

On Fri, Nov 3, 2023 at 11:43 PM Peter Maydell <peter.maydell@linaro.org> wrote:
>
> On Mon, 23 Oct 2023 at 02:15, Alistair Francis <alistair23@gmail.com> wrote:
> >
> > On Fri, Oct 20, 2023 at 5:46 PM Daniel Henrique Barboza
> > <dbarboza@ventanamicro.com> wrote:
> > >
> > > Commit f57d5f8004 deprecated the 'any' CPU type but failed to change the
> > > default CPU for linux-user. The result is that all linux-users
> > > invocations that doesn't specify a different CPU started to show a
> > > deprecation warning:
> > >
> > > $ ./build/qemu-riscv64  ./foo-novect.out
> > > qemu-riscv64: warning: The 'any' CPU is deprecated and will be removed in the future.
> > >
> > > Change the default CPU for RISC-V linux-user from 'any' to 'max'.
> > >
> > > Reported-by: Richard Henderson <richard.henderson@linaro.org>
> > > Fixes: f57d5f8004 ("target/riscv: deprecate the 'any' CPU type")
> > > Signed-off-by: Daniel Henrique Barboza <dbarboza@ventanamicro.com>
> >
> > Thanks!
> >
> > Applied to riscv-to-apply.next
>
> Hi -- did this patch get lost along the way? It doesn't seem to
> be upstream yet.

It's in my tree. I expect to send a PR any day now

Alistair

>
> thanks
> -- PMM


^ permalink raw reply	[flat|nested] 7+ messages in thread

end of thread, other threads:[~2023-11-06  0:13 UTC | newest]

Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-10-20  7:45 [PATCH] linux-user/riscv: change default cpu to 'max' Daniel Henrique Barboza
2023-10-20 14:08 ` Philippe Mathieu-Daudé
2023-10-20 16:06 ` Richard Henderson
2023-10-23  1:10 ` Alistair Francis
2023-10-23  1:14 ` Alistair Francis
2023-11-03 13:43   ` Peter Maydell
2023-11-06  0:12     ` Alistair Francis

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).