Re: [PATCH v5 01/14] qcrypto/core: add generic infrastructure for crypto options amendment

[Maxim Levitsky <mlevitsk@redhat.com>]

On Thu, 2020-05-07 at 11:09 -0500, Eric Blake wrote:
> On 5/7/20 7:54 AM, Maxim Levitsky wrote:
> > This will be used first to implement luks keyslot management.
> > 
> > block_crypto_amend_opts_init will be used to convert
> > qemu-img cmdline to QCryptoBlockAmendOptions
> > 
> > Signed-off-by: Maxim Levitsky <mlevitsk@redhat.com>
> > Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
> > ---
> > +++ b/qapi/crypto.json
> > @@ -309,3 +309,19 @@
> >     'base': 'QCryptoBlockInfoBase',
> >     'discriminator': 'format',
> >     'data': { 'luks': 'QCryptoBlockInfoLUKS' } }
> > +
> > +
> > +
> > +##
> > +# @QCryptoBlockAmendOptions:
> > +#
> > +# The options that are available for all encryption formats
> > +# when amending encryption settings
> > +#
> > +# Since: 5.0
> 
> Looks like our mail crossed, my v4 review landed after you sent v5. 
> We'll still have to scrub this series for s/5.0/5.1/

Yea, I totally forgot about this :-(
I''l do this now.

Best regards,
	Maxim Levitsky

> 
> > +##
> > +{ 'union': 'QCryptoBlockAmendOptions',
> > +  'base': 'QCryptoBlockOptionsBase',
> > +  'discriminator': 'format',
> > +  'data': {
> > +            } }
> > 
> 
>