From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:49994) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bX9k1-0006EE-PH for qemu-devel@nongnu.org; Tue, 09 Aug 2016 12:18:58 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bX9jx-0000JU-I7 for qemu-devel@nongnu.org; Tue, 09 Aug 2016 12:18:56 -0400 Received: from mail-wm0-x242.google.com ([2a00:1450:400c:c09::242]:34158) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bX9jx-0000JQ-BL for qemu-devel@nongnu.org; Tue, 09 Aug 2016 12:18:53 -0400 Received: by mail-wm0-x242.google.com with SMTP id q128so4163073wma.1 for ; Tue, 09 Aug 2016 09:18:53 -0700 (PDT) Sender: Paolo Bonzini References: <1470756748-18933-1-git-send-email-berrange@redhat.com> <1470756748-18933-12-git-send-email-berrange@redhat.com> From: Paolo Bonzini Message-ID: Date: Tue, 9 Aug 2016 18:18:51 +0200 MIME-Version: 1.0 In-Reply-To: <1470756748-18933-12-git-send-email-berrange@redhat.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH for-2.8 v1 11/60] trace: remove use of event ID enums from APIs List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Daniel P. Berrange" , qemu-devel@nongnu.org Cc: Stefan Hajnoczi On 09/08/2016 17:31, Daniel P. Berrange wrote: > Since there will shortly be multiple event groups allowed, > we can no longer use the TraceEventID and TraceEventVCPUID > enums in the trace control APIs. There will in fact be > multiple distinct enums, and the enum values will only be > required to be unique per group. > > Signed-off-by: Daniel P. Berrange > --- > trace/control-internal.h | 14 +++++++------- > trace/control-target.c | 6 +++--- > trace/control.h | 25 ++++++------------------- > trace/event-internal.h | 4 ++-- > trace/simple.c | 6 +++--- > trace/simple.h | 2 +- > 6 files changed, 22 insertions(+), 35 deletions(-) > > diff --git a/trace/control-internal.h b/trace/control-internal.h > index 634effe..b7048d4 100644 > --- a/trace/control-internal.h > +++ b/trace/control-internal.h > @@ -24,13 +24,13 @@ static inline bool trace_event_is_pattern(const char *str) > return strchr(str, '*') != NULL; > } > > -static inline TraceEventID trace_event_get_id(TraceEvent *ev) > +static inline size_t trace_event_get_id(TraceEvent *ev) > { > assert(ev != NULL); > return ev->id; Perhaps "unsigned" is a better match than size_t? Paolo