From: Eric Blake <eblake@redhat.com>
To: Collin Walling <walling@linux.ibm.com>,
Markus Armbruster <armbru@redhat.com>
Cc: qemu-devel@nongnu.org, David Alan Gilbert <dgilbert@redhat.com>
Subject: Re: [Qemu-devel] [PATCH] monitor: print message when using 'help' with an unknown command
Date: Fri, 20 Jul 2018 11:40:02 -0500 [thread overview]
Message-ID: <e1051e1f-f3c8-d43d-feb7-10cc27b8edc0@redhat.com> (raw)
In-Reply-To: <2dca7714-195f-1532-a907-4e43bfd9355e@linux.ibm.com>
On 07/19/2018 11:39 AM, Collin Walling wrote:
> On 07/19/2018 12:31 PM, Markus Armbruster wrote:
>> You neglected to cc: maintainers. Cc'ing them increases the odds your
>> patch will be noticed and picked up. You can use
>> scripts/get_maintainer.pl to find maintainers. You don't have to do
>> anything for this patch; it got noticed anyway.
>>
>> David, this is yours :)
>
> Very true. Was a minor fix that I thought I'd just toss it out there and
> let anyone view it if they had the time. Will be more aware of who to CC
> next time around.
Or automate it:
https://wiki.qemu.org/Contribute/SubmitAPatch#CC_the_relevant_maintainer
suggests:
git config sendemail.cccmd 'scripts/get_maintainer.pl --nogit-fallback'
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3266
Virtualization: qemu.org | libvirt.org
next prev parent reply other threads:[~2018-07-20 16:40 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-19 15:03 [Qemu-devel] [PATCH] monitor: print message when using 'help' with an unknown command Collin Walling
2018-07-19 16:31 ` Markus Armbruster
2018-07-19 16:39 ` Collin Walling
2018-07-20 16:40 ` Eric Blake [this message]
2018-07-20 19:37 ` Collin Walling
2018-07-19 19:11 ` Dr. David Alan Gilbert
2018-07-19 19:18 ` Dr. David Alan Gilbert
2018-07-19 20:34 ` Collin Walling
2018-07-20 18:44 ` Dr. David Alan Gilbert
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e1051e1f-f3c8-d43d-feb7-10cc27b8edc0@redhat.com \
--to=eblake@redhat.com \
--cc=armbru@redhat.com \
--cc=dgilbert@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=walling@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).