From: "Cédric Le Goater" <clg@kaod.org>
To: Jamin Lin <jamin_lin@aspeedtech.com>,
Peter Maydell <peter.maydell@linaro.org>,
Steven Lee <steven_lee@aspeedtech.com>,
Troy Lee <leetroy@gmail.com>,
Andrew Jeffery <andrew@codeconstruct.com.au>,
Joel Stanley <joel@jms.id.au>,
"open list:ASPEED BMCs" <qemu-arm@nongnu.org>,
"open list:All patches CC here" <qemu-devel@nongnu.org>
Cc: troy_lee@aspeedtech.com, yunlin.tang@aspeedtech.com
Subject: Re: [PATCH v3 0/6] Support GPIO for AST2700
Date: Thu, 26 Sep 2024 18:12:35 +0200 [thread overview]
Message-ID: <e1076f8e-2e32-41ba-adf4-8e28aae8e526@kaod.org> (raw)
In-Reply-To: <20240926074535.1286209-1-jamin_lin@aspeedtech.com>
Hello Jamin,
On 9/26/24 09:45, Jamin Lin wrote:
> v1: Support GPIO for AST2700
> v2: Fix clear incorrect interrupt status and adds reviewer suggestions
> v3: remove nested conditionals and adds reviewer suggestions
>
> Jamin Lin (6):
> hw/gpio/aspeed: Fix coding style
> hw/gpio/aspeed: Support to set the different memory size
> hw/gpio/aspeed: Support different memory region ops
> hw/gpio/aspeed: Fix clear incorrect interrupt status for GPIO index
> mode
> hw/gpio/aspeed: Add AST2700 support
> aspeed/soc: Support GPIO for AST2700
>
> hw/arm/aspeed_ast27x0.c | 18 +-
> hw/gpio/aspeed_gpio.c | 427 ++++++++++++++++++++++++++++++++--
> include/hw/gpio/aspeed_gpio.h | 4 +-
> 3 files changed, 430 insertions(+), 19 deletions(-)
>
Could you please to add tests in tests/qtest/aspeed_gpio-test.c
for this changes ? At least one with the ast2700-evb machine if
possible.
Thanks,
C.
next prev parent reply other threads:[~2024-09-26 16:13 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-26 7:45 [PATCH v3 0/6] Support GPIO for AST2700 Jamin Lin via
2024-09-26 7:45 ` [PATCH v3 1/6] hw/gpio/aspeed: Fix coding style Jamin Lin via
2024-09-26 16:08 ` Cédric Le Goater
2024-09-26 7:45 ` [PATCH v3 2/6] hw/gpio/aspeed: Support to set the different memory size Jamin Lin via
2024-09-26 16:08 ` Cédric Le Goater
2024-09-26 7:45 ` [PATCH v3 3/6] hw/gpio/aspeed: Support different memory region ops Jamin Lin via
2024-09-26 16:08 ` Cédric Le Goater
2024-09-26 7:45 ` [PATCH v3 4/6] hw/gpio/aspeed: Fix clear incorrect interrupt status for GPIO index mode Jamin Lin via
2024-09-27 2:12 ` Andrew Jeffery
2024-09-27 2:15 ` Jamin Lin
2024-09-26 7:45 ` [PATCH v3 5/6] hw/gpio/aspeed: Add AST2700 support Jamin Lin via
2024-09-27 2:19 ` Andrew Jeffery
2024-09-27 3:19 ` Jamin Lin
2024-09-26 7:45 ` [PATCH v3 6/6] aspeed/soc: Support GPIO for AST2700 Jamin Lin via
2024-09-26 16:10 ` Cédric Le Goater
2024-09-27 2:17 ` Jamin Lin
2024-09-26 16:12 ` Cédric Le Goater [this message]
2024-09-27 2:16 ` [PATCH v3 0/6] " Jamin Lin
2024-09-27 6:16 ` Cédric Le Goater
2024-09-27 6:29 ` Jamin Lin
2024-09-27 12:09 ` Cédric Le Goater
2024-09-27 14:18 ` Konstantin Ryabitsev
2024-09-30 6:00 ` Jamin Lin via
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e1076f8e-2e32-41ba-adf4-8e28aae8e526@kaod.org \
--to=clg@kaod.org \
--cc=andrew@codeconstruct.com.au \
--cc=jamin_lin@aspeedtech.com \
--cc=joel@jms.id.au \
--cc=leetroy@gmail.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=steven_lee@aspeedtech.com \
--cc=troy_lee@aspeedtech.com \
--cc=yunlin.tang@aspeedtech.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).