From: Laszlo Ersek <lersek@redhat.com>
To: "Eric Blake" <eblake@redhat.com>,
"Daniel P. Berrangé" <berrange@redhat.com>
Cc: Paolo Bonzini <pbonzini@redhat.com>,
qemu-devel@nongnu.org, libvir-list@redhat.com,
Alexander Graf <agraf@suse.de>,
Ard Biesheuvel <ard.biesheuvel@linaro.org>,
David Gibson <dgibson@redhat.com>,
Gary Ching-Pang Lin <glin@suse.com>,
Gerd Hoffmann <kraxel@redhat.com>,
Kashyap Chamarthy <kchamart@redhat.com>,
Markus Armbruster <armbru@redhat.com>,
Michael Roth <mdroth@linux.vnet.ibm.com>,
Michal Privoznik <mprivozn@redhat.com>,
Peter Krempa <pkrempa@redhat.com>,
Peter Maydell <peter.maydell@linaro.org>,
Thomas Huth <thuth@redhat.com>
Subject: Re: [Qemu-devel] [qemu RFC v2] qapi: add "firmware.json"
Date: Wed, 18 Apr 2018 17:27:32 +0200 [thread overview]
Message-ID: <e11087c0-1a4c-3f01-c93f-c12657f40eae@redhat.com> (raw)
In-Reply-To: <b0d8036a-4ce0-de5c-88ac-28360658e1e2@redhat.com>
On 04/18/18 17:17, Eric Blake wrote:
> On 04/18/2018 07:40 AM, Laszlo Ersek wrote:
>
>> Is it guaranteed that lists in JSON keep the order of the elements?
>> Because, dictionaries definitely don't promise any ordering between the
>> keys.
>
> Yes, JSON lists preserve order (and we have to explicitly document cases
> where order within a list is not significant).
>
Thanks.
After digesting the comments on @type for a while longer, from Dan, Gerd
and Paolo, I think we *should* keep @type, but rather than having it be
a simple enum, let's make it a list of enums, where order matters. Keep
@features separate, and document that order does not matter there.
Here's why: my brain is crashing trying to come up with a
human-parseable explanation why for *some* entries in @features, their
relative order is important, and why for some others, it isn't.
Discerning the subset for which order matters, from any specific
grab-bag of @features, will be no fun for the human user.
Given that the "ordered features" idea was brought to life solely
because a firmware can provide multiple interfaces (with a strong
preference order between them), I guess we might as well be honest about
that, and update @type accordingly.
Thoughts? :)
Thanks,
Laszlo
next prev parent reply other threads:[~2018-04-18 15:27 UTC|newest]
Thread overview: 52+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-17 22:40 [Qemu-devel] [qemu RFC v2] qapi: add "firmware.json" Laszlo Ersek
2018-04-18 6:02 ` Gerd Hoffmann
2018-04-18 8:32 ` Laszlo Ersek
2018-04-18 9:04 ` Gerd Hoffmann
2018-04-18 11:48 ` Laszlo Ersek
2018-04-18 11:57 ` Daniel P. Berrangé
2018-04-18 12:30 ` Gerd Hoffmann
2018-04-18 12:32 ` Daniel P. Berrangé
2018-04-18 12:57 ` Laszlo Ersek
2018-04-18 12:23 ` Gerd Hoffmann
2018-04-18 12:56 ` Laszlo Ersek
2018-04-18 13:06 ` Gerd Hoffmann
2018-04-18 13:30 ` Laszlo Ersek
2018-04-18 13:53 ` Daniel P. Berrangé
2018-04-18 14:03 ` Laszlo Ersek
2018-04-18 14:06 ` Daniel P. Berrangé
2018-04-18 14:45 ` Laszlo Ersek
2018-04-19 0:09 ` David Gibson
2018-04-19 8:09 ` Laszlo Ersek
2018-04-20 1:03 ` David Gibson
2018-04-20 8:47 ` Paolo Bonzini
2018-04-20 9:01 ` Laszlo Ersek
2018-04-19 8:45 ` Thomas Huth
2018-04-18 8:47 ` Markus Armbruster
2018-04-18 11:35 ` Laszlo Ersek
2018-04-19 7:48 ` Markus Armbruster
2018-04-19 7:56 ` [Qemu-devel] [libvirt] " Daniel P. Berrangé
2018-04-19 8:39 ` Laszlo Ersek
2018-04-19 9:12 ` Daniel P. Berrangé
2018-04-20 8:11 ` Laszlo Ersek
2018-04-20 9:34 ` Daniel P. Berrangé
2018-04-20 9:46 ` Gerd Hoffmann
2018-04-20 9:50 ` Daniel P. Berrangé
2018-04-20 10:41 ` Gerd Hoffmann
2018-04-20 15:45 ` Laszlo Ersek
2018-04-20 15:39 ` Laszlo Ersek
2018-04-23 0:10 ` David Gibson
2018-04-23 9:39 ` Daniel P. Berrangé
2018-04-20 12:53 ` Markus Armbruster
2018-04-20 16:04 ` Laszlo Ersek
2018-04-20 16:37 ` Markus Armbruster
2018-04-20 23:25 ` Laszlo Ersek
2018-04-18 9:43 ` [Qemu-devel] " Paolo Bonzini
2018-04-18 11:52 ` Laszlo Ersek
2018-04-18 12:03 ` Daniel P. Berrangé
2018-04-18 12:36 ` Gerd Hoffmann
2018-04-18 12:40 ` Laszlo Ersek
2018-04-18 15:17 ` Eric Blake
2018-04-18 15:27 ` Laszlo Ersek [this message]
2018-04-18 15:28 ` Daniel P. Berrangé
2018-04-18 15:30 ` Laszlo Ersek
2018-04-19 8:57 ` Thomas Huth
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e11087c0-1a4c-3f01-c93f-c12657f40eae@redhat.com \
--to=lersek@redhat.com \
--cc=agraf@suse.de \
--cc=ard.biesheuvel@linaro.org \
--cc=armbru@redhat.com \
--cc=berrange@redhat.com \
--cc=dgibson@redhat.com \
--cc=eblake@redhat.com \
--cc=glin@suse.com \
--cc=kchamart@redhat.com \
--cc=kraxel@redhat.com \
--cc=libvir-list@redhat.com \
--cc=mdroth@linux.vnet.ibm.com \
--cc=mprivozn@redhat.com \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=pkrempa@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).