From: Thomas Huth <thuth@redhat.com>
To: Richard Henderson <richard.henderson@linaro.org>,
qemu-devel@nongnu.org, Artyom Tarasenko <atar4qemu@gmail.com>,
Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>
Cc: "Eduardo Habkost" <eduardo@habkost.net>,
"Daniel P. Berrangé" <berrange@redhat.com>,
"Paolo Bonzini" <pbonzini@redhat.com>
Subject: Re: [PATCH 1/5] target/sparc/cpu: Rename the CPU models with a "+" in their names
Date: Fri, 8 Mar 2024 06:12:50 +0100 [thread overview]
Message-ID: <e11f53d6-2e87-47eb-8ccb-aa35d2e17919@redhat.com> (raw)
In-Reply-To: <79771813-9b46-4459-b286-e9ddb4549f83@linaro.org>
On 07/03/2024 22.22, Richard Henderson wrote:
> On 3/7/24 07:43, Thomas Huth wrote:
>> + /* Fix up legacy names with '+' in it */
>> + if (g_str_equal(typename, SPARC_CPU_TYPE_NAME("Sun-UltraSparc-IV+"))) {
>> + g_free(typename);
>> + typename = g_strdup(SPARC_CPU_TYPE_NAME("Sun-UltraSparc-IVp"));
>> + } else if (g_str_equal(typename,
>> SPARC_CPU_TYPE_NAME("Sun-UltraSparc-IIIi+"))) {
>> + g_free(typename);
>> + typename = g_strdup(SPARC_CPU_TYPE_NAME("Sun-UltraSparc-IIIip"));
>> + }
>> +
>
> Legacy names don't include dashes.
This check is done after sparc_cpu_type_name() has been called, which
transforms the spaces into dashes, so we need the dashes here.
(otherwise I'd need to check for all "valid" combinations, like
"Sun-UltraSparc-IV+", "Sun UltraSparc-IV+", "Sun-UltraSparc IV+" and "Sun
UltraSparc IV+").
Thomas
next prev parent reply other threads:[~2024-03-08 5:13 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-07 17:43 [PATCH 0/5] Sparc CPU naming and help text improvements Thomas Huth
2024-03-07 17:43 ` [PATCH 1/5] target/sparc/cpu: Rename the CPU models with a "+" in their names Thomas Huth
2024-03-07 21:22 ` Richard Henderson
2024-03-08 5:12 ` Thomas Huth [this message]
2024-04-18 20:03 ` Mark Cave-Ayland
2024-03-07 17:43 ` [PATCH 2/5] target/sparc/cpu: Avoid spaces by default in the CPU names Thomas Huth
2024-03-07 21:28 ` Richard Henderson
2024-04-18 20:05 ` Mark Cave-Ayland
2024-03-07 17:43 ` [PATCH 3/5] target/sparc/cpu: Improve the CPU help text Thomas Huth
2024-03-07 18:46 ` Philippe Mathieu-Daudé
2024-03-07 21:31 ` Richard Henderson
2024-03-07 17:43 ` [PATCH 4/5] docs/system/target-sparc: Improve the Sparc documentation Thomas Huth
2024-04-18 20:27 ` Mark Cave-Ayland
2024-04-19 4:59 ` Thomas Huth
2024-04-19 5:38 ` Mark Cave-Ayland
2024-04-19 23:14 ` Brad Smith
2024-04-20 5:44 ` Mark Cave-Ayland
2024-03-07 17:43 ` [PATCH 5/5] docs/about: Deprecate the old "UltraSparc" CPU names that contain a "+" Thomas Huth
2024-04-18 20:28 ` Mark Cave-Ayland
2024-04-15 7:26 ` [PATCH 0/5] Sparc CPU naming and help text improvements Thomas Huth
2024-04-18 20:08 ` Mark Cave-Ayland
2024-04-18 20:30 ` Mark Cave-Ayland
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e11f53d6-2e87-47eb-8ccb-aa35d2e17919@redhat.com \
--to=thuth@redhat.com \
--cc=atar4qemu@gmail.com \
--cc=berrange@redhat.com \
--cc=eduardo@habkost.net \
--cc=mark.cave-ayland@ilande.co.uk \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).