From: Paolo Bonzini <pbonzini@redhat.com>
To: Jason Wang <jasowang@redhat.com>,
wangyunjian <wangyunjian@huawei.com>,
"qemu-devel@nongnu.org" <qemu-devel@nongnu.org>,
"Michael S. Tsirkin" <mst@redhat.com>
Cc: caihe <caihe@huawei.com>, "Gonglei (Arei)" <arei.gonglei@huawei.com>
Subject: Re: [Qemu-devel] [BUG] QEMU crashes with dpdk virtio pmd
Date: Thu, 27 Apr 2017 17:30:46 +0200 [thread overview]
Message-ID: <e130e60e-db1f-0355-5a7b-2ece3ae7a999@redhat.com> (raw)
In-Reply-To: <766978f5-8eae-7293-8fb4-2a7a568d301f@redhat.com>
On 25/04/2017 14:02, Jason Wang wrote:
>
> Thanks a lot for the fix.
>
> Two questions:
>
> - If virtio_net_set_status() is the only function that may access tx_bh,
> it looks like setting tx_waiting to zero is sufficient?
I think clearing tx_bh is better anyway, as leaving a dangling pointer
is not very hygienic.
Paolo
> - Can you post a formal patch for this?
next prev parent reply other threads:[~2017-04-27 15:30 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-25 11:37 [Qemu-devel] [BUG] QEMU crashes with dpdk virtio pmd wangyunjian
2017-04-25 12:02 ` Jason Wang
2017-04-27 7:01 ` Gonglei (Arei)
2017-04-27 15:30 ` Paolo Bonzini [this message]
-- strict thread matches above, loose matches on Subject: below --
2017-04-24 10:10 wangyunjian
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e130e60e-db1f-0355-5a7b-2ece3ae7a999@redhat.com \
--to=pbonzini@redhat.com \
--cc=arei.gonglei@huawei.com \
--cc=caihe@huawei.com \
--cc=jasowang@redhat.com \
--cc=mst@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=wangyunjian@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).