From: Thomas Huth <thuth@redhat.com>
To: "Richard Henderson" <richard.henderson@linaro.org>,
"Philippe Mathieu-Daudé" <philmd@linaro.org>,
"Markus Armbruster" <armbru@redhat.com>
Cc: "QEMU Developers" <qemu-devel@nongnu.org>,
"Daniel P. Berrangé" <berrange@redhat.com>,
"Paolo Bonzini" <pbonzini@redhat.com>
Subject: Re: Wshadow: Better name for 'optarg'?
Date: Wed, 4 Oct 2023 19:35:03 +0200 [thread overview]
Message-ID: <e13885b5-06a2-599f-e0fe-c5e8f0671742@redhat.com> (raw)
In-Reply-To: <d688281c-d019-c1ff-6927-d1791911c57d@linaro.org>
On 04/10/2023 19.23, Richard Henderson wrote:
> On 10/4/23 03:05, Philippe Mathieu-Daudé wrote:
>> Hi,
>>
>> I'm getting a bunch of errors for 'optarg' declared in <unistd.h>:
>
> I thought things like this is why we were trying -Wshadow=local.
>
> I think it's unlikely that we'll be able to prevent all such cases.
Given the broad range of operating systems and libraries that we support in
QEMU, I agree with Richard - it will likely be impossible to enable that
option without =local by default without risking that compilation breaks on
some exotic systems or new versions of various libraries.
Thomas
next prev parent reply other threads:[~2023-10-04 17:41 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-04 10:05 Wshadow: Better name for 'optarg'? Philippe Mathieu-Daudé
2023-10-04 10:15 ` Daniel P. Berrangé
2023-10-04 13:14 ` Warner Losh
2023-10-04 17:23 ` Richard Henderson
2023-10-04 17:35 ` Thomas Huth [this message]
2023-10-04 17:43 ` Philippe Mathieu-Daudé
2023-10-04 17:47 ` Warner Losh
2023-10-04 17:56 ` Thomas Huth
2023-10-04 18:02 ` Daniel P. Berrangé
2023-10-05 6:56 ` Philippe Mathieu-Daudé
2023-10-05 5:17 ` Markus Armbruster
2023-10-05 6:52 ` Philippe Mathieu-Daudé
2023-10-05 8:44 ` Daniel P. Berrangé
2023-10-05 8:50 ` Claudio Fontana
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e13885b5-06a2-599f-e0fe-c5e8f0671742@redhat.com \
--to=thuth@redhat.com \
--cc=armbru@redhat.com \
--cc=berrange@redhat.com \
--cc=pbonzini@redhat.com \
--cc=philmd@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).