From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:49781) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ez67I-0007f0-4j for qemu-devel@nongnu.org; Thu, 22 Mar 2018 15:43:17 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ez67G-0008VT-Tr for qemu-devel@nongnu.org; Thu, 22 Mar 2018 15:43:16 -0400 References: <1521746188-496856-1-git-send-email-mst@redhat.com> From: Eric Blake Message-ID: Date: Thu, 22 Mar 2018 14:42:55 -0500 MIME-Version: 1.0 In-Reply-To: <1521746188-496856-1-git-send-email-mst@redhat.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v2 1/2] make: move generated headers to qemu-build/ List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Michael S. Tsirkin" , qemu-devel@nongnu.org Cc: Thomas Huth , Laurent Vivier , Peter Maydell , Dmitry Fleytman , Ronnie Sahlberg , Li Zhijian , David Hildenbrand , Jeff Cody , Zhang Chen , BALATON Zoltan , Keith Busch , Max Filippov , Gerd Hoffmann , Jiri Pirko , Subbaraya Sundeep , Michael Roth , Marcelo Tosatti , Josh Durgin , Stefano Stabellini , Alberto Garcia , zhanghailiang , Ben Warren , Marcel Apfelbaum , Yongbok Kim , Markus Armbruster , Stefan Berger , Christian Borntraeger , kvm@vger.kernel.org, =?UTF-8?Q?Herv=c3=a9_Poussineau?= , Shannon Zhao , Anthony Perard , Liu Yuan , David Gibson , Andrzej Zaborowski , Jason Wang , Artyom Tarasenko , Riku Voipio , Fam Zheng , Eduardo Habkost , Corey Minyard , Amit Shah , Pavel Dovgalyuk , Stefan Weil , Xie Changlong , Alistair Francis , Peter Lieven , "Dr. David Alan Gilbert" , Greg Kurz , =?UTF-8?Q?Marc-Andr=c3=a9_Lureau?= , Alex Williamson , qemu-arm@nongnu.org, Peter Chubb , Yuval Shaia , Stefan Hajnoczi , Paolo Bonzini , xen-devel@lists.xenproject.org, John Snow , Richard Henderson , Kevin Wolf , "=?UTF-8?Q?Daniel_P._Berrang=c3=a9?=" , qemu-block@nongnu.org, Peter Crosthwaite , Hitoshi Mitake , Wen Congyang , qemu-s390x@nongnu.org, Cornelia Huck , "Richard W.M. Jones" , Juan Quintela , Max Reitz , Michael Walle , qemu-ppc@nongnu.org, =?UTF-8?Q?Andreas_F=c3=a4rber?= , Igor Mammedov , Hannes Reinecke , =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= On 03/22/2018 02:27 PM, Michael S. Tsirkin wrote: > Make sure all generated files go into qemu-build subdirectory. > We can then include them like this: > #include "qemu-build/trace.h" > > This serves two purposes: > - make it easy to detect which files are in the source > directory (a bit more work for writers, easier for readers) > - reduce chances of conflicts with possible stale files in source > directory (which could be left over from e.g. old patches, etc) > > This patch needs to be merged with patch 2 of series updating all > files: sending it separately to avoid spamming the list. > > Signed-off-by: Michael S. Tsirkin > --- > +++ b/Makefile > @@ -89,102 +89,102 @@ endif > > include $(SRC_PATH)/rules.mak > > -GENERATED_FILES = qemu-version.h config-host.h qemu-options.def > -GENERATED_FILES += qapi/qapi-builtin-types.h qapi/qapi-builtin-types.c Uggh - I really need to follow up on my threat to make smarter use of make variables and string manipulation to cut down on the boilerplate involved here. Sadly, I'm not convinced that doing so is a 2.12 bugfix priority, so it isn't at the top of my work queue. Overall, the patch is an interesting idea. I'm still not 100% sold on it (as you say, it's now slightly more work for writers), but I'm not coming up with any solid reasons why it should not be applied (at least, for 2.13 - doing it during freeze for 2.12 is a bit harder to justify). -- Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3266 Virtualization: qemu.org | libvirt.org