From: Richard Henderson <richard.henderson@linaro.org>
To: Philipp Tomsich <philipp.tomsich@vrull.eu>, qemu-devel@nongnu.org
Cc: Greg Favor <gfavor@ventanamicro.com>,
Alistair Francis <alistair.francis@wdc.com>,
Kito Cheng <kito.cheng@sifive.com>
Subject: Re: [PATCH v3 1/7] target/riscv: refactor (anonymous struct) RISCVCPU.cfg into 'struct RISCVCPUConfig'
Date: Mon, 31 Jan 2022 07:52:06 +1100 [thread overview]
Message-ID: <e152457f-5fe5-4221-5498-e1a94e8a12e5@linaro.org> (raw)
In-Reply-To: <20220128145642.1305416-2-philipp.tomsich@vrull.eu>
On 1/29/22 01:56, Philipp Tomsich wrote:
> + struct RISCVCPUConfig cfg;
Coding style says use a typedef for the struct.
Otherwise,
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
r~
next prev parent reply other threads:[~2022-01-30 20:53 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-28 14:56 [PATCH v3 0/7] target/riscv: Add XVentanaCondOps and supporting infrastructure changes Philipp Tomsich
2022-01-28 14:56 ` [PATCH v3 1/7] target/riscv: refactor (anonymous struct) RISCVCPU.cfg into 'struct RISCVCPUConfig' Philipp Tomsich
2022-01-30 20:52 ` Richard Henderson [this message]
2022-01-28 14:56 ` [PATCH v3 2/7] target/riscv: riscv_tr_init_disas_context: copy pointer-to-cfg into cfg_ptr Philipp Tomsich
2022-01-30 20:53 ` Richard Henderson
2022-01-28 14:56 ` [PATCH v3 3/7] target/riscv: access configuration through cfg_ptr in DisasContext Philipp Tomsich
2022-01-30 20:54 ` Richard Henderson
2022-01-28 14:56 ` [PATCH v3 4/7] target/riscv: access cfg structure through DisasContext Philipp Tomsich
2022-01-30 20:54 ` Richard Henderson
2022-01-28 14:56 ` [PATCH v3 5/7] target/riscv: iterate over a table of decoders Philipp Tomsich
2022-01-30 20:56 ` Richard Henderson
2022-01-28 14:56 ` [PATCH v3 6/7] target/riscv: Add XVentanaCondOps custom extension Philipp Tomsich
2022-01-30 21:06 ` Richard Henderson
2022-01-28 14:56 ` [PATCH v3 7/7] target/riscv: add a MAINTAINERS entry for XVentanaCondOps Philipp Tomsich
2022-01-30 21:06 ` Richard Henderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e152457f-5fe5-4221-5498-e1a94e8a12e5@linaro.org \
--to=richard.henderson@linaro.org \
--cc=alistair.francis@wdc.com \
--cc=gfavor@ventanamicro.com \
--cc=kito.cheng@sifive.com \
--cc=philipp.tomsich@vrull.eu \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).