From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:53749) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ebv1v-0007XW-9l for qemu-devel@nongnu.org; Wed, 17 Jan 2018 16:13:56 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ebv1u-0005Rw-C4 for qemu-devel@nongnu.org; Wed, 17 Jan 2018 16:13:55 -0500 References: <20180117193757.73471-1-borntraeger@de.ibm.com> <20180117193757.73471-4-borntraeger@de.ibm.com> From: David Hildenbrand Message-ID: Date: Wed, 17 Jan 2018 22:13:49 +0100 MIME-Version: 1.0 In-Reply-To: <20180117193757.73471-4-borntraeger@de.ibm.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v2 3/3] s390x/kvm: provide stfle.81 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Christian Borntraeger , Cornelia Huck Cc: qemu-devel , qemu-s390x , Alexander Graf , Thomas Huth , Richard Henderson , Janosch Frank , Halil Pasic On 17.01.2018 20:37, Christian Borntraeger wrote: > stfle.81 (ppa15) is a transparent facility that can be passed to the > guest without the need to implement hypervisor support. As this feature > can be provided by firmware we add it to all full models. > > Signed-off-by: Christian Borntraeger > --- > target/s390x/cpu_features.c | 1 + > target/s390x/cpu_features_def.h | 1 + > target/s390x/gen-features.c | 1 + > 3 files changed, 3 insertions(+) > > diff --git a/target/s390x/cpu_features.c b/target/s390x/cpu_features.c > index 5d1c210..1550ab0 100644 > --- a/target/s390x/cpu_features.c > +++ b/target/s390x/cpu_features.c > @@ -89,6 +89,7 @@ static const S390FeatDef s390_features[] = { > FEAT_INIT("msa4-base", S390_FEAT_TYPE_STFL, 77, "Message-security-assist-extension-4 facility (excluding subfunctions)"), > FEAT_INIT("edat2", S390_FEAT_TYPE_STFL, 78, "Enhanced-DAT facility 2"), > FEAT_INIT("dfppc", S390_FEAT_TYPE_STFL, 80, "Decimal-floating-point packed-conversion facility"), > + FEAT_INIT("ppa15", S390_FEAT_TYPE_STFL, 81, "PPA15 is installed"), > FEAT_INIT("bpb", S390_FEAT_TYPE_STFL, 82, "Branch Prediction Blocking"), > FEAT_INIT("vx", S390_FEAT_TYPE_STFL, 129, "Vector facility"), > FEAT_INIT("iep", S390_FEAT_TYPE_STFL, 130, "Instruction-execution-protection facility"), > diff --git a/target/s390x/cpu_features_def.h b/target/s390x/cpu_features_def.h > index 4487cfd..4d93087 100644 > --- a/target/s390x/cpu_features_def.h > +++ b/target/s390x/cpu_features_def.h > @@ -80,6 +80,7 @@ typedef enum { > S390_FEAT_MSA_EXT_4, > S390_FEAT_EDAT_2, > S390_FEAT_DFP_PACKED_CONVERSION, > + S390_FEAT_PPA15, > S390_FEAT_BPB, > S390_FEAT_VECTOR, > S390_FEAT_INSTRUCTION_EXEC_PROT, > diff --git a/target/s390x/gen-features.c b/target/s390x/gen-features.c > index 95ee870..50bd3f4 100644 > --- a/target/s390x/gen-features.c > +++ b/target/s390x/gen-features.c > @@ -357,6 +357,7 @@ static uint16_t full_GEN7_GA1[] = { > S390_FEAT_SIE_GPERE, > S390_FEAT_SIE_IB, > S390_FEAT_SIE_CEI, > + S390_FEAT_PPA15, > S390_FEAT_BPB, Is the order in this list still correct? Apart from that, looks nice. > }; > > -- Thanks, David / dhildenb