From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 91A74C433F5 for ; Thu, 14 Apr 2022 03:37:18 +0000 (UTC) Received: from localhost ([::1]:59040 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1neqIH-0003IX-HB for qemu-devel@archiver.kernel.org; Wed, 13 Apr 2022 23:37:17 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:46104) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1neqHW-0002d6-U2 for qemu-devel@nongnu.org; Wed, 13 Apr 2022 23:36:30 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]:29366) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1neqHU-0002vO-0E for qemu-devel@nongnu.org; Wed, 13 Apr 2022 23:36:29 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1649907387; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=4pmZ8TCpD5DaF7aDnl4uDr+JAEDtcOjsK+ulgH4yBk8=; b=fh5/YN0zmKUPuaquL1YsTzlvHwp4bAcovZcNOfT5FnUMPYTHVETigjkcGTiJK0DPoc7wuk 4L8ggkvZGGUKqbOTcuzsgUW6M1vDC+nkfFlZAsZoHaIsVndOABT2U3frVOhkgwMzfNJ7tV w2hSchsp9KR0f7Z2TZsb9y/Pd4OCXfA= Received: from mail-pf1-f199.google.com (mail-pf1-f199.google.com [209.85.210.199]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-457-kS5lnvBVOiqEyJ1cgQ-fiA-1; Wed, 13 Apr 2022 23:36:26 -0400 X-MC-Unique: kS5lnvBVOiqEyJ1cgQ-fiA-1 Received: by mail-pf1-f199.google.com with SMTP id a16-20020a62d410000000b00505734b752aso2414024pfh.4 for ; Wed, 13 Apr 2022 20:36:26 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=4pmZ8TCpD5DaF7aDnl4uDr+JAEDtcOjsK+ulgH4yBk8=; b=Vfo/MdtxdE0Dw9mjE0+LEsjSIqxzJu2jGXPnWRT+TINuNT3TCjKxySi6ycRo6Z0RvD suEhuVxH/xoOTa5J6pk/MBgJPsCDFCrz8JwVWRvtH6MEBUrNWq1nVWyr8v4I9bmyqfbP dM0qNXAv8UBTrJG1+AhFQm8IalLuy/rws/hAh6N1Be9GAYdhImYfGNH0iyUHHhg4F8sw E8RnWx3HkANCNe9WhmdmjmLgVugbwf2LOPar5npQARVBe0fpsiAvkVHtvACZMRODYTGN 7Ocw/cqBMAfX4aiaq8IDtRILDdvtK0fpyYuHDLzr5SibtYpN+Tk+rox0XUhlqCJRlWmy vJ4g== X-Gm-Message-State: AOAM5331GPApc+YWRq4pq3+4dYMEdBsx61HY39iDTuGH5NYnthkNisHx 4STC9czPvABBstXrkF/kzOwidilQqNwXjMr//pWmi9KWwudbznZuxOLHjZcqoubZtCsDJSori3O hC4wP6+ETPPxBW7A= X-Received: by 2002:a17:90a:4294:b0:1cd:5524:cd6a with SMTP id p20-20020a17090a429400b001cd5524cd6amr2097896pjg.212.1649907385465; Wed, 13 Apr 2022 20:36:25 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzs+HKObjsRm9k3P8zIHXZRdG6OJOKeegOfTxgIxgnI1PPuOaaSLEEaKwKozvPkshEOhw+GdQ== X-Received: by 2002:a17:90a:4294:b0:1cd:5524:cd6a with SMTP id p20-20020a17090a429400b001cd5524cd6amr2097866pjg.212.1649907385137; Wed, 13 Apr 2022 20:36:25 -0700 (PDT) Received: from [10.72.13.201] ([209.132.188.80]) by smtp.gmail.com with ESMTPSA id y63-20020a623242000000b00505c49bd2e9sm483159pfy.219.2022.04.13.20.36.19 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 13 Apr 2022 20:36:24 -0700 (PDT) Message-ID: Date: Thu, 14 Apr 2022 11:36:17 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.8.0 Subject: Re: [RFC PATCH v5 03/23] util: Return void on iova_tree_remove To: =?UTF-8?Q?Eugenio_P=c3=a9rez?= , qemu-devel@nongnu.org References: <20220408133415.1371760-1-eperezma@redhat.com> <20220408133415.1371760-4-eperezma@redhat.com> From: Jason Wang In-Reply-To: <20220408133415.1371760-4-eperezma@redhat.com> Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=jasowang@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=170.10.129.124; envelope-from=jasowang@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -28 X-Spam_score: -2.9 X-Spam_bar: -- X-Spam_report: (-2.9 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.082, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, NICE_REPLY_A=-0.001, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Laurent Vivier , Parav Pandit , Cindy Lu , "Michael S. Tsirkin" , Cornelia Huck , Markus Armbruster , Gautam Dawar , Harpreet Singh Anand , "Gonglei \(Arei\)" , Peter Xu , Eli Cohen , Paolo Bonzini , Zhu Lingshan , Eric Blake , Liuxiangdong Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" 在 2022/4/8 21:33, Eugenio Pérez 写道: > It always returns IOVA_OK so nobody uses it. > > Signed-off-by: Eugenio Pérez Acked-by: Jason Wang > --- > include/qemu/iova-tree.h | 4 +--- > util/iova-tree.c | 4 +--- > 2 files changed, 2 insertions(+), 6 deletions(-) > > diff --git a/include/qemu/iova-tree.h b/include/qemu/iova-tree.h > index c938fb0793..16bbfdf5f8 100644 > --- a/include/qemu/iova-tree.h > +++ b/include/qemu/iova-tree.h > @@ -72,10 +72,8 @@ int iova_tree_insert(IOVATree *tree, const DMAMap *map); > * provided. The range does not need to be exactly what has inserted, > * all the mappings that are included in the provided range will be > * removed from the tree. Here map->translated_addr is meaningless. > - * > - * Return: 0 if succeeded, or <0 if error. > */ > -int iova_tree_remove(IOVATree *tree, const DMAMap *map); > +void iova_tree_remove(IOVATree *tree, const DMAMap *map); > > /** > * iova_tree_find: > diff --git a/util/iova-tree.c b/util/iova-tree.c > index 6dff29c1f6..fee530a579 100644 > --- a/util/iova-tree.c > +++ b/util/iova-tree.c > @@ -164,15 +164,13 @@ void iova_tree_foreach(IOVATree *tree, iova_tree_iterator iterator) > g_tree_foreach(tree->tree, iova_tree_traverse, iterator); > } > > -int iova_tree_remove(IOVATree *tree, const DMAMap *map) > +void iova_tree_remove(IOVATree *tree, const DMAMap *map) > { > const DMAMap *overlap; > > while ((overlap = iova_tree_find(tree, map))) { > g_tree_remove(tree->tree, overlap); > } > - > - return IOVA_OK; > } > > /**