From: "Philippe Mathieu-Daudé" <philmd@redhat.com>
To: Yonggang Luo <luoyonggang@gmail.com>, qemu-devel@nongnu.org
Cc: Paolo Bonzini <pbonzini@redhat.com>,
Sunil Muthuswamy <sunilmut@microsoft.com>,
Ed Maste <emaste@freebsd.org>
Subject: Re: [PATCH 3/4] whpx: Fixes include of whp-dispatch.h in whpx.h
Date: Thu, 7 Jan 2021 08:22:07 +0100 [thread overview]
Message-ID: <e1746c7a-5841-d4ef-bfc4-e2d6ebe43066@redhat.com> (raw)
In-Reply-To: <20210107053825.2010-4-luoyonggang@gmail.com>
On 1/7/21 6:38 AM, Yonggang Luo wrote:
> Signed-off-by: Yonggang Luo <luoyonggang@gmail.com>
> ---
> include/sysemu/whpx.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/include/sysemu/whpx.h b/include/sysemu/whpx.h
> index 9346fd92e9..0e6c9faaf6 100644
> --- a/include/sysemu/whpx.h
> +++ b/include/sysemu/whpx.h
> @@ -15,7 +15,7 @@
>
> #ifdef CONFIG_WHPX
>
> -#include "whp-dispatch.h"
> +#include "target/i386/whpx/whp-dispatch.h"
"sysemu" should not include target/...
$ git grep target/ include/sysemu/ | wc -l
0
Maybe what you want is:
-- >8 --
diff --git a/include/sysemu/whpx.h b/include/sysemu/whpx.h
index 9346fd92e93..4f38784d7e4 100644
--- a/include/sysemu/whpx.h
+++ b/include/sysemu/whpx.h
@@ -15,7 +15,7 @@
#ifdef CONFIG_WHPX
-#include "whp-dispatch.h"
+#include <WinHvPlatformDefs.h>
struct whpx_state {
uint64_t mem_quota;
---
next prev parent reply other threads:[~2021-01-07 7:23 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-07 5:38 [PATCH 0/4] Fixes whpx build and improve Windows host CI Yonggang Luo
2021-01-07 5:38 ` [PATCH 1/4] cirrus/msys2: Exit powershell with $LastExitCode Yonggang Luo
2021-01-07 6:58 ` Philippe Mathieu-Daudé
2021-01-07 5:38 ` [PATCH 2/4] cirrus/msys2: Cache msys2 mingw in a better way Yonggang Luo
2021-01-07 5:38 ` [PATCH 3/4] whpx: Fixes include of whp-dispatch.h in whpx.h Yonggang Luo
2021-01-07 7:22 ` Philippe Mathieu-Daudé [this message]
2021-01-07 5:38 ` [PATCH 4/4] maintainers: Add me as Windows Hosted Continuous Integration maintainer Yonggang Luo
2021-01-07 7:20 ` Philippe Mathieu-Daudé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e1746c7a-5841-d4ef-bfc4-e2d6ebe43066@redhat.com \
--to=philmd@redhat.com \
--cc=emaste@freebsd.org \
--cc=luoyonggang@gmail.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=sunilmut@microsoft.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).