qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Philippe Mathieu-Daudé" <philmd@redhat.com>
To: Thomas Huth <thuth@redhat.com>,
	David Gibson <david@gibson.dropbear.id.au>,
	qemu-devel@nongnu.org
Cc: qemu-arm@nongnu.org, qemu-ppc@nongnu.org,
	John Paul Adrian Glaubitz <glaubitz@physik.fu-berlin.de>
Subject: Re: [PATCH 2/3] meson.build: Don't use internal libfdt if the user requested the system libfdt
Date: Fri, 27 Aug 2021 15:05:15 +0200	[thread overview]
Message-ID: <e19371fe-8aa2-f098-be33-1a8251f97fb2@redhat.com> (raw)
In-Reply-To: <20210827120901.150276-3-thuth@redhat.com>

On 8/27/21 2:09 PM, Thomas Huth wrote:
> If the users ran configure with --enable-libfdt=system, they likely did
> that on purpose. We should not silently fall back to the internal libfdt
> if the system libfdt is not usable, but report the problem with a proper
> message instead.
> 
> Signed-off-by: Thomas Huth <thuth@redhat.com>
> ---
>  meson.build | 2 ++
>  1 file changed, 2 insertions(+)

Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>



  reply	other threads:[~2021-08-27 13:06 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-27 12:08 [PATCH 0/3] dtc: Fixes for the fdt check and update submodule to 1.6.1 Thomas Huth
2021-08-27 12:08 ` [PATCH 1/3] meson.build: Fix the check for a usable libfdt Thomas Huth
2021-08-27 12:09 ` [PATCH 2/3] meson.build: Don't use internal libfdt if the user requested the system libfdt Thomas Huth
2021-08-27 13:05   ` Philippe Mathieu-Daudé [this message]
2021-08-27 12:09 ` [PATCH 3/3] dtc: Update to version 1.6.1 Thomas Huth
2021-09-30  7:10   ` Thomas Huth
2021-09-30 11:56     ` Greg Kurz
2021-10-01  1:42       ` David Gibson
2021-10-01  1:41     ` David Gibson
2021-10-01  9:08     ` Daniel P. Berrangé
2021-10-01  9:37       ` Peter Maydell
2021-10-01  9:44         ` Daniel P. Berrangé
2021-10-01  9:51           ` Peter Maydell
2021-10-01  9:57             ` Peter Maydell
2021-10-01 11:41           ` Thomas Huth
2021-10-02  4:35             ` David Gibson
2021-10-01 17:54           ` Brad Smith
2021-10-01 18:08             ` Brad Smith
2021-08-27 12:22 ` [PATCH 0/3] dtc: Fixes for the fdt check and update submodule to 1.6.1 Marc-André Lureau
2021-08-27 15:17 ` [PATCH 4/3] gitlab-ci: Don't try to use the system libfdt in the debian job Thomas Huth

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=e19371fe-8aa2-f098-be33-1a8251f97fb2@redhat.com \
    --to=philmd@redhat.com \
    --cc=david@gibson.dropbear.id.au \
    --cc=glaubitz@physik.fu-berlin.de \
    --cc=qemu-arm@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-ppc@nongnu.org \
    --cc=thuth@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).