From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:47009) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bYDtz-0001UP-Ri for qemu-devel@nongnu.org; Fri, 12 Aug 2016 10:57:40 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bYDtx-0007uu-Uy for qemu-devel@nongnu.org; Fri, 12 Aug 2016 10:57:38 -0400 References: <1470679640-18366-1-git-send-email-clord@redhat.com> <1470679640-18366-5-git-send-email-clord@redhat.com> <373902e2-bd93-941d-1b91-6f4f0d451dba@redhat.com> From: Max Reitz Message-ID: Date: Fri, 12 Aug 2016 14:31:03 +0200 MIME-Version: 1.0 In-Reply-To: Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="E7boLbeHraGqAF4UDTL3eCJfTKg1RHv7C" Subject: Re: [Qemu-devel] [PATCH v7 4/4] blockdev: Modularize nfs block driver List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Colin Lord , qemu-devel@nongnu.org Cc: kwolf@redhat.com, qemu-block@nongnu.org This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --E7boLbeHraGqAF4UDTL3eCJfTKg1RHv7C From: Max Reitz To: Colin Lord , qemu-devel@nongnu.org Cc: kwolf@redhat.com, qemu-block@nongnu.org Message-ID: Subject: Re: [PATCH v7 4/4] blockdev: Modularize nfs block driver References: <1470679640-18366-1-git-send-email-clord@redhat.com> <1470679640-18366-5-git-send-email-clord@redhat.com> <373902e2-bd93-941d-1b91-6f4f0d451dba@redhat.com> In-Reply-To: Content-Type: text/plain; charset=iso-8859-15 Content-Transfer-Encoding: quoted-printable On 10.08.2016 21:22, Colin Lord wrote: > On 08/10/2016 03:04 PM, Max Reitz wrote: >> On 08.08.2016 20:07, Colin Lord wrote: >>> Modularizes the nfs block driver so that it gets dynamically loaded. >>> >>> Signed-off-by: Colin Lord >>> Reviewed-by: Stefan Hajnoczi >>> --- >>> block/Makefile.objs | 1 + >>> configure | 4 ++-- >>> 2 files changed, 3 insertions(+), 2 deletions(-) >> >> I'm not quite sure what this achieves. From what I can see, the NFS >> block driver is still linked hard into qemu and it is unconditionally >> registered at qemu startup. >> > ldd seems to be telling me that libnfs is not linked to the main binary= > after this patch. >> (The output from a printf() in nfs_block_init() is visible even when >> just starting qemu-img or qemu-io without any arguments; most notably >> without bdrv_find_protocol() having been invoked at all.) >> >> Max >> > I can't seem to reproduce this. Is it possible you applied this patch > without applying the first 3 before it? Or maybe didn't have modules > enabled in the configuration? I'm so stupid. Yep, that's it. Works great now. :D Reviewed-by: Max Reitz > As far as I can tell NFS seems to buildin= g > as a module and doesn't seem to be hard linked, so I'm not really sure > what's going on. >=20 > Colin >=20 --E7boLbeHraGqAF4UDTL3eCJfTKg1RHv7C Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEvBAEBCAAZBQJXrcGHEhxtcmVpdHpAcmVkaGF0LmNvbQAKCRA7sUIC6DisrTA0 B/sGx6hQUpAsInljqbKf3qCjSoQIpwYpyKwHGO+J2TdG7/2tRWfBOV0rJ8UjnUwy 9K3iTiAU+4ThBLagxCYyACDSHF25YpFW1xsJ1GLj2ovSw1DcamF+pf8pVl2bSLDC e6NIEYfQebmPE+LP4ql1DqMCywrJsHPEWbJZkB9zP006e9v+opr9PkRi67P0UTGi U6m8HnoGOxzBl0eCdsOs/8hIG5HyoTKl457syhebgYYjLpPvkEioLhC7IV0GWgTd 81nPB4WEbeQXsAQpBD8EHtegi0HGXzwpdCfMeMPv422OZkHWkxer8hwpDHXrBQJP zqCvQn1h3ugE0Qi1Cg8p/o2G =2Y5V -----END PGP SIGNATURE----- --E7boLbeHraGqAF4UDTL3eCJfTKg1RHv7C--