From: Yang Zhang <yang.zhang.wz@gmail.com>
To: Stefan Hajnoczi <stefanha@redhat.com>, Eric Blake <eblake@redhat.com>
Cc: Junkang Fu <fujunkang@gmail.com>, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [RFC]virtio-blk: add disk-name device property
Date: Thu, 12 Jan 2017 09:22:32 +0800 [thread overview]
Message-ID: <e1a9afaf-74c0-77f1-72e9-c61cf225122e@gmail.com> (raw)
In-Reply-To: <20170104144458.GC8194@stefanha-x1.localdomain>
On 2017/1/4 22:44, Stefan Hajnoczi wrote:
> On Tue, Jan 03, 2017 at 10:53:06AM -0600, Eric Blake wrote:
>> On 12/29/2016 08:41 PM, Junkang Fu wrote:
>>> >From 74e913fc41ea98d1dde692175f1e3fb6729342aa Mon Sep 17 00:00:00 2001
>>> From: "junkang.fjk" <junkang.fjk@alibaba-inc.com>
>>> Date: Wed, 24 Aug 2016 19:36:53 +0800
>>> Subject: [PATCH] virtio-blk: add disk-name device property
>>>
>>> Current virtio-blk disk name(ex. /dev/vdb) has nothing to do with the
>>> target dev
>>> name specified in libvirt xml file. For example, we may get disk name
>>> /dev/vdb in
>>> VM while target dev specified in libvirt xml is vdc.
>>
>> It's not really libvirt's fault. The libvirt XML names are for
>> convenience, but nothing on the host side requires the guest to pick the
>> same naming scheme as the host.
>>
>> I guess your proposal is to enhance the virtio spec such that clients
>> that are new enough to honor the new addition to the virtio spec will
>> change their name-picking algorithm to use the name provided by the
>> host, rather than their current approach of picking whatever name they
>> feel like, and then enhance libvirt to pass the XML name on down to the
>> guest? It might work, but as others have pointed out, it will require a
>> virtio spec change first.
>
> This change is unnecessary. The -device virtio-blk-pci,serial= property
> already exists for this purpose.
how about the /dev/vdabc? I guess lots of people prefer to use it
instead of /dev/disk/by-id/xxx?
--
Yang
Alibaba Cloud Computing
next prev parent reply other threads:[~2017-01-12 1:22 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-30 2:41 [Qemu-devel] [RFC]virtio-blk: add disk-name device property Junkang Fu
2016-12-30 7:34 ` Cao jin
2017-01-05 7:36 ` Junkang Fu
2017-01-03 16:29 ` Stefan Hajnoczi
2017-01-05 7:35 ` Junkang Fu
2017-01-03 16:53 ` Eric Blake
2017-01-04 14:44 ` Stefan Hajnoczi
2017-01-12 1:22 ` Yang Zhang [this message]
2017-01-12 2:22 ` Fam Zheng
2017-01-12 7:39 ` Yang Zhang
2017-01-12 8:04 ` Fam Zheng
2017-01-12 14:27 ` Stefan Hajnoczi
2017-01-05 7:34 ` Junkang Fu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e1a9afaf-74c0-77f1-72e9-c61cf225122e@gmail.com \
--to=yang.zhang.wz@gmail.com \
--cc=eblake@redhat.com \
--cc=fujunkang@gmail.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).