From: Paolo Bonzini <pbonzini@redhat.com>
To: Aleksandar Markovic <amarkovic@wavecomp.com>,
"qemu-devel@nongnu.org" <qemu-devel@nongnu.org>,
"stefanha@redhat.com" <stefanha@redhat.com>
Subject: Re: [Qemu-devel] Question: Perfecting checkpatch.pl
Date: Tue, 30 Oct 2018 14:17:23 +0100 [thread overview]
Message-ID: <e1aa7445-8eb5-f63c-ad85-7ad9c25d8ac5@redhat.com> (raw)
In-Reply-To: <BN6PR2201MB1251EA1F1F5E486A889A827CC6CC0@BN6PR2201MB1251.namprd22.prod.outlook.com>
On 30/10/2018 13:35, Aleksandar Markovic wrote:
> Perhaps checkpatch.pl should make sure the commit messages do not contain "address@hidden" and "Reviewed-off-by"?
>
> $ git log | grep address@hidden
> Signed-off-by: Michael S. Tsirkin <address@hidden>
> Signed-off-by: Ronald Hecht <address@hidden>
> Signed-off-by: Justin Chevrier <address@hidden>
> Signed-off-by: Justin Chevrier <address@hidden>
> Signed-off-by: Justin Chevrier <address@hidden>
>
> $ git log | grep Reviewed-off-by
> Reviewed-off-by: Pavel Dovgalyuk <pavel.dovgaluk@ispras.ru>
> Reviewed-off-by: Anthony Liguori <aliguori@us.ibm.com>
Sure, both are good ideas. Can you write a patch for it?
Paolo
next prev parent reply other threads:[~2018-10-30 13:17 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-30 12:35 [Qemu-devel] Question: Perfecting checkpatch.pl Aleksandar Markovic
2018-10-30 13:17 ` Paolo Bonzini [this message]
2018-10-30 14:48 ` Aleksandar Markovic
2018-10-30 15:02 ` Peter Maydell
2018-10-30 13:21 ` Philippe Mathieu-Daudé
2018-10-31 12:00 ` Daniel P. Berrangé
2018-10-31 13:27 ` Peter Maydell
2018-10-31 13:33 ` Daniel P. Berrangé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e1aa7445-8eb5-f63c-ad85-7ad9c25d8ac5@redhat.com \
--to=pbonzini@redhat.com \
--cc=amarkovic@wavecomp.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).