From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.1 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6BE75C2BBCA for ; Wed, 16 Dec 2020 16:56:33 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id EA9BB233F8 for ; Wed, 16 Dec 2020 16:56:32 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org EA9BB233F8 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:50166 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kpa6J-0000hh-Td for qemu-devel@archiver.kernel.org; Wed, 16 Dec 2020 11:56:31 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:34926) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kpZmG-00048t-1w for qemu-devel@nongnu.org; Wed, 16 Dec 2020 11:35:48 -0500 Received: from mail-qt1-x829.google.com ([2607:f8b0:4864:20::829]:36024) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kpZmD-0000VQ-Ik for qemu-devel@nongnu.org; Wed, 16 Dec 2020 11:35:47 -0500 Received: by mail-qt1-x829.google.com with SMTP id z20so17628961qtq.3 for ; Wed, 16 Dec 2020 08:35:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=XshYBTWOs6WYuMm8rm7zc65jG4ltBnYLe9EyuHZMRNo=; b=CMbRlH59XWw++fk+YCUVxtN0mfKWcRBngZLWFKJhV+MRSae4OC1iQ1d9cK90NF82TN MDq6X2XPHYEMdRJptlbHl8MboBq4GvFLuA/Nx0mX+W8Ipo1n/wDaK86cOKIg8Uhec1XN XCSEaw/RQ4KhFMrhjvVYBCG4yd2/4o4p1VV+mMAvVlc0M/Aoh0HjbftxQwDbR2kIOPEP MUVdfWBReiPZFAfjVATVyU/urAGGWQwdhld5svD720s2E4YnNd5xz8dT+YEi4WHMfnZK KsEK0g1cERegmCri6/8LvJzDsFHu8IWZWfQhvF82HiyKXNfqptk2b944WKAHCsRM2f5V NMKg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=XshYBTWOs6WYuMm8rm7zc65jG4ltBnYLe9EyuHZMRNo=; b=Hnmeiaf5BFjS8ZPhnSmbj/TFCqjave826AvyTDW67V64Mn0uh4Eai1Kw5lc/bf6/5I wD6dxzUQQq7GtZm1yGc1X0fObwdHst0TvYketasIJEkTE930ymaBCZcgd4uEcLBAe5NP L9b7cauPz1JwKmJ4xfz47zvT6qqIA94s4dP+bPQdFqCVrSyL3KZG4W7uxJtLkN9LODlU sx/Zhrfzsw5jSC/YqSLzUnwY88JgleVceTzmoeE1/4L7iaspAtUaNyvNe/ehjDsYf+mC tcinxeiMAsumRvMlqceMGyViV+3sVlCNuIPgDhlK2o44o/uVXl3Yaofmq6DSNPu/wNrM OPUg== X-Gm-Message-State: AOAM533U5xKHibeCE94tUDRqZg+pQwSYwGCJR/tdS3tsP4AvtmOYOrUh VHWXVB3EEQndTniZ4bebhqzMBg== X-Google-Smtp-Source: ABdhPJzg3uUEI7FkLVN2MJmhhpmhT0KO7SPF3NyAt/mpk8oMdN6eU5gwDVWa6WpBW/nXzLRoeWOKSg== X-Received: by 2002:aed:3343:: with SMTP id u61mr37146300qtd.57.1608136544480; Wed, 16 Dec 2020 08:35:44 -0800 (PST) Received: from [192.168.71.34] ([172.58.27.195]) by smtp.gmail.com with ESMTPSA id z15sm1393912qkz.103.2020.12.16.08.35.40 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 16 Dec 2020 08:35:43 -0800 (PST) Subject: Re: [RFC v2 09/15] target/riscv: rvb: shift ones To: frank.chang@sifive.com, qemu-devel@nongnu.org, qemu-riscv@nongnu.org References: <20201216020150.3157-1-frank.chang@sifive.com> <20201216020150.3157-10-frank.chang@sifive.com> From: Richard Henderson Message-ID: Date: Wed, 16 Dec 2020 10:35:37 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20201216020150.3157-10-frank.chang@sifive.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Received-SPF: pass client-ip=2607:f8b0:4864:20::829; envelope-from=richard.henderson@linaro.org; helo=mail-qt1-x829.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, NICE_REPLY_A=-0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Bastian Koppelmann , Kito Cheng , Alistair Francis , Palmer Dabbelt , Sagar Karandikar Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 12/15/20 8:01 PM, frank.chang@sifive.com wrote: > +static bool trans_sloi(DisasContext *ctx, arg_sloi *a) > +{ > + REQUIRE_EXT(ctx, RVB); > + > + if (a->shamt >= TARGET_LONG_BITS) { > + return false; > + } As I mentioned vs the previous patch, these checks should be in gen_shifti. Otherwise, Reviewed-by: Richard Henderson r~