From: John Snow <jsnow@redhat.com>
To: "Philippe Mathieu-Daudé" <f4bug@amsat.org>,
"Markus Armbruster" <armbru@redhat.com>,
qemu-devel@nongnu.org
Cc: peter.maydell@linaro.org, "Alex Bennée" <alex.bennee@linaro.org>
Subject: Re: [PULL 00/34] QAPI patches patches for 2020-10-10
Date: Mon, 19 Oct 2020 10:34:25 -0400 [thread overview]
Message-ID: <e1c433cd-811c-67be-8a6e-57dc1b9d2ea6@redhat.com> (raw)
In-Reply-To: <7f68ee42-dce8-b304-365a-402c5b37147b@amsat.org>
On 10/18/20 3:29 AM, Philippe Mathieu-Daudé wrote:
> On 10/10/20 11:54 AM, Markus Armbruster wrote:
>> The following changes since commit
>> 4a7c0bd9dcb08798c6f82e55b5a3423f7ee669f1:
>>
>> Merge remote-tracking branch
>> 'remotes/dgibson/tags/ppc-for-5.2-20201009' into staging (2020-10-09
>> 15:48:04 +0100)
>>
>> are available in the Git repository at:
>>
>> git://repo.or.cz/qemu/armbru.git tags/pull-qapi-2020-10-10
>>
>> for you to fetch changes up to b4c0aa59aff520e2a55edd5fef393058ca6520de:
>>
>> qapi/visit.py: add type hint annotations (2020-10-10 11:37:49 +0200)
>>
>> ----------------------------------------------------------------
>> QAPI patches patches for 2020-10-10
>
> The "GCC check-tcg (user)" is 6 min slower since this pull request,
> making Travis-CI fails:
>
> https://travis-ci.org/github/qemu/qemu/builds/734773760
> https://travis-ci.org/github/qemu/qemu/builds/734983001
>
> Any remote idea what could be the reason?
>
Not even in the slightest. Is it consistently slower and you are
positive it is related to explicitly this?
Here's a run (after this PR) that's at 42.5 minutes:
https://travis-ci.org/github/qemu/qemu/builds/736183657
--js
>> ----------------------------------------------------------------
>> John Snow (34):
>> docs: repair broken references
>> qapi: modify docstrings to be sphinx-compatible
>> qapi-gen: Separate arg-parsing from generation
>> qapi: move generator entrypoint into package
>> qapi: Prefer explicit relative imports
>> qapi: Remove wildcard includes
>> qapi: enforce import order/styling with isort
>> qapi: delint using flake8
>> qapi: add pylintrc
>> qapi/common.py: Remove python compatibility workaround
>> qapi/common.py: Add indent manager
>> qapi/common.py: delint with pylint
>> qapi/common.py: Replace one-letter 'c' variable
>> qapi/common.py: check with pylint
>> qapi/common.py: add type hint annotations
>> qapi/common.py: Convert comments into docstrings, and elaborate
>> qapi/common.py: move build_params into gen.py
>> qapi: establish mypy type-checking baseline
>> qapi/events.py: add type hint annotations
>> qapi/events.py: Move comments into docstrings
>> qapi/commands.py: Don't re-bind to variable of different type
>> qapi/commands.py: add type hint annotations
>> qapi/source.py: add type hint annotations
>> qapi/source.py: delint with pylint
>> qapi/gen: Make _is_user_module() return bool
>> qapi/gen.py: add type hint annotations
>> qapi/gen.py: Remove unused parameter
>> qapi/gen.py: update write() to be more idiomatic
>> qapi/gen.py: delint with pylint
>> qapi/types.py: add type hint annotations
>> qapi/types.py: remove one-letter variables
>> qapi/visit.py: assert tag_member contains a QAPISchemaEnumType
>> qapi/visit.py: remove unused parameters from gen_visit_object
>> qapi/visit.py: add type hint annotations
>>
>> docs/devel/multi-thread-tcg.rst | 2 +-
>> docs/devel/testing.rst | 2 +-
>> scripts/qapi-gen.py | 57 +++----------
>> scripts/qapi/.flake8 | 2 +
>> scripts/qapi/.isort.cfg | 7 ++
>> scripts/qapi/commands.py | 90 ++++++++++++++------
>> scripts/qapi/common.py | 174
>> +++++++++++++++++++++-----------------
>> scripts/qapi/events.py | 58 +++++++++----
>> scripts/qapi/expr.py | 7 +-
>> scripts/qapi/gen.py | 180
>> +++++++++++++++++++++++++---------------
>> scripts/qapi/introspect.py | 16 +++-
>> scripts/qapi/main.py | 95 +++++++++++++++++++++
>> scripts/qapi/mypy.ini | 30 +++++++
>> scripts/qapi/parser.py | 6 +-
>> scripts/qapi/pylintrc | 70 ++++++++++++++++
>> scripts/qapi/schema.py | 33 ++++----
>> scripts/qapi/source.py | 35 +++++---
>> scripts/qapi/types.py | 125 +++++++++++++++++++---------
>> scripts/qapi/visit.py | 116 +++++++++++++++++++-------
>> 19 files changed, 764 insertions(+), 341 deletions(-)
>> create mode 100644 scripts/qapi/.flake8
>> create mode 100644 scripts/qapi/.isort.cfg
>> create mode 100644 scripts/qapi/main.py
>> create mode 100644 scripts/qapi/mypy.ini
>> create mode 100644 scripts/qapi/pylintrc
>>
>
prev parent reply other threads:[~2020-10-19 14:37 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-10 9:54 [PULL 00/34] QAPI patches patches for 2020-10-10 Markus Armbruster
2020-10-10 9:54 ` [PULL 01/34] docs: repair broken references Markus Armbruster
2020-10-10 9:54 ` [PULL 02/34] qapi: modify docstrings to be sphinx-compatible Markus Armbruster
2020-10-10 9:54 ` [PULL 03/34] qapi-gen: Separate arg-parsing from generation Markus Armbruster
2020-10-10 9:54 ` [PULL 04/34] qapi: move generator entrypoint into package Markus Armbruster
2020-10-10 9:54 ` [PULL 05/34] qapi: Prefer explicit relative imports Markus Armbruster
2020-10-10 9:54 ` [PULL 06/34] qapi: Remove wildcard includes Markus Armbruster
2020-10-10 9:54 ` [PULL 07/34] qapi: enforce import order/styling with isort Markus Armbruster
2020-10-10 9:54 ` [PULL 08/34] qapi: delint using flake8 Markus Armbruster
2020-10-10 9:54 ` [PULL 09/34] qapi: add pylintrc Markus Armbruster
2020-10-10 9:54 ` [PULL 10/34] qapi/common.py: Remove python compatibility workaround Markus Armbruster
2020-10-10 9:54 ` [PULL 11/34] qapi/common.py: Add indent manager Markus Armbruster
2020-10-10 9:54 ` [PULL 12/34] qapi/common.py: delint with pylint Markus Armbruster
2020-10-10 9:54 ` [PULL 13/34] qapi/common.py: Replace one-letter 'c' variable Markus Armbruster
2020-10-10 9:54 ` [PULL 14/34] qapi/common.py: check with pylint Markus Armbruster
2020-10-10 9:54 ` [PULL 15/34] qapi/common.py: add type hint annotations Markus Armbruster
2020-10-10 9:54 ` [PULL 16/34] qapi/common.py: Convert comments into docstrings, and elaborate Markus Armbruster
2020-10-10 9:54 ` [PULL 17/34] qapi/common.py: move build_params into gen.py Markus Armbruster
2020-10-10 9:54 ` [PULL 18/34] qapi: establish mypy type-checking baseline Markus Armbruster
2020-10-10 9:54 ` [PULL 19/34] qapi/events.py: add type hint annotations Markus Armbruster
2020-10-10 9:54 ` [PULL 20/34] qapi/events.py: Move comments into docstrings Markus Armbruster
2020-10-10 9:54 ` [PULL 21/34] qapi/commands.py: Don't re-bind to variable of different type Markus Armbruster
2020-10-10 9:54 ` [PULL 22/34] qapi/commands.py: add type hint annotations Markus Armbruster
2020-10-10 9:54 ` [PULL 23/34] qapi/source.py: " Markus Armbruster
2020-10-10 9:54 ` [PULL 24/34] qapi/source.py: delint with pylint Markus Armbruster
2020-10-10 9:54 ` [PULL 25/34] qapi/gen: Make _is_user_module() return bool Markus Armbruster
2020-10-10 9:54 ` [PULL 26/34] qapi/gen.py: add type hint annotations Markus Armbruster
2020-10-10 9:54 ` [PULL 27/34] qapi/gen.py: Remove unused parameter Markus Armbruster
2020-10-10 9:54 ` [PULL 28/34] qapi/gen.py: update write() to be more idiomatic Markus Armbruster
2020-10-10 9:54 ` [PULL 29/34] qapi/gen.py: delint with pylint Markus Armbruster
2020-10-10 9:55 ` [PULL 30/34] qapi/types.py: add type hint annotations Markus Armbruster
2020-10-10 9:55 ` [PULL 31/34] qapi/types.py: remove one-letter variables Markus Armbruster
2020-10-10 9:55 ` [PULL 32/34] qapi/visit.py: assert tag_member contains a QAPISchemaEnumType Markus Armbruster
2020-10-10 9:55 ` [PULL 33/34] qapi/visit.py: remove unused parameters from gen_visit_object Markus Armbruster
2020-10-10 9:55 ` [PULL 34/34] qapi/visit.py: add type hint annotations Markus Armbruster
2020-10-12 11:31 ` [PULL 00/34] QAPI patches patches for 2020-10-10 Peter Maydell
2020-10-18 7:29 ` Philippe Mathieu-Daudé
2020-10-19 8:09 ` Markus Armbruster
2020-10-19 14:34 ` John Snow [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e1c433cd-811c-67be-8a6e-57dc1b9d2ea6@redhat.com \
--to=jsnow@redhat.com \
--cc=alex.bennee@linaro.org \
--cc=armbru@redhat.com \
--cc=f4bug@amsat.org \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).