From: Eric Blake <eblake@redhat.com>
To: Markus Armbruster <armbru@redhat.com>, qemu-devel@nongnu.org
Cc: marcandre.lureau@gmail.com, mdroth@linux.vnet.ibm.com
Subject: Re: [PATCH v5 8/8] qapi: New -compat deprecated-input=crash
Date: Mon, 14 Sep 2020 10:58:55 -0500 [thread overview]
Message-ID: <e1c94dc7-b97f-4919-0210-fe3c0e19e93f@redhat.com> (raw)
In-Reply-To: <20200914084802.4185028-9-armbru@redhat.com>
On 9/14/20 3:48 AM, Markus Armbruster wrote:
> Policy "crash" calls abort() when deprecated input is received.
>
> Bugs in integration tests may mask the error from policy "reject".
> Provide a larger hammer: crash outright. Masking that seems unlikely.
>
> Signed-off-by: Markus Armbruster <armbru@redhat.com>
> ---
> +++ b/qemu-options.hx
> @@ -3392,7 +3392,7 @@ DEFHEADING()
> DEFHEADING(Debug/Expert options:)
>
> DEF("compat", HAS_ARG, QEMU_OPTION_compat,
> - "-compat [deprecated-input=accept|reject][,deprecated-output=accept|hide]\n"
> + "-compat [deprecated-input=accept|reject|crash][,deprecated-output=accept|hide]\n"
> " Policy for handling deprecated management interfaces\n",
> QEMU_ARCH_ALL)
> SRST
> @@ -3403,6 +3403,8 @@ SRST
> Accept deprecated commands and arguments
> ``deprecated-input=reject``
> Reject deprecated commands and arguments
> + ``deprecated-input=crash``
> + Crash on deprecated command
Missing 'and arguments'?
Otherwise,
Reviewed-by: Eric Blake <eblake@redhat.com>
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3226
Virtualization: qemu.org | libvirt.org
next prev parent reply other threads:[~2020-09-14 17:21 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-14 8:47 [PATCH v5 0/8] Configurable policy for handling deprecated interfaces Markus Armbruster
2020-09-14 8:47 ` [PATCH v5 1/8] qemu-options: New -compat to set policy for " Markus Armbruster
2020-09-14 11:50 ` Peter Krempa
2020-09-21 14:35 ` Markus Armbruster
2020-09-14 15:08 ` Eric Blake
2020-09-21 12:01 ` Richard W.M. Jones
2020-09-14 8:47 ` [PATCH v5 2/8] qapi: Implement deprecated-output=hide for QMP command results Markus Armbruster
2020-09-14 8:47 ` [PATCH v5 3/8] qapi: Implement deprecated-output=hide for QMP events Markus Armbruster
2020-09-14 15:19 ` Eric Blake
2020-09-14 8:47 ` [PATCH v5 4/8] qapi: Implement deprecated-output=hide for QMP event data Markus Armbruster
2020-09-14 15:35 ` Eric Blake
2020-09-14 8:47 ` [PATCH v5 5/8] qapi: Implement deprecated-output=hide for QMP introspection Markus Armbruster
2020-09-14 15:43 ` Eric Blake
2020-09-21 14:41 ` Markus Armbruster
2020-09-14 8:48 ` [PATCH v5 6/8] qapi: Implement deprecated-input=reject for QMP commands Markus Armbruster
2020-09-14 15:45 ` Eric Blake
2020-09-14 8:48 ` [PATCH v5 7/8] qapi: Implement deprecated-input=reject for QMP command arguments Markus Armbruster
2020-09-14 15:57 ` Eric Blake
2020-09-14 8:48 ` [PATCH v5 8/8] qapi: New -compat deprecated-input=crash Markus Armbruster
2020-09-14 15:58 ` Eric Blake [this message]
2020-09-21 14:42 ` Markus Armbruster
2020-09-21 12:45 ` [PATCH v5 0/8] Configurable policy for handling deprecated interfaces Richard W.M. Jones
2020-09-21 12:54 ` Peter Krempa
2020-09-21 12:58 ` Richard W.M. Jones
2020-09-21 12:56 ` Peter Maydell
2020-09-21 14:58 ` Markus Armbruster
2020-09-21 16:28 ` Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e1c94dc7-b97f-4919-0210-fe3c0e19e93f@redhat.com \
--to=eblake@redhat.com \
--cc=armbru@redhat.com \
--cc=marcandre.lureau@gmail.com \
--cc=mdroth@linux.vnet.ibm.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).