From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:40232)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mar.krzeminski@gmail.com>) id 1baSqr-0008Gh-0l
	for qemu-devel@nongnu.org; Thu, 18 Aug 2016 15:19:41 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <mar.krzeminski@gmail.com>) id 1baSqp-0001my-WA
	for qemu-devel@nongnu.org; Thu, 18 Aug 2016 15:19:40 -0400
References: <20160818140014.qhbctpmlg6umqkvm@kamzik.localdomain>
	<CAFEAcA9oAi5++H0eYiE-SyHMtLFmD5haw+d0DsN+MLo29f9U_A@mail.gmail.com>
	<20160818190421.GE2009@work-vm>
	<CAFEAcA-bnav367B38xcjZt0-TLXh68ZWB3DoJwvu2RT3qRu-Sg@mail.gmail.com>
From: "mar.krzeminski" <mar.krzeminski@gmail.com>
Message-ID: <e1d7c6a7-969e-283c-0299-10bdc83d3a88@gmail.com>
Date: Thu, 18 Aug 2016 21:19:30 +0200
MIME-Version: 1.0
In-Reply-To: <CAFEAcA-bnav367B38xcjZt0-TLXh68ZWB3DoJwvu2RT3qRu-Sg@mail.gmail.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] hw/arm/virt: vmstate-static-checker.py results
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel/>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Peter Maydell <peter.maydell@linaro.org>, "Dr. David Alan Gilbert" <dgilbert@redhat.com>
Cc: Andrew Jones <drjones@redhat.com>, Peter Crosthwaite <crosthwaite.peter@gmail.com>, "Krzeminski, Marcin (Nokia - PL/Wroclaw)" <marcin.krzeminski@nokia.com>, QEMU Developers <qemu-devel@nongnu.org>, Alistair Francis <alistair.francis@xilinx.com>, qemu-arm <qemu-arm@nongnu.org>, Amit Shah <amit.shah@redhat.com>

W dniu 18.08.2016 o 21:05, Peter Maydell pisze:

> On 18 August 2016 at 20:04, Dr. David Alan Gilbert <dgilbert@redhat.com> wrote:
>> Hmm, except there are two separate things with the name "xilinx_spi";
>>       vmstate_xilinx_spi in hw/ssi/xilinx_spi.c
>> which is the state for the "xlnx.xps-spi" (aka TYPE_XILINX_SPI) object.
>>
>> and for added confusion:
>>        vmstate_m25p80 in hw/block/m25p80.c
>> which is the state for the "m25p80-generic" (aka TYPE_M25P80) object.
>>       also calls itself "xilinx_spi".
>>
>> These went in a pair of Peter Crosthwaite commits at about the same time 4.5 years
>> ago; I'm guessing it was just a copy-paste.
>>
>> I think my preference would be to update the name for the m25p80 so it's
>> not got the clash; but it seems m25p80 contains definitions of about a zillion
>> flash devices all derived from the m25p80, so I think I'd have to try one of
>> them to see if the xilinx_spi name finds it's way onto the migration stream;
>> I suspect it doesn't.
> Aha. Yeah, we should fix that. (I have a feeling the m25p80 devices are
> all only for boards where we don't care about migration-compat, but I'm
> not completely certain.)
I had a patch to change vmstate name in m25p80,
but I do not know why I have not send it.
I also believe that there is no board that could use migration of m25p80
devs (yet?).

Regards,
Marcin

>
> thanks
> -- PMM
>
>