From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 31C95C433F5 for ; Wed, 11 May 2022 14:56:43 +0000 (UTC) Received: from localhost ([::1]:52022 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nonla-0001W9-9X for qemu-devel@archiver.kernel.org; Wed, 11 May 2022 10:56:42 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:50238) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nong2-0001X5-Ob for qemu-devel@nongnu.org; Wed, 11 May 2022 10:50:58 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:21657) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nonfx-0001vS-88 for qemu-devel@nongnu.org; Wed, 11 May 2022 10:50:55 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1652280652; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Cyei9CH2kjfhkfa3Td63WlyQQEauZm+D9P20TPW7prM=; b=MZkmZJQQS+hTS+mCQdoHwbMCRbVVPKot63vVEoCReqcBUzcgmA95zCH30hN3GDq0gtkkIF Nrm88cnpMT3aXJ7u7dLKeL7NAXDZsBZeSr3SNqkb181eKncLE9zztSNlIarrbkjcnrRX3y eESVdk6/Fv5urBRNgSR9wmXAFtKFg8s= Received: from mail-wr1-f71.google.com (mail-wr1-f71.google.com [209.85.221.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-658-lnwbT1MhNzSi72Sr7WAT5Q-1; Wed, 11 May 2022 10:50:50 -0400 X-MC-Unique: lnwbT1MhNzSi72Sr7WAT5Q-1 Received: by mail-wr1-f71.google.com with SMTP id w20-20020adfd1b4000000b0020cbb4347e6so934097wrc.17 for ; Wed, 11 May 2022 07:50:50 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent :content-language:to:cc:references:from:organization:subject :in-reply-to:content-transfer-encoding; bh=Cyei9CH2kjfhkfa3Td63WlyQQEauZm+D9P20TPW7prM=; b=sX4K0DFUVHykT1eB3ay8tGNUzrUQ0C+Aj2UHxsu08n5cQFpVUq41ZRxgr3URWDYdoZ bYBiNKTmHvdBMfGTnKhpBMN283ojUEid1pljiwONAOYpxC/P9azsHSjy/rP0WJUkTrT5 GQhjjJjqrgnJ/rdhfWu5LyJOsaFYVy8HstkikjNrewGEY8UEhTj2C1gNYRXHibR6Lf00 DctL4xu9UL5Y1uBZHCQVdQ6ojX7lFLrP4J9anoDy7cMkqI1J2s0x3Bqw2Zhz+N9yZUmU Jin1L15WtW/EdUEMzK4dTwGluSi2IzX2qxz0nGpZpzS57KYVtL9nRJdowPTcreyUaZ/l 7ttw== X-Gm-Message-State: AOAM533j7Cqq/HzNkl3aHuUT4XzcvUO2Fm6KgHUMTEPhXYxl5roOOI14 i1zC7a5ywzETToYqbKWVeVK/GI5mzRkRivxW0FNS1EPrTlfVkS9BXvXFNjXDaoTgg3tTZV3cXBy Y4un9wPAYStoriuY= X-Received: by 2002:adf:f78b:0:b0:20c:e030:7e7e with SMTP id q11-20020adff78b000000b0020ce0307e7emr1988326wrp.160.1652280649492; Wed, 11 May 2022 07:50:49 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxoKuqdKoSmCb6lp2xxV+ty81qM5FUGnjjAAyc3mseHcgsxb5gnbDzV3PNuB7BVwTwMYr651A== X-Received: by 2002:adf:f78b:0:b0:20c:e030:7e7e with SMTP id q11-20020adff78b000000b0020ce0307e7emr1988309wrp.160.1652280649273; Wed, 11 May 2022 07:50:49 -0700 (PDT) Received: from ?IPV6:2003:cb:c701:700:2393:b0f4:ef08:bd51? (p200300cbc70107002393b0f4ef08bd51.dip0.t-ipconnect.de. [2003:cb:c701:700:2393:b0f4:ef08:bd51]) by smtp.gmail.com with ESMTPSA id n20-20020a05600c4f9400b003942a244ee1sm1693639wmq.38.2022.05.11.07.50.48 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 11 May 2022 07:50:48 -0700 (PDT) Message-ID: Date: Wed, 11 May 2022 16:50:48 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.8.0 Content-Language: en-US To: =?UTF-8?B?TWljaGFsIFByw612b3puw61r?= , =?UTF-8?Q?Daniel_P=2e_Berrang=c3=a9?= Cc: qemu-devel@nongnu.org References: From: David Hildenbrand Organization: Red Hat Subject: Re: [PATCH] util: NUMA aware memory preallocation In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Received-SPF: pass client-ip=170.10.133.124; envelope-from=david@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -28 X-Spam_score: -2.9 X-Spam_bar: -- X-Spam_report: (-2.9 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.082, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, NICE_REPLY_A=-0.001, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" >> >> The very last cases is the only one where this patch can potentially >> be beneficial. The problem is that because libvirt is in charge of >> enforcing CPU affinity, IIRC, we explicitly block QEMU from doing >> anything with CPU affinity. So AFAICT, this patch should result in >> an error from sched_setaffinity when run under libvirt. > > Yes, I had to disable capability dropping in qemu.conf. > > After all, I think maybe the right place to fix this is kernel? I mean, > why don't prealloc threads converge to the nodes they are working with? Good question, I think the whole machinery doesn't support hugetlb, including recording remote faults and migrating the thread to a different node. -- Thanks, David / dhildenb