From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:59761) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1defsU-0004NT-FH for qemu-devel@nongnu.org; Mon, 07 Aug 2017 07:07:19 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1defsT-0002Vj-8Q for qemu-devel@nongnu.org; Mon, 07 Aug 2017 07:07:18 -0400 References: <20170522211205.14265-1-hpoussin@reactos.org> <20170522211205.14265-11-hpoussin@reactos.org> From: Eric Blake Message-ID: Date: Mon, 7 Aug 2017 06:07:06 -0500 MIME-Version: 1.0 In-Reply-To: Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="hNQDOLIuS15qAL3JN8WCGrUb2XXSvNcCj" Subject: Re: [Qemu-devel] [PATCH v2 10/13] vvfat: correctly generate numeric-tail of short file names List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Pranith Kumar , =?UTF-8?Q?Herv=c3=a9_Poussineau?= Cc: Kevin Wolf , qemu-devel , "open list:Block I/O path" , Max Reitz This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --hNQDOLIuS15qAL3JN8WCGrUb2XXSvNcCj From: Eric Blake To: Pranith Kumar , =?UTF-8?Q?Herv=c3=a9_Poussineau?= Cc: Kevin Wolf , qemu-devel , "open list:Block I/O path" , Max Reitz Message-ID: Subject: Re: [Qemu-devel] [PATCH v2 10/13] vvfat: correctly generate numeric-tail of short file names References: <20170522211205.14265-1-hpoussin@reactos.org> <20170522211205.14265-11-hpoussin@reactos.org> In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 08/05/2017 01:52 PM, Pranith Kumar wrote: > FYI, >=20 > This commit breaks the build with gcc-7: >=20 > CC block/vvfat.o > qemu/block/vvfat.c: In function =E2=80=98read_directory=E2=80=99: > qemu/block/vvfat.c:605:37: error: =E2=80=98__builtin___sprintf_chk=E2=80= =99 may write > a terminating nul past the end of the destination > [-Werror=3Dformat-overflow=3D] > int len =3D sprintf(tail, "~%d", i); > ^~~~~ Doesn't commit 7c8730d45f6 fix that? --=20 Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3266 Virtualization: qemu.org | libvirt.org --hNQDOLIuS15qAL3JN8WCGrUb2XXSvNcCj Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEzBAEBCAAdFiEEccLMIrHEYCkn0vOqp6FrSiUnQ2oFAlmISdoACgkQp6FrSiUn Q2pp4ggAr6nLuh6n/kdtzUChbh+cUeZFjEzFlmxRjWArYhK26Eqf4j8+7NMXLaW1 iPQ+qpkIwyDCwmD5N/czaE12+zj5fFO1o9xbcpTba+NlW0MH5BW09Qm8aCBZQN3d pgqvsBWSOxmT938yif/Obox0vuKQFhEWrsSERa+/7Jzz+YtyLugUMKU7qU1rb2lA 5Xe4ja9Dp2hqJcD5UUHCcjRJzyYBzCI5TH5N16SPEVj6oxwl4PAeTbMCN5Aj4V/g zSIhZC2NUyZVC0zEuOcrvLS1Rm3RNa6kCnrAZdo8ei4CfyyVifLpB2pgJ8REYLrJ Zw5bbfFLSyL5K3YjeWtwgQz6xSLjKw== =inzr -----END PGP SIGNATURE----- --hNQDOLIuS15qAL3JN8WCGrUb2XXSvNcCj--