From: John Snow <jsnow@redhat.com>
To: Eric Blake <eblake@redhat.com>, qemu-devel@nongnu.org
Cc: kwolf@redhat.com, vsementsov@virtuozzo.com,
Fam Zheng <famz@redhat.com>,
qemu-block@nongnu.org, Max Reitz <mreitz@redhat.com>
Subject: Re: [Qemu-devel] [PATCH v7 06/20] dirty-bitmap: Change bdrv_dirty_bitmap_size() to report bytes
Date: Wed, 13 Sep 2017 19:39:00 -0400 [thread overview]
Message-ID: <e22c68ed-b258-1159-a9eb-bf0f19e383bb@redhat.com> (raw)
In-Reply-To: <20170912203119.24166-7-eblake@redhat.com>
On 09/12/2017 04:31 PM, Eric Blake wrote:
> We're already reporting bytes for bdrv_dirty_bitmap_granularity();
> mixing bytes and sectors in our return values is a recipe for
> confusion. A later cleanup will convert dirty bitmap internals
> to be entirely byte-based, but in the meantime, we should report
> the bitmap size in bytes.
>
> The only external caller in qcow2-bitmap.c is temporarily more verbose
> (because it is still using sector-based math), but will later be
> switched to track progress by bytes instead of sectors.
>
> Signed-off-by: Eric Blake <eblake@redhat.com>
>
Reviewed-by: John Snow <jsnow@redhat.com>
next prev parent reply other threads:[~2017-09-13 23:39 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-12 20:30 [Qemu-devel] [PATCH v7 00/20] make dirty-bitmap byte-based Eric Blake
2017-09-12 20:31 ` [Qemu-devel] [PATCH v7 01/20] block: Make bdrv_img_create() size selection easier to read Eric Blake
2017-09-12 20:31 ` [Qemu-devel] [PATCH v7 02/20] hbitmap: Rename serialization_granularity to serialization_align Eric Blake
2017-09-12 20:31 ` [Qemu-devel] [PATCH v7 03/20] qcow2: Ensure bitmap serialization is aligned Eric Blake
2017-09-12 20:31 ` [Qemu-devel] [PATCH v7 04/20] dirty-bitmap: Drop unused functions Eric Blake
2017-09-12 20:31 ` [Qemu-devel] [PATCH v7 05/20] dirty-bitmap: Check for size query failure during truncate Eric Blake
2017-09-13 23:27 ` John Snow
2017-09-14 11:56 ` Eric Blake
2017-09-12 20:31 ` [Qemu-devel] [PATCH v7 06/20] dirty-bitmap: Change bdrv_dirty_bitmap_size() to report bytes Eric Blake
2017-09-13 23:39 ` John Snow [this message]
2017-09-12 20:31 ` [Qemu-devel] [PATCH v7 07/20] dirty-bitmap: Track bitmap size by bytes Eric Blake
2017-09-14 0:05 ` John Snow
2017-09-12 20:31 ` [Qemu-devel] [PATCH v7 08/20] dirty-bitmap: Change bdrv_dirty_bitmap_*serialize*() to take bytes Eric Blake
2017-09-12 20:31 ` [Qemu-devel] [PATCH v7 09/20] qcow2: Switch sectors_covered_by_bitmap_cluster() to byte-based Eric Blake
2017-09-12 20:31 ` [Qemu-devel] [PATCH v7 10/20] dirty-bitmap: Set iterator start by offset, not sector Eric Blake
2017-09-12 20:31 ` [Qemu-devel] [PATCH v7 11/20] dirty-bitmap: Change bdrv_dirty_iter_next() to report byte offset Eric Blake
2017-09-14 0:15 ` John Snow
2017-09-14 11:58 ` Eric Blake
2017-09-14 16:03 ` John Snow
2017-09-12 20:31 ` [Qemu-devel] [PATCH v7 12/20] dirty-bitmap: Change bdrv_get_dirty_count() to report bytes Eric Blake
2017-09-14 0:27 ` John Snow
2017-09-12 20:31 ` [Qemu-devel] [PATCH v7 13/20] dirty-bitmap: Change bdrv_get_dirty_locked() to take bytes Eric Blake
2017-09-12 20:31 ` [Qemu-devel] [PATCH v7 14/20] dirty-bitmap: Change bdrv_[re]set_dirty_bitmap() to use bytes Eric Blake
2017-09-12 20:31 ` [Qemu-devel] [PATCH v7 15/20] mirror: Switch mirror_dirty_init() to byte-based iteration Eric Blake
2017-09-12 20:31 ` [Qemu-devel] [PATCH v7 16/20] qcow2: Switch qcow2_measure() " Eric Blake
2017-09-12 20:31 ` [Qemu-devel] [PATCH v7 17/20] qcow2: Switch load_bitmap_data() " Eric Blake
2017-09-12 20:31 ` [Qemu-devel] [PATCH v7 18/20] qcow2: Switch store_bitmap_data() " Eric Blake
2017-09-12 20:31 ` [Qemu-devel] [PATCH v7 19/20] dirty-bitmap: Switch bdrv_set_dirty() to bytes Eric Blake
2017-09-12 20:31 ` [Qemu-devel] [PATCH v7 20/20] dirty-bitmap: Convert internal hbitmap size/granularity Eric Blake
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e22c68ed-b258-1159-a9eb-bf0f19e383bb@redhat.com \
--to=jsnow@redhat.com \
--cc=eblake@redhat.com \
--cc=famz@redhat.com \
--cc=kwolf@redhat.com \
--cc=mreitz@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=vsementsov@virtuozzo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).