From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:39375) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dsHFQ-0004Kh-Bt for qemu-devel@nongnu.org; Wed, 13 Sep 2017 19:39:13 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dsHFP-0007AN-F8 for qemu-devel@nongnu.org; Wed, 13 Sep 2017 19:39:12 -0400 References: <20170912203119.24166-1-eblake@redhat.com> <20170912203119.24166-7-eblake@redhat.com> From: John Snow Message-ID: Date: Wed, 13 Sep 2017 19:39:00 -0400 MIME-Version: 1.0 In-Reply-To: <20170912203119.24166-7-eblake@redhat.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v7 06/20] dirty-bitmap: Change bdrv_dirty_bitmap_size() to report bytes List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eric Blake , qemu-devel@nongnu.org Cc: kwolf@redhat.com, vsementsov@virtuozzo.com, Fam Zheng , qemu-block@nongnu.org, Max Reitz On 09/12/2017 04:31 PM, Eric Blake wrote: > We're already reporting bytes for bdrv_dirty_bitmap_granularity(); > mixing bytes and sectors in our return values is a recipe for > confusion. A later cleanup will convert dirty bitmap internals > to be entirely byte-based, but in the meantime, we should report > the bitmap size in bytes. > > The only external caller in qcow2-bitmap.c is temporarily more verbose > (because it is still using sector-based math), but will later be > switched to track progress by bytes instead of sectors. > > Signed-off-by: Eric Blake > Reviewed-by: John Snow