From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 8EE1BC61DA4 for ; Mon, 6 Mar 2023 13:32:51 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pZAvy-0003GI-W2; Mon, 06 Mar 2023 08:31:23 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pZAvk-0002gT-81 for qemu-devel@nongnu.org; Mon, 06 Mar 2023 08:31:19 -0500 Received: from mail-wr1-x42c.google.com ([2a00:1450:4864:20::42c]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pZAvi-0007g9-Gc for qemu-devel@nongnu.org; Mon, 06 Mar 2023 08:31:07 -0500 Received: by mail-wr1-x42c.google.com with SMTP id bw19so8785640wrb.13 for ; Mon, 06 Mar 2023 05:31:06 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1678109465; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=vznks6+vEyxs+ncVu7lf48ue72BsaQ1Tsn/VkSb1dZ8=; b=v7gNZ6EaJc+H5MtJ10i6PZjsQTmCQduLX5KMR9Gq/CnqXeKfO/FwDY0qFktxqiVf4M vmYYF4y204ru90DTM6O7DgXCeYj4EG7/ClpvZFYTVFHNX+xEqSdKu+J4b8M2JIEJ8hf0 68Kdj/Tj/lFMUs5hS3Qmr0K6yxAh98MKvqt+m80PZVVHVhESpyNvTF5149JJCykCSMFi Bdc4/9EGhwgFWQ5Rw/JeR12f2tnwHmo+5kGeX644S00CSSjg/l93RMDCPo+x3VcL/5dx V7TTEO1kNEMNSq6+1u2ohYDRLoqlUz3G8IO4ePAUNgbgIKZzwUS17R39FEFtIFy2FOiE dxeA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1678109465; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=vznks6+vEyxs+ncVu7lf48ue72BsaQ1Tsn/VkSb1dZ8=; b=YW6Z2+eAXXkrUDtqxgh5E62HespbA7Cyf0kOwTaK00vM+xTvh8AAWV3exFOtNVa6Ys nSjmqwRRwBAAuAkoPwWC8JcK54oPyY6yJUQNRJP7fBTOa68ImyVrPty0iysIlvY/vVNc IfFEm/klgDRGs8T/Z/zgKmdemPOBLZ4x2LlfhJtPcIGnKb97hfKppnEBwONjUpxQKWwT mbEQxaXr4JsGdl5fHDEYV42GrC5vqzkopSUrvP3qatIL09UqJIARQqUseiv5RwpCUxrc GSNukWsws2VfActnpksotX37wHvNCHGHZdnZd2jIWn1Bv8QYvBml+nHDJSYrjxEVHk/h vxTg== X-Gm-Message-State: AO0yUKWXojSNfSFmIYarKGhYejB3JkvSd1GctndgmjB19hqRlGwxBeLT j1ieyMz/jZSMrPeJEKmufSd9SA== X-Google-Smtp-Source: AK7set+kxYIc1BdzcP3KZnmnGYFGAKEEkzTn+NStgZCp+Tpk9uSHb7IJMwASPxyB0pvGfwoUen32iQ== X-Received: by 2002:a5d:4ec4:0:b0:2c7:169b:c576 with SMTP id s4-20020a5d4ec4000000b002c7169bc576mr7302657wrv.56.1678109465010; Mon, 06 Mar 2023 05:31:05 -0800 (PST) Received: from [192.168.30.216] ([81.0.6.76]) by smtp.gmail.com with ESMTPSA id n5-20020a5d4c45000000b002c55306f6edsm9555257wrt.54.2023.03.06.05.31.03 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 06 Mar 2023 05:31:04 -0800 (PST) Message-ID: Date: Mon, 6 Mar 2023 14:31:02 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Subject: Re: [PATCH 30/70] target/mips: Split out gen_lxl Content-Language: en-US To: Richard Henderson , qemu-devel@nongnu.org Cc: qemu-arm@nongnu.org, qemu-ppc@nongnu.org, qemu-riscv@nongnu.org, qemu-s390x@nongnu.org, jcmvbkbc@gmail.com, kbastian@mail.uni-paderborn.de, ysato@users.sourceforge.jp, gaosong@loongson.cn, jiaxun.yang@flygoat.com, tsimpson@quicinc.com, ale@rev.ng, mrolnik@gmail.com, edgar.iglesias@gmail.com References: <20230227054233.390271-1-richard.henderson@linaro.org> <20230227054233.390271-31-richard.henderson@linaro.org> From: =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= In-Reply-To: <20230227054233.390271-31-richard.henderson@linaro.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=2a00:1450:4864:20::42c; envelope-from=philmd@linaro.org; helo=mail-wr1-x42c.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, NICE_REPLY_A=-0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org On 27/2/23 06:41, Richard Henderson wrote: > Common subroutine for LDL and LWL. > Use tcg_constant_tl instead of tcg_const_tl and t2. > > Signed-off-by: Richard Henderson > --- > target/mips/tcg/translate.c | 106 ++++++++++++------------------------ > 1 file changed, 36 insertions(+), 70 deletions(-) Lovely. Reviewed-by: Philippe Mathieu-Daudé