From: "Philippe Mathieu-Daudé" <philmd@redhat.com>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: Kevin Wolf <kwolf@redhat.com>,
QEMU Developers <qemu-devel@nongnu.org>,
Qemu-block <qemu-block@nongnu.org>, Max Reitz <mreitz@redhat.com>
Subject: Re: [PULL 00/11] pflash patches for 2021-03-16
Date: Wed, 17 Mar 2021 15:22:41 +0100 [thread overview]
Message-ID: <e258527c-527d-60b8-06b5-364b8fe1e38a@redhat.com> (raw)
In-Reply-To: <CAFEAcA-p+=NGEyydhboCON+qoNcRYFp86N+7KYyDA3cMZJwsFA@mail.gmail.com>
On 3/17/21 2:37 PM, Peter Maydell wrote:
> On Mon, 15 Mar 2021 at 23:37, Philippe Mathieu-Daudé <philmd@redhat.com> wrote:
>>
>> The following changes since commit 2615a5e433aeb812c300d3a48e1a88e1303e2339:
>>
>> Merge remote-tracking branch 'remotes/stefanha-gitlab/tags/block-pull-request' into staging (2021-03-15 19:23:00 +0000)
>>
>> are available in the Git repository at:
>>
>> https://github.com/philmd/qemu.git tags/pflash-20210316
>>
>> for you to fetch changes up to 3b6a1da064ac6ce5256f1f6f16870ea79c2422d0:
>>
>> hw/block/pflash_cfi: Replace DPRINTF with trace events (2021-03-16 00:28:33 +0100)
>>
>> ----------------------------------------------------------------
>> Parallel NOR Flash patches queue
>>
>> - Code movement to ease maintainability
>> - Tracing improvements
>> ----------------------------------------------------------------
>
> Fails to build on 32-bit and OSX due to format string issues:
>
> In file included from trace/trace-hw_block.c:5:
> /Users/pm215/src/qemu-for-merges/hw/block/trace-events:36:38: error:
> format specifies type 'unsigned long' but the argument has type
> 'uint64_t' (aka 'unsigned long long') [-Werror,-Wformat]
> , name, offset, len);
> ^~~
> /Users/pm215/src/qemu-for-merges/hw/block/trace-events:33:121: error:
> format specifies type 'unsigned long' but the argument has type
> 'uint64_t' (aka 'unsigned long long') [-Werror,-Wformat]
> qemu_log("pflash_write_block_erase " "%s: block erase
> offset:0x%" PRIx64 " bytes:0x%lx" "\n", name, offset, len);
>
> ~~~ ^~~
>
> %llx
Oops. I lost access to Gitlab [*] so couldn't run the test suite.
I tried to run all of them manually but forgot the win32 cross
compilation job which usually show these problems.
[*] Which made me realize we put all your eggs in one basket.
prev parent reply other threads:[~2021-03-17 14:23 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-15 23:35 [PULL 00/11] pflash patches for 2021-03-16 Philippe Mathieu-Daudé
2021-03-15 23:35 ` [PULL 01/11] hw/block/pflash_cfi: Fix code style for checkpatch.pl Philippe Mathieu-Daudé
2021-03-15 23:35 ` [PULL 02/11] hw/block/pflash_cfi01: Extract pflash_cfi01_fill_cfi_table() Philippe Mathieu-Daudé
2021-03-15 23:35 ` [PULL 03/11] hw/block/pflash_cfi02: Extract pflash_cfi02_fill_cfi_table() Philippe Mathieu-Daudé
2021-03-15 23:35 ` [PULL 04/11] hw/block/pflash_cfi02: Set rom_mode to true in pflash_setup_mappings() Philippe Mathieu-Daudé
2021-03-15 23:35 ` [PULL 05/11] hw/block/pflash_cfi02: Open-code pflash_register_memory(rom=false) Philippe Mathieu-Daudé
2021-03-15 23:35 ` [PULL 06/11] hw/block/pflash_cfi02: Rename register_memory(true) as mode_read_array Philippe Mathieu-Daudé
2021-03-15 23:35 ` [PULL 07/11] hw/block/pflash_cfi02: Factor out pflash_reset_state_machine() Philippe Mathieu-Daudé
2021-03-15 23:35 ` [PULL 08/11] hw/block/pflash_cfi02: Add DeviceReset method Philippe Mathieu-Daudé
2021-03-15 23:35 ` [PULL 09/11] hw/block/pflash_cfi01: Clarify trace events Philippe Mathieu-Daudé
2021-03-15 23:35 ` [PULL 10/11] hw/block/pflash_cfi01: Correct the type of PFlashCFI01.ro Philippe Mathieu-Daudé
2021-03-15 23:35 ` [PULL 11/11] hw/block/pflash_cfi: Replace DPRINTF with trace events Philippe Mathieu-Daudé
2021-03-17 13:37 ` [PULL 00/11] pflash patches for 2021-03-16 Peter Maydell
2021-03-17 14:22 ` Philippe Mathieu-Daudé [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e258527c-527d-60b8-06b5-364b8fe1e38a@redhat.com \
--to=philmd@redhat.com \
--cc=kwolf@redhat.com \
--cc=mreitz@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).