From: "Philippe Mathieu-Daudé" <philmd@linaro.org>
To: Manos Pitsidianakis <manos.pitsidianakis@linaro.org>,
qemu-devel@nongnu.org
Cc: qemu-arm@nongnu.org, "Paolo Bonzini" <pbonzini@redhat.com>,
"Alex Bennée" <alex.bennee@linaro.org>,
"Stefano Stabellini" <sstabellini@kernel.org>,
"Anthony Perard" <anthony.perard@citrix.com>,
"Paul Durrant" <paul@xen.org>,
xen-devel@lists.xenproject.org
Subject: Re: [PATCH v2 5/5] hw/xen: convert stderr prints to error/warn reports
Date: Fri, 19 Jan 2024 18:04:28 +0100 [thread overview]
Message-ID: <e25f2ede-1264-4c74-bc10-df7d9f874d47@linaro.org> (raw)
In-Reply-To: <bf5504369023dc115f0d7a756c4c5254fa9cd10d.1705670342.git.manos.pitsidianakis@linaro.org>
On 19/1/24 14:24, Manos Pitsidianakis wrote:
> According to the QEMU Coding Style document:
>
>> Do not use printf(), fprintf() or monitor_printf(). Instead, use
>> error_report() or error_vreport() from error-report.h. This ensures the
>> error is reported in the right place (current monitor or stderr), and in
>> a uniform format.
>> Use error_printf() & friends to print additional information.
>
> This commit changes fprintfs that report warnings and errors to the
> appropriate report functions.
>
> Signed-off-by: Manos Pitsidianakis <manos.pitsidianakis@linaro.org>
> ---
> hw/xen/xen-hvm-common.c | 12 ++++++------
> hw/xen/xen-mapcache.c | 5 ++---
> 2 files changed, 8 insertions(+), 9 deletions(-)
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
prev parent reply other threads:[~2024-01-19 17:05 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-19 13:24 [PATCH v2 0/5] hw/{arm,xen} convert printfs to trace/reports Manos Pitsidianakis
2024-01-19 13:24 ` [PATCH v2 1/5] hw/arm/z2: convert DPRINTF to trace events and guest errors Manos Pitsidianakis
2024-01-22 18:20 ` Peter Maydell
2024-01-19 13:24 ` [PATCH v2 2/5] hw/arm/xen_arm.c: convert DPRINTF to trace events and error/warn reports Manos Pitsidianakis
2024-01-19 13:24 ` [PATCH v2 3/5] hw/xen/xen-mapcache.c: convert DPRINTF to tracepoints Manos Pitsidianakis
2024-01-19 13:24 ` [PATCH v2 4/5] hw/xen/xen-hvm-common.c: " Manos Pitsidianakis
2024-01-19 13:24 ` [PATCH v2 5/5] hw/xen: convert stderr prints to error/warn reports Manos Pitsidianakis
2024-01-19 17:04 ` Philippe Mathieu-Daudé [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e25f2ede-1264-4c74-bc10-df7d9f874d47@linaro.org \
--to=philmd@linaro.org \
--cc=alex.bennee@linaro.org \
--cc=anthony.perard@citrix.com \
--cc=manos.pitsidianakis@linaro.org \
--cc=paul@xen.org \
--cc=pbonzini@redhat.com \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=sstabellini@kernel.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).