* Re: [Qemu-devel] [PATCH] MAINTAINERS: list myself as maintainer for various Arm boards
2018-11-08 13:41 [Qemu-devel] [PATCH] MAINTAINERS: list myself as maintainer for various Arm boards Peter Maydell
@ 2018-11-08 13:49 ` Philippe Mathieu-Daudé
2018-11-08 14:43 ` Thomas Huth
` (2 subsequent siblings)
3 siblings, 0 replies; 12+ messages in thread
From: Philippe Mathieu-Daudé @ 2018-11-08 13:49 UTC (permalink / raw)
To: Peter Maydell, qemu-devel
Cc: Rob Herring, Thomas Huth, patches, Igor Mitsyanko,
Markus Armbruster, Beniamino Galvani, Jan Kiszka, Antony Pavlov
On 8/11/18 14:41, Peter Maydell wrote:
> In practice for most of the more-or-less orphan Arm board models,
> I will review patches and put them in via the target-arm tree.
> So list myself as an "Odd Fixes" status maintainer for them.
>
> This commit downgrades these boards to "Odd Fixes":
> * Allwinner-A10
> * Exynos
> * Calxeda Highbank
> * Canon DIGIC
> * Musicpal
> * nSeries
> * Palm
> * PXA2xx
>
> Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
> ---
> Thomas Huth sent a patch which only addressed collie, but
> let's be consistent.
>
> The set of downgrades to odd-fixes is based mostly on my
> subjective impression of whether anybody has made any changes
> to the board models over the last year or so, so it's quite
> possible I've forgotten that one of them is in better shape
> maintainer-activity-wise. If the maintainers for those boards
> disagree (cc'd) I'm happy to re-upgrade them to Maintained.
>
> Arguably it would be nice to have a letter prefix for "this
> is the person who will deal with getting the patch into the
> tree, but somebody else will be the primary maintainer for
> patch review" -- that's the situation for the maintained/
> active boards like ASpeed.
> ---
> MAINTAINERS | 36 +++++++++++++++++++++++++++---------
> 1 file changed, 27 insertions(+), 9 deletions(-)
>
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 0d68e4bc5eb..4443105686d 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -436,8 +436,9 @@ ARM Machines
> ------------
> Allwinner-a10
> M: Beniamino Galvani <b.galvani@gmail.com>
> +M: Peter Maydell <peter.maydell@linaro.org>
> L: qemu-arm@nongnu.org
> -S: Maintained
> +S: Odd Fixes
> F: hw/*/allwinner*
> F: include/hw/*/allwinner*
> F: hw/arm/cubieboard.c
> @@ -496,27 +497,31 @@ F: tests/test-arm-mptimer.c
>
> Exynos
> M: Igor Mitsyanko <i.mitsyanko@gmail.com>
> +M: Peter Maydell <peter.maydell@linaro.org>
> L: qemu-arm@nongnu.org
> -S: Maintained
> +S: Odd Fixes
> F: hw/*/exynos*
> F: include/hw/arm/exynos4210.h
>
> Calxeda Highbank
> M: Rob Herring <robh@kernel.org>
> +M: Peter Maydell <peter.maydell@linaro.org>
> L: qemu-arm@nongnu.org
> -S: Maintained
> +S: Odd Fixes
> F: hw/arm/highbank.c
> F: hw/net/xgmac.c
>
> Canon DIGIC
> M: Antony Pavlov <antonynpavlov@gmail.com>
> +M: Peter Maydell <peter.maydell@linaro.org>
> L: qemu-arm@nongnu.org
> -S: Maintained
> +S: Odd Fixes
> F: include/hw/arm/digic.h
> F: hw/*/digic*
>
> Gumstix
> M: Philippe Mathieu-Daudé <f4bug@amsat.org>
You can now update my tag as 'R:'.
> +M: Peter Maydell <peter.maydell@linaro.org>
> L: qemu-devel@nongnu.org
> L: qemu-arm@nongnu.org
> S: Odd Fixes
> @@ -524,8 +529,9 @@ F: hw/arm/gumstix.c
>
> i.MX31
> M: Peter Chubb <peter.chubb@nicta.com.au>
> +M: Peter Maydell <peter.maydell@linaro.org>
> L: qemu-arm@nongnu.org
> -S: Odd fixes
> +S: Odd Fixes
> F: hw/*/imx*
> F: include/hw/*/imx*
> F: hw/arm/kzm.c
> @@ -555,20 +561,23 @@ F: include/hw/misc/iotkit-sysinfo.h
>
> Musicpal
> M: Jan Kiszka <jan.kiszka@web.de>
> +M: Peter Maydell <peter.maydell@linaro.org>
> L: qemu-arm@nongnu.org
> -S: Maintained
> +S: Odd Fixes
> F: hw/arm/musicpal.c
>
> nSeries
> M: Andrzej Zaborowski <balrogg@gmail.com>
> +M: Peter Maydell <peter.maydell@linaro.org>
> L: qemu-arm@nongnu.org
> -S: Maintained
> +S: Odd Fixes
> F: hw/arm/nseries.c
>
> Palm
> M: Andrzej Zaborowski <balrogg@gmail.com>
> +M: Peter Maydell <peter.maydell@linaro.org>
> L: qemu-arm@nongnu.org
> -S: Maintained
> +S: Odd Fixes
> F: hw/arm/palm.c
>
> Real View
> @@ -582,8 +591,9 @@ F: include/hw/intc/realview_gic.h
>
> PXA2XX
> M: Andrzej Zaborowski <balrogg@gmail.com>
> +M: Peter Maydell <peter.maydell@linaro.org>
> L: qemu-arm@nongnu.org
> -S: Maintained
> +S: Odd Fixes
> F: hw/arm/mainstone.c
> F: hw/arm/spitz.c
> F: hw/arm/tosa.c
> @@ -608,6 +618,7 @@ F: hw/misc/arm_sysctl.c
> Xilinx Zynq
> M: Edgar E. Iglesias <edgar.iglesias@gmail.com>
> M: Alistair Francis <alistair@alistair23.me>
> +M: Peter Maydell <peter.maydell@linaro.org>
> L: qemu-arm@nongnu.org
> S: Maintained
> F: hw/*/xilinx_*
> @@ -619,6 +630,7 @@ X: hw/ssi/xilinx_*
> Xilinx ZynqMP
> M: Alistair Francis <alistair@alistair23.me>
> M: Edgar E. Iglesias <edgar.iglesias@gmail.com>
> +M: Peter Maydell <peter.maydell@linaro.org>
> L: qemu-arm@nongnu.org
> S: Maintained
Note: both Xilinx boards are maintained and stay maintained, this is not
strictly what the commit message says.
> F: hw/*/xlnx*.c
> @@ -632,6 +644,7 @@ F: hw/arm/virt-acpi-build.c
>
> STM32F205
> M: Alistair Francis <alistair@alistair23.me>
> +M: Peter Maydell <peter.maydell@linaro.org>
> S: Maintained
> F: hw/arm/stm32f205_soc.c
> F: hw/misc/stm32f2xx_syscfg.c
> @@ -643,11 +656,13 @@ F: include/hw/*/stm32*.h
>
> Netduino 2
> M: Alistair Francis <alistair@alistair23.me>
> +M: Peter Maydell <peter.maydell@linaro.org>
> S: Maintained
> F: hw/arm/netduino2.c
>
> SmartFusion2
> M: Subbaraya Sundeep <sundeep.lkml@gmail.com>
> +M: Peter Maydell <peter.maydell@linaro.org>
> S: Maintained
> F: hw/arm/msf2-soc.c
> F: hw/misc/msf2-sysreg.c
> @@ -660,11 +675,13 @@ F: include/hw/ssi/mss-spi.h
>
> Emcraft M2S-FG484
> M: Subbaraya Sundeep <sundeep.lkml@gmail.com>
> +M: Peter Maydell <peter.maydell@linaro.org>
> S: Maintained
> F: hw/arm/msf2-som.c
>
> ASPEED BMCs
> M: Cédric Le Goater <clg@kaod.org>
> +M: Peter Maydell <peter.maydell@linaro.org>
> R: Andrew Jeffery <andrew@aj.id.au>
> R: Joel Stanley <joel@jms.id.au>
> L: qemu-arm@nongnu.org
> @@ -676,6 +693,7 @@ F: include/hw/net/ftgmac100.h
>
> NRF51
> M: Joel Stanley <joel@jms.id.au>
> +M: Peter Maydell <peter.maydell@linaro.org>
> L: qemu-arm@nongnu.org
> S: Maintained
> F: hw/arm/nrf51_soc.c
>
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
^ permalink raw reply [flat|nested] 12+ messages in thread* Re: [Qemu-devel] [PATCH] MAINTAINERS: list myself as maintainer for various Arm boards
2018-11-08 13:41 [Qemu-devel] [PATCH] MAINTAINERS: list myself as maintainer for various Arm boards Peter Maydell
2018-11-08 13:49 ` Philippe Mathieu-Daudé
@ 2018-11-08 14:43 ` Thomas Huth
2018-11-08 14:53 ` Peter Maydell
2018-11-13 20:10 ` Alistair Francis
2018-11-19 15:27 ` Peter Maydell
3 siblings, 1 reply; 12+ messages in thread
From: Thomas Huth @ 2018-11-08 14:43 UTC (permalink / raw)
To: Peter Maydell, qemu-devel
Cc: Philippe Mathieu-Daudé, Markus Armbruster, patches,
Beniamino Galvani, Igor Mitsyanko, Rob Herring, Antony Pavlov,
Jan Kiszka, Andrzej Zaborowski
On 2018-11-08 14:41, Peter Maydell wrote:
> In practice for most of the more-or-less orphan Arm board models,
> I will review patches and put them in via the target-arm tree.
> So list myself as an "Odd Fixes" status maintainer for them.
>
> This commit downgrades these boards to "Odd Fixes":
> * Allwinner-A10
> * Exynos
> * Calxeda Highbank
> * Canon DIGIC
> * Musicpal
> * nSeries
> * Palm
> * PXA2xx
>
> Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
> ---
FWIW:
Reviewed-by: Thomas Huth <thuth@redhat.com>
While you're at it, could you maybe also add an entry for the
"mcimx6ul-evk", "mcimx7d-sabre", "raspi2", "raspi3", "sabrelite",
"vexpress-a15", "vexpress-a9" and "virt" boards? Or shall I assemble a
patch?
Thomas
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [Qemu-devel] [PATCH] MAINTAINERS: list myself as maintainer for various Arm boards
2018-11-08 14:43 ` Thomas Huth
@ 2018-11-08 14:53 ` Peter Maydell
0 siblings, 0 replies; 12+ messages in thread
From: Peter Maydell @ 2018-11-08 14:53 UTC (permalink / raw)
To: Thomas Huth
Cc: QEMU Developers, Philippe Mathieu-Daudé, Markus Armbruster,
patches@linaro.org, Beniamino Galvani, Igor Mitsyanko,
Rob Herring, Antony Pavlov, Jan Kiszka, Andrzej Zaborowski
On 8 November 2018 at 14:43, Thomas Huth <thuth@redhat.com> wrote:
> On 2018-11-08 14:41, Peter Maydell wrote:
>> In practice for most of the more-or-less orphan Arm board models,
>> I will review patches and put them in via the target-arm tree.
>> So list myself as an "Odd Fixes" status maintainer for them.
>>
>> This commit downgrades these boards to "Odd Fixes":
>> * Allwinner-A10
>> * Exynos
>> * Calxeda Highbank
>> * Canon DIGIC
>> * Musicpal
>> * nSeries
>> * Palm
>> * PXA2xx
>>
>> Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
>> ---
>
> FWIW:
> Reviewed-by: Thomas Huth <thuth@redhat.com>
>
> While you're at it, could you maybe also add an entry for the
> "mcimx6ul-evk", "mcimx7d-sabre", "raspi2", "raspi3", "sabrelite",
> "vexpress-a15", "vexpress-a9" and "virt" boards? Or shall I assemble a
> patch?
If you want to do it that would be great.
thanks
-- PMM
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [Qemu-devel] [PATCH] MAINTAINERS: list myself as maintainer for various Arm boards
2018-11-08 13:41 [Qemu-devel] [PATCH] MAINTAINERS: list myself as maintainer for various Arm boards Peter Maydell
2018-11-08 13:49 ` Philippe Mathieu-Daudé
2018-11-08 14:43 ` Thomas Huth
@ 2018-11-13 20:10 ` Alistair Francis
2018-11-14 11:12 ` Peter Maydell
2018-11-19 15:27 ` Peter Maydell
3 siblings, 1 reply; 12+ messages in thread
From: Alistair Francis @ 2018-11-13 20:10 UTC (permalink / raw)
To: Peter Maydell
Cc: qemu-devel@nongnu.org Developers, Rob Herring, Thomas Huth,
Patch Tracking, Igor Mitsyanko, Markus Armbruster,
Beniamino Galvani, Jan Kiszka, Antony Pavlov, philmd
On Thu, Nov 8, 2018 at 5:41 AM Peter Maydell <peter.maydell@linaro.org> wrote:
>
> In practice for most of the more-or-less orphan Arm board models,
> I will review patches and put them in via the target-arm tree.
> So list myself as an "Odd Fixes" status maintainer for them.
>
> This commit downgrades these boards to "Odd Fixes":
> * Allwinner-A10
> * Exynos
> * Calxeda Highbank
> * Canon DIGIC
> * Musicpal
> * nSeries
> * Palm
> * PXA2xx
>
> Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
> ---
> Thomas Huth sent a patch which only addressed collie, but
> let's be consistent.
>
> The set of downgrades to odd-fixes is based mostly on my
> subjective impression of whether anybody has made any changes
> to the board models over the last year or so, so it's quite
> possible I've forgotten that one of them is in better shape
> maintainer-activity-wise. If the maintainers for those boards
> disagree (cc'd) I'm happy to re-upgrade them to Maintained.
>
> Arguably it would be nice to have a letter prefix for "this
> is the person who will deal with getting the patch into the
> tree, but somebody else will be the primary maintainer for
> patch review" -- that's the situation for the maintained/
> active boards like ASpeed.
> ---
> MAINTAINERS | 36 +++++++++++++++++++++++++++---------
> 1 file changed, 27 insertions(+), 9 deletions(-)
>
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 0d68e4bc5eb..4443105686d 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -436,8 +436,9 @@ ARM Machines
> ------------
> Allwinner-a10
> M: Beniamino Galvani <b.galvani@gmail.com>
> +M: Peter Maydell <peter.maydell@linaro.org>
> L: qemu-arm@nongnu.org
> -S: Maintained
> +S: Odd Fixes
> F: hw/*/allwinner*
> F: include/hw/*/allwinner*
> F: hw/arm/cubieboard.c
> @@ -496,27 +497,31 @@ F: tests/test-arm-mptimer.c
>
> Exynos
> M: Igor Mitsyanko <i.mitsyanko@gmail.com>
> +M: Peter Maydell <peter.maydell@linaro.org>
> L: qemu-arm@nongnu.org
> -S: Maintained
> +S: Odd Fixes
> F: hw/*/exynos*
> F: include/hw/arm/exynos4210.h
>
> Calxeda Highbank
> M: Rob Herring <robh@kernel.org>
> +M: Peter Maydell <peter.maydell@linaro.org>
> L: qemu-arm@nongnu.org
> -S: Maintained
> +S: Odd Fixes
> F: hw/arm/highbank.c
> F: hw/net/xgmac.c
>
> Canon DIGIC
> M: Antony Pavlov <antonynpavlov@gmail.com>
> +M: Peter Maydell <peter.maydell@linaro.org>
> L: qemu-arm@nongnu.org
> -S: Maintained
> +S: Odd Fixes
> F: include/hw/arm/digic.h
> F: hw/*/digic*
>
> Gumstix
> M: Philippe Mathieu-Daudé <f4bug@amsat.org>
> +M: Peter Maydell <peter.maydell@linaro.org>
> L: qemu-devel@nongnu.org
> L: qemu-arm@nongnu.org
> S: Odd Fixes
> @@ -524,8 +529,9 @@ F: hw/arm/gumstix.c
>
> i.MX31
> M: Peter Chubb <peter.chubb@nicta.com.au>
> +M: Peter Maydell <peter.maydell@linaro.org>
> L: qemu-arm@nongnu.org
> -S: Odd fixes
> +S: Odd Fixes
> F: hw/*/imx*
> F: include/hw/*/imx*
> F: hw/arm/kzm.c
> @@ -555,20 +561,23 @@ F: include/hw/misc/iotkit-sysinfo.h
>
> Musicpal
> M: Jan Kiszka <jan.kiszka@web.de>
> +M: Peter Maydell <peter.maydell@linaro.org>
> L: qemu-arm@nongnu.org
> -S: Maintained
> +S: Odd Fixes
> F: hw/arm/musicpal.c
>
> nSeries
> M: Andrzej Zaborowski <balrogg@gmail.com>
> +M: Peter Maydell <peter.maydell@linaro.org>
> L: qemu-arm@nongnu.org
> -S: Maintained
> +S: Odd Fixes
> F: hw/arm/nseries.c
>
> Palm
> M: Andrzej Zaborowski <balrogg@gmail.com>
> +M: Peter Maydell <peter.maydell@linaro.org>
> L: qemu-arm@nongnu.org
> -S: Maintained
> +S: Odd Fixes
> F: hw/arm/palm.c
>
> Real View
> @@ -582,8 +591,9 @@ F: include/hw/intc/realview_gic.h
>
> PXA2XX
> M: Andrzej Zaborowski <balrogg@gmail.com>
> +M: Peter Maydell <peter.maydell@linaro.org>
> L: qemu-arm@nongnu.org
> -S: Maintained
> +S: Odd Fixes
> F: hw/arm/mainstone.c
> F: hw/arm/spitz.c
> F: hw/arm/tosa.c
> @@ -608,6 +618,7 @@ F: hw/misc/arm_sysctl.c
> Xilinx Zynq
> M: Edgar E. Iglesias <edgar.iglesias@gmail.com>
> M: Alistair Francis <alistair@alistair23.me>
> +M: Peter Maydell <peter.maydell@linaro.org>
> L: qemu-arm@nongnu.org
> S: Maintained
> F: hw/*/xilinx_*
> @@ -619,6 +630,7 @@ X: hw/ssi/xilinx_*
> Xilinx ZynqMP
> M: Alistair Francis <alistair@alistair23.me>
> M: Edgar E. Iglesias <edgar.iglesias@gmail.com>
> +M: Peter Maydell <peter.maydell@linaro.org>
> L: qemu-arm@nongnu.org
> S: Maintained
> F: hw/*/xlnx*.c
> @@ -632,6 +644,7 @@ F: hw/arm/virt-acpi-build.c
>
> STM32F205
> M: Alistair Francis <alistair@alistair23.me>
> +M: Peter Maydell <peter.maydell@linaro.org>
> S: Maintained
> F: hw/arm/stm32f205_soc.c
> F: hw/misc/stm32f2xx_syscfg.c
> @@ -643,11 +656,13 @@ F: include/hw/*/stm32*.h
>
> Netduino 2
> M: Alistair Francis <alistair@alistair23.me>
> +M: Peter Maydell <peter.maydell@linaro.org>
> S: Maintained
> F: hw/arm/netduino2.c
These two and the Xilinx boards seem a little out of place in this
patch. I agree they probably aren't maintained as well as they should
be, but the patch talks about orphaned boards and these four all have
active QEMU maintainers listed.
Alistair
>
> SmartFusion2
> M: Subbaraya Sundeep <sundeep.lkml@gmail.com>
> +M: Peter Maydell <peter.maydell@linaro.org>
> S: Maintained
> F: hw/arm/msf2-soc.c
> F: hw/misc/msf2-sysreg.c
> @@ -660,11 +675,13 @@ F: include/hw/ssi/mss-spi.h
>
> Emcraft M2S-FG484
> M: Subbaraya Sundeep <sundeep.lkml@gmail.com>
> +M: Peter Maydell <peter.maydell@linaro.org>
> S: Maintained
> F: hw/arm/msf2-som.c
>
> ASPEED BMCs
> M: Cédric Le Goater <clg@kaod.org>
> +M: Peter Maydell <peter.maydell@linaro.org>
> R: Andrew Jeffery <andrew@aj.id.au>
> R: Joel Stanley <joel@jms.id.au>
> L: qemu-arm@nongnu.org
> @@ -676,6 +693,7 @@ F: include/hw/net/ftgmac100.h
>
> NRF51
> M: Joel Stanley <joel@jms.id.au>
> +M: Peter Maydell <peter.maydell@linaro.org>
> L: qemu-arm@nongnu.org
> S: Maintained
> F: hw/arm/nrf51_soc.c
> --
> 2.19.1
>
>
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [Qemu-devel] [PATCH] MAINTAINERS: list myself as maintainer for various Arm boards
2018-11-13 20:10 ` Alistair Francis
@ 2018-11-14 11:12 ` Peter Maydell
2018-11-14 11:23 ` Philippe Mathieu-Daudé
2018-11-14 18:14 ` Alistair Francis
0 siblings, 2 replies; 12+ messages in thread
From: Peter Maydell @ 2018-11-14 11:12 UTC (permalink / raw)
To: Alistair Francis
Cc: qemu-devel@nongnu.org Developers, Rob Herring, Thomas Huth,
Patch Tracking, Igor Mitsyanko, Markus Armbruster,
Beniamino Galvani, Jan Kiszka, Antony Pavlov,
Philippe Mathieu-Daudé
On 13 November 2018 at 20:10, Alistair Francis <alistair23@gmail.com> wrote:
> These two and the Xilinx boards seem a little out of place in this
> patch. I agree they probably aren't maintained as well as they should
> be, but the patch talks about orphaned boards and these four all have
> active QEMU maintainers listed.
Yeah, I was planning to improve the commit message,
something along the lines of an extra para:
"The Xilinx boards are maintained, but patches to
them go via the target-arm tree, so add myself as a
maintainer there too."
Really this is because we're overloading "maintainer"
to mean both "this person cares about and is the
primary reviewer and yes/no decision for them" and
also "this person is responsible for getting the
patches into the tree". Perhaps we should instead
define a new letter tag for the latter ?
thanks
-- PMM
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [Qemu-devel] [PATCH] MAINTAINERS: list myself as maintainer for various Arm boards
2018-11-14 11:12 ` Peter Maydell
@ 2018-11-14 11:23 ` Philippe Mathieu-Daudé
2018-11-14 11:25 ` Peter Maydell
2018-11-14 18:14 ` Alistair Francis
1 sibling, 1 reply; 12+ messages in thread
From: Philippe Mathieu-Daudé @ 2018-11-14 11:23 UTC (permalink / raw)
To: Peter Maydell
Cc: alistair23, QEMU Developers, Rob Herring, Thomas Huth, patches,
Igor Mitsyanko, Markus Armbruster, Beniamino Galvani, Jan Kiszka,
Antony Pavlov
On Wed, Nov 14, 2018 at 12:13 PM Peter Maydell <peter.maydell@linaro.org> wrote:
> On 13 November 2018 at 20:10, Alistair Francis <alistair23@gmail.com> wrote:
> > These two and the Xilinx boards seem a little out of place in this
> > patch. I agree they probably aren't maintained as well as they should
> > be, but the patch talks about orphaned boards and these four all have
> > active QEMU maintainers listed.
>
> Yeah, I was planning to improve the commit message,
> something along the lines of an extra para:
>
> "The Xilinx boards are maintained, but patches to
> them go via the target-arm tree, so add myself as a
> maintainer there too."
>
> Really this is because we're overloading "maintainer"
> to mean both "this person cares about and is the
> primary reviewer and yes/no decision for them" and
> also "this person is responsible for getting the
> patches into the tree". Perhaps we should instead
> define a new letter tag for the latter ?
What about changing the 'M:' tag description to the one you just suggested?
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [Qemu-devel] [PATCH] MAINTAINERS: list myself as maintainer for various Arm boards
2018-11-14 11:23 ` Philippe Mathieu-Daudé
@ 2018-11-14 11:25 ` Peter Maydell
0 siblings, 0 replies; 12+ messages in thread
From: Peter Maydell @ 2018-11-14 11:25 UTC (permalink / raw)
To: Philippe Mathieu-Daudé
Cc: Alistair Francis, QEMU Developers, Rob Herring, Thomas Huth,
patches@linaro.org, Igor Mitsyanko, Markus Armbruster,
Beniamino Galvani, Jan Kiszka, Antony Pavlov
On 14 November 2018 at 11:23, Philippe Mathieu-Daudé <philmd@redhat.com> wrote:
> On Wed, Nov 14, 2018 at 12:13 PM Peter Maydell <peter.maydell@linaro.org> wrote:
>> On 13 November 2018 at 20:10, Alistair Francis <alistair23@gmail.com> wrote:
>> > These two and the Xilinx boards seem a little out of place in this
>> > patch. I agree they probably aren't maintained as well as they should
>> > be, but the patch talks about orphaned boards and these four all have
>> > active QEMU maintainers listed.
>>
>> Yeah, I was planning to improve the commit message,
>> something along the lines of an extra para:
>>
>> "The Xilinx boards are maintained, but patches to
>> them go via the target-arm tree, so add myself as a
>> maintainer there too."
>>
>> Really this is because we're overloading "maintainer"
>> to mean both "this person cares about and is the
>> primary reviewer and yes/no decision for them" and
>> also "this person is responsible for getting the
>> patches into the tree". Perhaps we should instead
>> define a new letter tag for the latter ?
>
> What about changing the 'M:' tag description to the one you just suggested?
That would leave us without a tag for "this person is
the maintainer, they just don't deal with submitting
pull requests"...
thanks
-- PMM
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [Qemu-devel] [PATCH] MAINTAINERS: list myself as maintainer for various Arm boards
2018-11-14 11:12 ` Peter Maydell
2018-11-14 11:23 ` Philippe Mathieu-Daudé
@ 2018-11-14 18:14 ` Alistair Francis
2018-11-15 9:51 ` Alex Bennée
1 sibling, 1 reply; 12+ messages in thread
From: Alistair Francis @ 2018-11-14 18:14 UTC (permalink / raw)
To: Peter Maydell
Cc: qemu-devel@nongnu.org Developers, Rob Herring, Thomas Huth,
Patch Tracking, Igor Mitsyanko, Markus Armbruster,
Beniamino Galvani, Jan Kiszka, Antony Pavlov,
Philippe Mathieu-Daudé
On 14/11/2018 3:12 am, Peter Maydell wrote:
> On 13 November 2018 at 20:10, Alistair Francis <alistair23@gmail.com> wrote:
>> These two and the Xilinx boards seem a little out of place in this
>> patch. I agree they probably aren't maintained as well as they should
>> be, but the patch talks about orphaned boards and these four all have
>> active QEMU maintainers listed.
>
> Yeah, I was planning to improve the commit message,
> something along the lines of an extra para:
>
> "The Xilinx boards are maintained, but patches to
> them go via the target-arm tree, so add myself as a
> maintainer there too."
>
> Really this is because we're overloading "maintainer"
> to mean both "this person cares about and is the
> primary reviewer and yes/no decision for them" and
> also "this person is responsible for getting the
> patches into the tree". Perhaps we should instead
> define a new letter tag for the latter ?
What about adding a "P:" tag for pull request sender?
Alistair
>
> thanks
> -- PMM
>
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [Qemu-devel] [PATCH] MAINTAINERS: list myself as maintainer for various Arm boards
2018-11-14 18:14 ` Alistair Francis
@ 2018-11-15 9:51 ` Alex Bennée
2018-11-15 9:55 ` Peter Maydell
0 siblings, 1 reply; 12+ messages in thread
From: Alex Bennée @ 2018-11-15 9:51 UTC (permalink / raw)
To: qemu-devel
Cc: Peter Maydell, Rob Herring, Thomas Huth, Patch Tracking,
Igor Mitsyanko, Markus Armbruster, Beniamino Galvani, Jan Kiszka,
Antony Pavlov, Philippe Mathieu-Daudé
Alistair Francis <alistair23@gmail.com> writes:
> On 14/11/2018 3:12 am, Peter Maydell wrote:
>> On 13 November 2018 at 20:10, Alistair Francis <alistair23@gmail.com> wrote:
>>> These two and the Xilinx boards seem a little out of place in this
>>> patch. I agree they probably aren't maintained as well as they should
>>> be, but the patch talks about orphaned boards and these four all have
>>> active QEMU maintainers listed.
>>
>> Yeah, I was planning to improve the commit message,
>> something along the lines of an extra para:
>>
>> "The Xilinx boards are maintained, but patches to
>> them go via the target-arm tree, so add myself as a
>> maintainer there too."
>>
>> Really this is because we're overloading "maintainer"
>> to mean both "this person cares about and is the
>> primary reviewer and yes/no decision for them" and
>> also "this person is responsible for getting the
>> patches into the tree". Perhaps we should instead
>> define a new letter tag for the latter ?
>
> What about adding a "P:" tag for pull request sender?
Don't all pull requests generally come from the relevant T: (tree)? We
could either extend that or just state the first M: in the list is the
person who owns the relevant tree.
>
> Alistair
>
>>
>> thanks
>> -- PMM
>>
--
Alex Bennée
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [Qemu-devel] [PATCH] MAINTAINERS: list myself as maintainer for various Arm boards
2018-11-15 9:51 ` Alex Bennée
@ 2018-11-15 9:55 ` Peter Maydell
0 siblings, 0 replies; 12+ messages in thread
From: Peter Maydell @ 2018-11-15 9:55 UTC (permalink / raw)
To: Alex Bennée
Cc: QEMU Developers, Rob Herring, Thomas Huth, Patch Tracking,
Igor Mitsyanko, Markus Armbruster, Beniamino Galvani, Jan Kiszka,
Antony Pavlov, Philippe Mathieu-Daudé
On 15 November 2018 at 09:51, Alex Bennée <alex.bennee@linaro.org> wrote:
>
> Alistair Francis <alistair23@gmail.com> writes:
>
>> On 14/11/2018 3:12 am, Peter Maydell wrote:
>>> On 13 November 2018 at 20:10, Alistair Francis <alistair23@gmail.com> wrote:
>>>> These two and the Xilinx boards seem a little out of place in this
>>>> patch. I agree they probably aren't maintained as well as they should
>>>> be, but the patch talks about orphaned boards and these four all have
>>>> active QEMU maintainers listed.
>>>
>>> Yeah, I was planning to improve the commit message,
>>> something along the lines of an extra para:
>>>
>>> "The Xilinx boards are maintained, but patches to
>>> them go via the target-arm tree, so add myself as a
>>> maintainer there too."
>>>
>>> Really this is because we're overloading "maintainer"
>>> to mean both "this person cares about and is the
>>> primary reviewer and yes/no decision for them" and
>>> also "this person is responsible for getting the
>>> patches into the tree". Perhaps we should instead
>>> define a new letter tag for the latter ?
>>
>> What about adding a "P:" tag for pull request sender?
>
> Don't all pull requests generally come from the relevant T: (tree)?
What relevant tree? There isn't a T: tag for the target-arm
tree (it would not be of much use to quote a git url for
it in MAINTAINERS because I don't expect people to base
work on top of it or indeed generally push it publicly
until I'm doing a pull request from it). Also, a git URL
is not an email that can be cc'd on a patch submission
or ping...
> could either extend that or just state the first M: in the list is the
> person who owns the relevant tree.
I think the first M: should be the actual maintainer of
the code, personally.
thanks
-- PMM
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [Qemu-devel] [PATCH] MAINTAINERS: list myself as maintainer for various Arm boards
2018-11-08 13:41 [Qemu-devel] [PATCH] MAINTAINERS: list myself as maintainer for various Arm boards Peter Maydell
` (2 preceding siblings ...)
2018-11-13 20:10 ` Alistair Francis
@ 2018-11-19 15:27 ` Peter Maydell
3 siblings, 0 replies; 12+ messages in thread
From: Peter Maydell @ 2018-11-19 15:27 UTC (permalink / raw)
To: QEMU Developers
Cc: Rob Herring, Thomas Huth, patches@linaro.org, Igor Mitsyanko,
Markus Armbruster, Beniamino Galvani, Jan Kiszka, Antony Pavlov,
Philippe Mathieu-Daudé
On 8 November 2018 at 13:41, Peter Maydell <peter.maydell@linaro.org> wrote:
> In practice for most of the more-or-less orphan Arm board models,
> I will review patches and put them in via the target-arm tree.
> So list myself as an "Odd Fixes" status maintainer for them.
>
> This commit downgrades these boards to "Odd Fixes":
> * Allwinner-A10
> * Exynos
> * Calxeda Highbank
> * Canon DIGIC
> * Musicpal
> * nSeries
> * Palm
> * PXA2xx
>
> Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
> ---
Applied to target-arm.next for 3.1, with Philippe moved to
"R:" status from "M:" for Gumstix, and the following improved
commit message:
MAINTAINERS: list myself as maintainer for various Arm boards
In practice for most of the more-or-less orphan Arm board models,
I will review patches and put them in via the target-arm tree.
So list myself as an "Odd Fixes" status maintainer for them.
This commit downgrades these boards to "Odd Fixes":
* Allwinner-A10
* Exynos
* Calxeda Highbank
* Canon DIGIC
* Musicpal
* nSeries
* Palm
* PXA2xx
These boards were already "Odd Fixes":
* Gumstix
* i.MX31 (kzm)
Philippe Mathieu-Daudé has requested to be moved to R:
status for Gumstix now that I am listed as the M: contact.
Some boards are maintained, but their patches still go
via the target-arm tree, so add myself as a secondary
maintainer contact for those:
* Xilinx Zynq
* Xilinx ZynqMP
* STM32F205
* Netduino 2
* SmartFusion2
* Mecraft M2S-FG484
* ASPEED BMCs
* NRF51
(We can think about the "tag for who to cc to get patches
into a pull request" idea separately I think.)
thanks
-- PMM
^ permalink raw reply [flat|nested] 12+ messages in thread