qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Eric Blake <eblake@redhat.com>
To: "Daniel P. Berrange" <berrange@redhat.com>, qemu-devel@nongnu.org
Cc: qemu-block@nongnu.org, Max Reitz <mreitz@redhat.com>,
	Kevin Wolf <kwolf@redhat.com>, Alberto Garcia <berto@igalia.com>
Subject: Re: [Qemu-devel] [PATCH v8 19/20] qcow2: report encryption specific image information
Date: Thu, 1 Jun 2017 13:08:57 -0500	[thread overview]
Message-ID: <e26777b2-1d57-d179-28e1-12b0f988e111@redhat.com> (raw)
In-Reply-To: <20170601172734.9039-20-berrange@redhat.com>

[-- Attachment #1: Type: text/plain, Size: 715 bytes --]

On 06/01/2017 12:27 PM, Daniel P. Berrange wrote:
> Currently 'qemu-img info' reports a simple "encrypted: yes"
> field. This is not very useful now that qcow2 can support
> multiple encryption formats. Users want to know which format
> is in use and some data related to it.
> 

> 
> Signed-off-by: Daniel P. Berrange <berrange@redhat.com>
> ---
>  block/qcow2.c        | 32 +++++++++++++++++++++++++++++++-
>  qapi/block-core.json | 27 ++++++++++++++++++++++++++-
>  2 files changed, 57 insertions(+), 2 deletions(-)
> 

Reviewed-by: Eric Blake <eblake@redhat.com>

-- 
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3266
Virtualization:  qemu.org | libvirt.org


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]

  reply	other threads:[~2017-06-01 18:09 UTC|newest]

Thread overview: 33+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-06-01 17:27 [Qemu-devel] [PATCH v8 00/20] Convert QCow[2] to QCryptoBlock & add LUKS support Daniel P. Berrange
2017-06-01 17:27 ` [Qemu-devel] [PATCH v8 01/20] block: expose crypto option names / defs to other drivers Daniel P. Berrange
2017-06-01 17:27 ` [Qemu-devel] [PATCH v8 02/20] block: add ability to set a prefix for opt names Daniel P. Berrange
2017-06-01 17:27 ` [Qemu-devel] [PATCH v8 03/20] qcow: document another weakness of qcow AES encryption Daniel P. Berrange
2017-06-01 17:27 ` [Qemu-devel] [PATCH v8 04/20] qcow: require image size to be > 1 for new images Daniel P. Berrange
2017-06-01 17:27 ` [Qemu-devel] [PATCH v8 05/20] iotests: skip 042 with qcow which dosn't support zero sized images Daniel P. Berrange
2017-06-01 17:27 ` [Qemu-devel] [PATCH v8 06/20] iotests: skip 048 with qcow which doesn't support resize Daniel P. Berrange
2017-06-01 17:27 ` [Qemu-devel] [PATCH v8 07/20] block: deprecate "encryption=on" in favor of "encrypt.format=aes" Daniel P. Berrange
2017-06-07 16:40   ` Max Reitz
2017-06-19 13:56     ` Daniel P. Berrange
2017-06-01 17:27 ` [Qemu-devel] [PATCH v8 08/20] qcow: make encrypt_sectors encrypt in place Daniel P. Berrange
2017-06-01 17:27 ` [Qemu-devel] [PATCH v8 09/20] qcow: convert QCow to use QCryptoBlock for encryption Daniel P. Berrange
2017-06-07 16:55   ` Max Reitz
2017-06-19 13:58     ` Daniel P. Berrange
2017-06-01 17:27 ` [Qemu-devel] [PATCH v8 10/20] qcow2: make qcow2_encrypt_sectors encrypt in place Daniel P. Berrange
2017-06-01 17:27 ` [Qemu-devel] [PATCH v8 11/20] qcow2: convert QCow2 to use QCryptoBlock for encryption Daniel P. Berrange
2017-06-01 17:27 ` [Qemu-devel] [PATCH v8 12/20] qcow2: extend specification to cover LUKS encryption Daniel P. Berrange
2017-06-01 18:04   ` Eric Blake
2017-06-01 17:27 ` [Qemu-devel] [PATCH v8 13/20] qcow2: add support for LUKS encryption format Daniel P. Berrange
2017-06-07 17:19   ` Max Reitz
2017-06-19 14:00     ` Daniel P. Berrange
2017-06-01 17:27 ` [Qemu-devel] [PATCH v8 14/20] qcow2: add iotests to cover LUKS encryption support Daniel P. Berrange
2017-06-01 17:27 ` [Qemu-devel] [PATCH v8 15/20] iotests: enable tests 134 and 158 to work with qcow (v1) Daniel P. Berrange
2017-06-01 17:27 ` [Qemu-devel] [PATCH v8 16/20] block: rip out all traces of password prompting Daniel P. Berrange
2017-06-01 17:27 ` [Qemu-devel] [PATCH v8 17/20] block: remove all encryption handling APIs Daniel P. Berrange
2017-06-01 17:27 ` [Qemu-devel] [PATCH v8 18/20] block: pass option prefix down to crypto layer Daniel P. Berrange
2017-06-01 17:27 ` [Qemu-devel] [PATCH v8 19/20] qcow2: report encryption specific image information Daniel P. Berrange
2017-06-01 18:08   ` Eric Blake [this message]
2017-06-02  8:32   ` Alberto Garcia
2017-06-07 17:38   ` Max Reitz
2017-06-19 14:08     ` Daniel P. Berrange
2017-06-01 17:27 ` [Qemu-devel] [PATCH v8 20/20] docs: document encryption options for qcow, qcow2 and luks Daniel P. Berrange
2017-06-07 17:44 ` [Qemu-devel] [PATCH v8 00/20] Convert QCow[2] to QCryptoBlock & add LUKS support Max Reitz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=e26777b2-1d57-d179-28e1-12b0f988e111@redhat.com \
    --to=eblake@redhat.com \
    --cc=berrange@redhat.com \
    --cc=berto@igalia.com \
    --cc=kwolf@redhat.com \
    --cc=mreitz@redhat.com \
    --cc=qemu-block@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).