From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 5E3D7C87FD2 for ; Fri, 1 Aug 2025 03:55:18 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1uhgqQ-0006my-PA; Thu, 31 Jul 2025 23:54:10 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uhgqO-0006jm-I1 for qemu-devel@nongnu.org; Thu, 31 Jul 2025 23:54:08 -0400 Received: from mail-pf1-x429.google.com ([2607:f8b0:4864:20::429]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1uhgqM-0008Gk-IY for qemu-devel@nongnu.org; Thu, 31 Jul 2025 23:54:08 -0400 Received: by mail-pf1-x429.google.com with SMTP id d2e1a72fcca58-76b6422756fso1718077b3a.2 for ; Thu, 31 Jul 2025 20:54:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1754020444; x=1754625244; darn=nongnu.org; h=content-transfer-encoding:in-reply-to:content-language:from :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=AA8gho/6YRVQoMeS73oZsIiDVQKycI7A7Y+em8lGyeY=; b=LiJmJv2lwAqU4cvfHKmdW40909YHtROs5dFB2sdAGizeXwKvzUmrnG28sTJimV+Box Bk/E01b/upL5HZ+mOJWkDLm2f6hZURP9ZseiY8rO2GJfs44o76IT8vUxxTgd40lvlzcf LcEJ2WwelRz5HpO4mGFOElLIvK3RKqCQ3GIi0acIo1krNqfBOOrCYYp3ntGtL/D/9TSL wpaJYQEQ3Gcr5UkB2rtfw7ht+sHBRsAuzKsOQv+4xUgrUooXIYb1PAvZoLZm1iHaDysD oHZIXz8eHjKgd+/6NBGpb+eDZqOLvrn0P3831yLvxKm8KpEmZRA3sn+Kh5CKpcxnyyHZ CERA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1754020444; x=1754625244; h=content-transfer-encoding:in-reply-to:content-language:from :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=AA8gho/6YRVQoMeS73oZsIiDVQKycI7A7Y+em8lGyeY=; b=ZpBvAp/tJpxPAqLo4VR5u3PuMAPCB2NxiKFnjxnYczzd1PEHi2AyZxLCuOl/ePmfEX XEpfYeW4ebsHyehrZqNb4GavF7+5nm7IB/6UtwOm24o/0hqswcnK0sinPDjTWF2csuLT SOLw3SV8ceqia7prjHFl5ONyD/+Gx4R5USl9dfvgnF7jf/5nzlRWnKQ3v9M7Zx6Kc/Y+ 2IghwshumI2tOOjtMfoTQQtxWhb54jCS0BNsg9ON3eAGklPPwif3H7RbxEw6Q4e8goY0 tiVmDXUBtGlY5sohUg1o0vpJXsmEsqb4l5kNs+rmyHI6+t1MNx8ZGROu5+KD+RydDr+e en5g== X-Forwarded-Encrypted: i=1; AJvYcCVstOKUMhzn8Nm4lnXdXfASHX6P8n0X0EA7BNZk3amPu4Gt9Z7mjDQS/E0cZCbaXRj8+4XUgFSbEfv3@nongnu.org X-Gm-Message-State: AOJu0YwrIClNEESo6Ad4OMHlej5WIxTKLwPF71u9B88jGCspr/DdRenj aH0sONyYigW1p4/DOe4VreMNQMjMIp442vc6ky+TQ2UMlmvW04iBDpeQUXbrQRwqYGg= X-Gm-Gg: ASbGncu7QO52TbFadRAOho14vm/J2F6ea6B0CjStFb57wsBiGaeek74haMqW+VpeDzt ZFCbTOJAxH6u4DMB5lGzZFrof4/1/sF3VumzgUtffZLgQt9OSXoPe1q+zRpfDM9lRXupKbu4qvL v2NvGJhC28fOQ/koyQridSVtL/P7o8YNKVpII7ZBqZf11Vx/EJlBEK2S6EsJNHeQrUkupnMJaXw HcDYlTN9bJTW5s7YZbTFvk+iOgaG0qSBK9OoDnpYU4IUCeJzk8SlHQDYvgBU6Ohywy4E2bWLBGg 2q9VtHIBud7r2ewlu11kpQG78dOO6wfYbY7v1++IVBUTjU0HGcbgV1vzuKG8/Gaa8uWpbrRkZYz E2/Gy3b3jV6qwnZ5LzSIlbC8LXa/tFbYfEq31WZ9p X-Google-Smtp-Source: AGHT+IFEn8ORgcp/BvoBWZW0v5k9AiJMpdy5nv4LdaxNRiLf6vOT3C0KC6fJO6x+/C712SqqdCKotw== X-Received: by 2002:a05:6300:210b:b0:23d:9dd0:b2e5 with SMTP id adf61e73a8af0-23de8226cd0mr1818300637.41.1754020444471; Thu, 31 Jul 2025 20:54:04 -0700 (PDT) Received: from [192.168.4.112] ([180.233.125.160]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-76bcce6f92bsm2957720b3a.21.2025.07.31.20.54.01 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 31 Jul 2025 20:54:04 -0700 (PDT) Message-ID: Date: Fri, 1 Aug 2025 13:53:59 +1000 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 37/82] target/arm: Convert regime_is_user from switch to table To: Pierrick Bouvier , qemu-devel@nongnu.org Cc: qemu-arm@nongnu.org References: <20250727080254.83840-1-richard.henderson@linaro.org> <20250727080254.83840-38-richard.henderson@linaro.org> <0128c452-8bde-4bdd-b73c-330a7bd619a1@linaro.org> From: Richard Henderson Content-Language: en-US In-Reply-To: <0128c452-8bde-4bdd-b73c-330a7bd619a1@linaro.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=2607:f8b0:4864:20::429; envelope-from=richard.henderson@linaro.org; helo=mail-pf1-x429.google.com X-Spam_score_int: 12 X-Spam_score: 1.2 X-Spam_bar: + X-Spam_report: (1.2 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_SBL_CSS=3.335, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org On 7/31/25 07:21, Pierrick Bouvier wrote: >>   #include "mmuidx-internal.h" >> -#define EL(X)  ((X << R_MMUIDXINFO_EL_SHIFT) | R_MMUIDXINFO_ELVALID_MASK) >> +#define EL(X)  ((X << R_MMUIDXINFO_EL_SHIFT) | R_MMUIDXINFO_ELVALID_MASK | \ >> +                ((X == 0) << R_MMUIDXINFO_USER_SHIFT)) >>   #define REL(X) ((X << R_MMUIDXINFO_REL_SHIFT) | R_MMUIDXINFO_RELVALID_MASK) >>   #define R2     R_MMUIDXINFO_2RANGES_MASK >>   #define PAN    R_MMUIDXINFO_PAN_MASK >> +#define USER   R_MMUIDXINFO_USER_MASK >>   const uint32_t arm_mmuidx_table[ARM_MMU_IDX_M + 8] = { >>       /* >> @@ -33,7 +35,7 @@ const uint32_t arm_mmuidx_table[ARM_MMU_IDX_M + 8] = { >>       [ARMMMUIdx_Stage2_S]        = REL(2), >>       [ARMMMUIdx_Stage2]          = REL(2), >> -    [ARMMMUIdx_Stage1_E0]       = REL(1) | R2, >> +    [ARMMMUIdx_Stage1_E0]       = REL(1) | R2 | USER, >>       [ARMMMUIdx_Stage1_E1]       = REL(1) | R2, >>       [ARMMMUIdx_Stage1_E1_PAN]   = REL(1) | R2 | PAN, > > Maybe I missed something, but what about other entries that were initially treated in the > switch? > - ARMMMUIdx_E.0_0 > - ARMMMUIdx_M*User See the change to EL(). I'm not sure why ARMMMUIdx_Stage1_* is excluded from arm_mmu_idx_to_el(), but I don't change that in this patch series. r~