From: Eric Blake <eblake@redhat.com>
To: Stefan Fritsch <sf@sfritsch.de>, qemu-devel@nongnu.org
Cc: "Paolo Bonzini" <pbonzini@redhat.com>,
"Marc-André Lureau" <marcandre.lureau@redhat.com>,
"Dr. David Alan Gilbert" <dgilbert@redhat.com>,
"Markus Armbruster" <armbru@redhat.com>
Subject: Re: [Qemu-devel] [PATCH] Add chardev-send-break monitor command
Date: Mon, 5 Jun 2017 07:24:12 -0500 [thread overview]
Message-ID: <e27e8fb4-64fa-9ba9-26a2-aa2af758462b@redhat.com> (raw)
In-Reply-To: <20170605085254.16485-1-sf@sfritsch.de>
[-- Attachment #1: Type: text/plain, Size: 808 bytes --]
On 06/05/2017 03:52 AM, Stefan Fritsch wrote:
> Sending a break on a serial console can be useful for debugging the
> guest. But not all chardev backends support sending breaks (only telnet
> and mux do). The chardev-send-break command allows to send a break even
> if using other backends.
>
> Signed-off-by: Stefan Fritsch <sf@sfritsch.de>
> ---
> chardev/char.c | 12 ++++++++++++
> hmp-commands.hx | 16 ++++++++++++++++
> hmp.c | 8 ++++++++
> hmp.h | 1 +
> qapi-schema.json | 20 ++++++++++++++++++++
> 5 files changed, 57 insertions(+)
Is there an obvious test that we can enhance to add coverage of the new
QMP command?
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3266
Virtualization: qemu.org | libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]
next prev parent reply other threads:[~2017-06-05 12:24 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-05 8:52 [Qemu-devel] [PATCH] Add chardev-send-break monitor command Stefan Fritsch
2017-06-05 12:24 ` Eric Blake [this message]
2017-06-06 14:17 ` Paolo Bonzini
2017-06-06 16:19 ` Markus Armbruster
2017-06-06 19:47 ` Stefan Fritsch
2017-06-06 22:44 ` Paolo Bonzini
2017-06-07 7:06 ` Markus Armbruster
2017-06-07 7:10 ` Paolo Bonzini
2017-06-08 9:31 ` Dr. David Alan Gilbert
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e27e8fb4-64fa-9ba9-26a2-aa2af758462b@redhat.com \
--to=eblake@redhat.com \
--cc=armbru@redhat.com \
--cc=dgilbert@redhat.com \
--cc=marcandre.lureau@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=sf@sfritsch.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).