qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Richard Henderson <richard.henderson@linaro.org>
To: "Ilya Leoshkevich" <iii@linux.ibm.com>,
	"Alex Bennée" <alex.bennee@linaro.org>,
	"Laurent Vivier" <laurent@vivier.eu>,
	"Warner Losh" <imp@bsdimp.com>
Cc: "Kyle Evans" <kevans@freebsd.org>,
	"Philippe Mathieu-Daudé" <philmd@linaro.org>,
	qemu-devel@nongnu.org
Subject: Re: [PATCH v3 04/11] {linux,bsd}-user: Pass pid to fork_end()
Date: Sat, 17 Feb 2024 10:26:13 -1000	[thread overview]
Message-ID: <e283e0bb-731f-482e-a529-f4c775e794fa@linaro.org> (raw)
In-Reply-To: <20240216130817.369377-5-iii@linux.ibm.com>

On 2/16/24 03:05, Ilya Leoshkevich wrote:
> diff --git a/linux-user/user-internals.h b/linux-user/user-internals.h
> index c63ef45fc78..9014014d920 100644
> --- a/linux-user/user-internals.h
> +++ b/linux-user/user-internals.h
> @@ -71,7 +71,7 @@ const char *target_strerror(int err);
>   int get_osversion(void);
>   void init_qemu_uname_release(void);
>   void fork_start(void);
> -void fork_end(int child);
> +void fork_end(abi_long pid);

Use pid_t.  There's nothing guest specific about the value here.

Otherwise,
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>


r~



  parent reply	other threads:[~2024-02-17 20:26 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-02-16 13:05 [PATCH v3 00/11] gdbstub: Implement follow-fork-mode child Ilya Leoshkevich
2024-02-16 13:05 ` [PATCH v3 01/11] gdbstub: Support disablement in a multi-threaded process Ilya Leoshkevich
2024-02-16 17:04   ` Alex Bennée
2024-02-17 20:21   ` Richard Henderson
2024-02-19 13:05     ` Ilya Leoshkevich
2024-02-19 14:18       ` Ilya Leoshkevich
2024-02-16 13:05 ` [PATCH v3 02/11] {linux,bsd}-user: Update ts_tid after fork() Ilya Leoshkevich
2024-02-16 17:45   ` Alex Bennée
2024-02-17 20:22     ` Richard Henderson
2024-02-16 13:05 ` [PATCH v3 03/11] gdbstub: Introduce gdbserver_fork_start() Ilya Leoshkevich
2024-02-16 17:46   ` Alex Bennée
2024-02-16 13:05 ` [PATCH v3 04/11] {linux,bsd}-user: Pass pid to fork_end() Ilya Leoshkevich
2024-02-16 17:48   ` Alex Bennée
2024-02-17 20:26   ` Richard Henderson [this message]
2024-02-16 13:05 ` [PATCH v3 05/11] {linux,bsd}-user: Pass pid to gdbserver_fork() Ilya Leoshkevich
2024-02-17 20:27   ` Richard Henderson
2024-02-16 13:05 ` [PATCH v3 06/11] gdbstub: Call gdbserver_fork() both in parent and in child Ilya Leoshkevich
2024-02-17 20:30   ` Richard Henderson
2024-02-16 13:05 ` [PATCH v3 07/11] gdbstub: Introduce gdb_handle_query_supported_user() Ilya Leoshkevich
2024-02-17 20:36   ` Richard Henderson
2024-02-16 13:05 ` [PATCH v3 08/11] gdbstub: Introduce gdb_handle_set_thread_user() Ilya Leoshkevich
2024-02-16 13:05 ` [PATCH v3 09/11] gdbstub: Introduce gdb_handle_detach_user() Ilya Leoshkevich
2024-02-16 13:05 ` [PATCH v3 10/11] gdbstub: Implement follow-fork-mode child Ilya Leoshkevich
2024-02-16 13:05 ` [PATCH v3 11/11] tests/tcg: Add two follow-fork-mode tests Ilya Leoshkevich

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=e283e0bb-731f-482e-a529-f4c775e794fa@linaro.org \
    --to=richard.henderson@linaro.org \
    --cc=alex.bennee@linaro.org \
    --cc=iii@linux.ibm.com \
    --cc=imp@bsdimp.com \
    --cc=kevans@freebsd.org \
    --cc=laurent@vivier.eu \
    --cc=philmd@linaro.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).