From: "Cédric Le Goater" <clg@redhat.com>
To: Avihai Horon <avihaih@nvidia.com>, qemu-devel@nongnu.org
Cc: "Alex Williamson" <alex.williamson@redhat.com>,
"Eduardo Habkost" <eduardo@habkost.net>,
"Marcel Apfelbaum" <marcel.apfelbaum@gmail.com>,
"Philippe Mathieu-Daudé" <philmd@linaro.org>,
"Yanan Wang" <wangyanan55@huawei.com>,
"Juan Quintela" <quintela@redhat.com>,
"Peter Xu" <peterx@redhat.com>,
"Leonardo Bras" <leobras@redhat.com>,
"Eric Blake" <eblake@redhat.com>,
"Markus Armbruster" <armbru@redhat.com>,
"Thomas Huth" <thuth@redhat.com>,
"Laurent Vivier" <lvivier@redhat.com>,
"Paolo Bonzini" <pbonzini@redhat.com>,
"Yishai Hadas" <yishaih@nvidia.com>,
"Jason Gunthorpe" <jgg@nvidia.com>,
"Maor Gottlieb" <maorg@nvidia.com>,
"Kirti Wankhede" <kwankhede@nvidia.com>,
"Tarun Gupta" <targupta@nvidia.com>,
"Joao Martins" <joao.m.martins@oracle.com>
Subject: Re: [PATCH v4 7/9] vfio/migration: Add VFIO migration pre-copy support
Date: Tue, 30 May 2023 12:17:33 +0200 [thread overview]
Message-ID: <e2844dce-3b84-2a00-639c-4e2b2472b2a6@redhat.com> (raw)
In-Reply-To: <d7826e76-f33c-9635-43e7-8466063f212b@nvidia.com>
>>> diff --git a/hw/vfio/trace-events b/hw/vfio/trace-events
>>> index 646e42fd27..548f9488a7 100644
>>> --- a/hw/vfio/trace-events
>>> +++ b/hw/vfio/trace-events
>>> @@ -162,6 +162,8 @@ vfio_save_block(const char *name, int data_size) " (%s) data_size %d"
>>> vfio_save_cleanup(const char *name) " (%s)"
>>> vfio_save_complete_precopy(const char *name, int ret) " (%s) ret %d"
>>> vfio_save_device_config_state(const char *name) " (%s)"
>>> +vfio_save_iterate(const char *name, uint64_t precopy_init_size, uint64_t precopy_dirty_size) " (%s) precopy initial size 0x%"PRIx64" precopy dirty size 0x%"PRIx64"
>>
>> the extra '"' at the end breaks compile. No need to resend just for that.
>> It can be fixed.
>>
> Oh, strange that it doesn't break when I compile it.
> Do you have any idea why would that be?
It generates a -Werror=format= .
Did you configure the build with --disable-werror ?
C.
next prev parent reply other threads:[~2023-05-30 10:18 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-28 14:06 [PATCH v4 0/9] migration: Add switchover ack capability and VFIO precopy support Avihai Horon
2023-05-28 14:06 ` [PATCH v4 1/9] migration: Add switchover ack capability Avihai Horon
2023-05-28 14:06 ` [PATCH v4 2/9] migration: Implement switchover ack logic Avihai Horon
2023-05-29 15:01 ` Peter Xu
2023-05-28 14:06 ` [PATCH v4 3/9] migration: Enable switchover ack capability Avihai Horon
2023-05-28 14:06 ` [PATCH v4 4/9] tests: Add migration switchover ack capability test Avihai Horon
2023-05-28 14:06 ` [PATCH v4 5/9] vfio/migration: Refactor vfio_save_block() to return saved data size Avihai Horon
2023-05-28 14:06 ` [PATCH v4 6/9] vfio/migration: Store VFIO migration flags in VFIOMigration Avihai Horon
2023-05-30 9:08 ` Cédric Le Goater
2023-05-28 14:06 ` [PATCH v4 7/9] vfio/migration: Add VFIO migration pre-copy support Avihai Horon
2023-05-30 9:28 ` Cédric Le Goater
2023-05-30 9:55 ` Avihai Horon
2023-05-30 10:17 ` Cédric Le Goater [this message]
2023-05-30 11:06 ` Avihai Horon
2023-05-28 14:06 ` [PATCH v4 8/9] vfio/migration: Add x-allow-pre-copy VFIO device property Avihai Horon
2023-05-30 9:13 ` Cédric Le Goater
2023-05-28 14:06 ` [PATCH v4 9/9] vfio/migration: Add support for switchover ack capability Avihai Horon
2023-05-30 9:58 ` Cédric Le Goater
2023-05-30 11:04 ` Avihai Horon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e2844dce-3b84-2a00-639c-4e2b2472b2a6@redhat.com \
--to=clg@redhat.com \
--cc=alex.williamson@redhat.com \
--cc=armbru@redhat.com \
--cc=avihaih@nvidia.com \
--cc=eblake@redhat.com \
--cc=eduardo@habkost.net \
--cc=jgg@nvidia.com \
--cc=joao.m.martins@oracle.com \
--cc=kwankhede@nvidia.com \
--cc=leobras@redhat.com \
--cc=lvivier@redhat.com \
--cc=maorg@nvidia.com \
--cc=marcel.apfelbaum@gmail.com \
--cc=pbonzini@redhat.com \
--cc=peterx@redhat.com \
--cc=philmd@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
--cc=targupta@nvidia.com \
--cc=thuth@redhat.com \
--cc=wangyanan55@huawei.com \
--cc=yishaih@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).