From: Thomas Huth <thuth@redhat.com>
To: Michael Tokarev <mjt@tls.msk.ru>,
qemu-devel@nongnu.org, Kevin Wolf <kwolf@redhat.com>,
Hanna Reitz <hreitz@redhat.com>
Cc: qemu-block@nongnu.org, qemu-trivial@nongnu.org,
"Philippe Mathieu-Daudé" <philmd@linaro.org>,
"Yoshinori Sato" <ysato@users.sourceforge.jp>,
"Magnus Damm" <magnus.damm@gmail.com>
Subject: Re: [PATCH v2] tests/qemu-iotests/testenv: Use the "r2d" machine for sh4
Date: Thu, 26 Sep 2024 12:55:00 +0200 [thread overview]
Message-ID: <e2a50551-dd9d-45e7-a163-b98881347791@redhat.com> (raw)
In-Reply-To: <4d4a326f-ef6d-4c37-bdbe-4f42a9005375@tls.msk.ru>
On 26/09/2024 12.24, Michael Tokarev wrote:
> 25.09.2024 10:24, Thomas Huth wrote:
>> Commit 0ea0538fae516f9b4 removed the default machine of the sh4
>> binaries, so a lot of iotests are failing now without such a default
>> machine. Teach the iotest harness to use the "r2d" machine instead
>> to fix this problem.
>>
>> Signed-off-by: Thomas Huth <thuth@redhat.com>
>> ---
>> v2: "r2d" only works on little endian, so don't try to use it for sh4eb
>
> Hm. The v1 of this patch (with sh4eb addition) has already been merged
> to master.
>
> I did a single pull request during my vacation (a week ago), and it contained
> a very fresh patch which received further discussion after I picked it up, but
> I haven't noticed.
>
> So we should now remove the already added sh4eb from there, it looks like.. :(
>
> I'll submit a patch doing that later today, hopefully.
I'm planning to provide a patch to remove sh4eb-softmmu completely (since it
is useless nowadays) ... I can add it there, too.
Thomas
next prev parent reply other threads:[~2024-09-26 10:56 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-25 7:24 [PATCH v2] tests/qemu-iotests/testenv: Use the "r2d" machine for sh4 Thomas Huth
2024-09-26 10:24 ` Michael Tokarev
2024-09-26 10:55 ` Thomas Huth [this message]
2024-09-26 12:52 ` Michael Tokarev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e2a50551-dd9d-45e7-a163-b98881347791@redhat.com \
--to=thuth@redhat.com \
--cc=hreitz@redhat.com \
--cc=kwolf@redhat.com \
--cc=magnus.damm@gmail.com \
--cc=mjt@tls.msk.ru \
--cc=philmd@linaro.org \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
--cc=ysato@users.sourceforge.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).