qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Philippe Mathieu-Daudé" <philmd@redhat.com>
To: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>,
	qemu-devel@nongnu.org
Cc: Kevin Wolf <kwolf@redhat.com>,
	Stefano Stabellini <sstabellini@kernel.org>,
	qemu-block@nongnu.org, Paul Durrant <paul@xen.org>,
	groug@kaod.org, armbru@redhat.com,
	Stefan Hajnoczi <stefanha@redhat.com>,
	Anthony Perard <anthony.perard@citrix.com>,
	xen-devel@lists.xenproject.org, Max Reitz <mreitz@redhat.com>
Subject: Re: [PATCH v11 8/8] xen: introduce ERRP_AUTO_PROPAGATE
Date: Sat, 4 Jul 2020 18:36:07 +0200	[thread overview]
Message-ID: <e2b4f10a-162c-ebb8-3232-381c4d820f9f@redhat.com> (raw)
In-Reply-To: <20200703090816.3295-9-vsementsov@virtuozzo.com>

On 7/3/20 11:08 AM, Vladimir Sementsov-Ogievskiy wrote:
> If we want to add some info to errp (by error_prepend() or
> error_append_hint()), we must use the ERRP_AUTO_PROPAGATE macro.
> Otherwise, this info will not be added when errp == &error_fatal
> (the program will exit prior to the error_append_hint() or
> error_prepend() call).  Fix such cases.
> 
> If we want to check error after errp-function call, we need to
> introduce local_err and then propagate it to errp. Instead, use
> ERRP_AUTO_PROPAGATE macro, benefits are:
> 1. No need of explicit error_propagate call
> 2. No need of explicit local_err variable: use errp directly
> 3. ERRP_AUTO_PROPAGATE leaves errp as is if it's not NULL or
>    &error_fatal, this means that we don't break error_abort
>    (we'll abort on error_set, not on error_propagate)
> 
> This commit is generated by command
> 
>     sed -n '/^X86 Xen CPUs$/,/^$/{s/^F: //p}' MAINTAINERS | \
>     xargs git ls-files | grep '\.[hc]$' | \
>     xargs spatch \
>         --sp-file scripts/coccinelle/auto-propagated-errp.cocci \
>         --macro-file scripts/cocci-macro-file.h \
>         --in-place --no-show-diff --max-width 80
> 
> Reported-by: Kevin Wolf <kwolf@redhat.com>
> Reported-by: Greg Kurz <groug@kaod.org>
> Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
> ---
>  hw/block/dataplane/xen-block.c |  17 +++---
>  hw/block/xen-block.c           | 102 ++++++++++++++-------------------
>  hw/pci-host/xen_igd_pt.c       |   7 +--
>  hw/xen/xen-backend.c           |   7 +--
>  hw/xen/xen-bus.c               |  92 +++++++++++++----------------
>  hw/xen/xen-host-pci-device.c   |  27 +++++----
>  hw/xen/xen_pt.c                |  25 ++++----
>  hw/xen/xen_pt_config_init.c    |  17 +++---
>  8 files changed, 128 insertions(+), 166 deletions(-)

Without the description, this patch has 800 lines of diff...
It killed me, I don't have the energy to review patch #7 of this
series after that, sorry.
Consider splitting such mechanical patches next time. Here it
could have been hw/block, hw/pci-host, hw/xen.

Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>



  reply	other threads:[~2020-07-04 16:37 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-07-03  9:08 [PATCH v11 0/8] error: auto propagated local_err part I Vladimir Sementsov-Ogievskiy
2020-07-03  9:08 ` [PATCH v11 1/8] error: auto propagated local_err Vladimir Sementsov-Ogievskiy
2020-07-06  5:59   ` Markus Armbruster
2020-07-03  9:08 ` [PATCH v11 2/8] scripts: Coccinelle script to use ERRP_AUTO_PROPAGATE() Vladimir Sementsov-Ogievskiy
2020-07-03  9:08 ` [PATCH v11 3/8] SD (Secure Card): introduce ERRP_AUTO_PROPAGATE Vladimir Sementsov-Ogievskiy
2020-07-04 16:28   ` Philippe Mathieu-Daudé
2020-07-03  9:08 ` [PATCH v11 4/8] pflash: " Vladimir Sementsov-Ogievskiy
2020-07-03  9:08 ` [PATCH v11 5/8] fw_cfg: " Vladimir Sementsov-Ogievskiy
2020-07-03  9:08 ` [PATCH v11 6/8] virtio-9p: " Vladimir Sementsov-Ogievskiy
2020-07-03  9:08 ` [PATCH v11 7/8] nbd: " Vladimir Sementsov-Ogievskiy
2020-07-06  5:22   ` Markus Armbruster
2020-07-07 11:51   ` Markus Armbruster
2020-07-03  9:08 ` [PATCH v11 8/8] xen: " Vladimir Sementsov-Ogievskiy
2020-07-04 16:36   ` Philippe Mathieu-Daudé [this message]
2020-07-06  7:41     ` Markus Armbruster
2020-07-06  7:55     ` Vladimir Sementsov-Ogievskiy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=e2b4f10a-162c-ebb8-3232-381c4d820f9f@redhat.com \
    --to=philmd@redhat.com \
    --cc=anthony.perard@citrix.com \
    --cc=armbru@redhat.com \
    --cc=groug@kaod.org \
    --cc=kwolf@redhat.com \
    --cc=mreitz@redhat.com \
    --cc=paul@xen.org \
    --cc=qemu-block@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    --cc=sstabellini@kernel.org \
    --cc=stefanha@redhat.com \
    --cc=vsementsov@virtuozzo.com \
    --cc=xen-devel@lists.xenproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).