From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:59988) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eORFn-0005On-Vg for qemu-devel@nongnu.org; Mon, 11 Dec 2017 11:48:32 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eORFl-00066Z-DD for qemu-devel@nongnu.org; Mon, 11 Dec 2017 11:48:32 -0500 References: <20171129191215.11323-1-david@redhat.com> <3f0c7605-4090-c1f6-c40d-06aab9a3e992@redhat.com> <8d6768ec-56c9-293a-e420-75cc1ad6e2a8@redhat.com> From: Paolo Bonzini Message-ID: Date: Mon, 11 Dec 2017 17:48:23 +0100 MIME-Version: 1.0 In-Reply-To: <8d6768ec-56c9-293a-e420-75cc1ad6e2a8@redhat.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v1] cpus: make pause_all_cpus() play with SMP on single threaded TCG List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: David Hildenbrand , qemu-s390x@nongnu.org, qemu-devel@nongnu.org Cc: Peter Crosthwaite , Christian Borntraeger , Cornelia Huck , Richard Henderson , Alexander Graf On 11/12/2017 17:44, David Hildenbrand wrote: >> -void cpu_stop_current(void) >> -{ >> - if (current_cpu) { >> - qemu_cpu_stop(current_cpu, true); >> - } >> -} > Btw. this does not compile as this is used also in vl.c > Doh, then I'm applying your patch untouched. Paolo