From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([209.51.188.92]:57640) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1giL5v-0008MP-Vi for qemu-devel@nongnu.org; Sat, 12 Jan 2019 10:21:08 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1giKyz-0000jH-9H for qemu-devel@nongnu.org; Sat, 12 Jan 2019 10:13:58 -0500 Received: from mail-wm1-x342.google.com ([2a00:1450:4864:20::342]:33778) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1giKyz-0000iT-2Q for qemu-devel@nongnu.org; Sat, 12 Jan 2019 10:13:57 -0500 Received: by mail-wm1-x342.google.com with SMTP id r24so4055446wmh.0 for ; Sat, 12 Jan 2019 07:13:56 -0800 (PST) References: <20190109202140.4051-1-yuval.shaia@oracle.com> From: Marcel Apfelbaum Message-ID: Date: Sat, 12 Jan 2019 17:14:07 +0200 MIME-Version: 1.0 In-Reply-To: <20190109202140.4051-1-yuval.shaia@oracle.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US Subject: Re: [Qemu-devel] [PATCH] hw/pvrdma: Make function pvrdma_qp_send/recv return void. List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Yuval Shaia , qemu-devel@nongnu.org On 1/9/19 10:21 PM, Yuval Shaia wrote: > The functions handles errors internaly, callers have nothing to do with > the return value. > > Signed-off-by: Yuval Shaia > --- > hw/rdma/vmw/pvrdma_qp_ops.c | 14 ++++++-------- > hw/rdma/vmw/pvrdma_qp_ops.h | 4 ++-- > 2 files changed, 8 insertions(+), 10 deletions(-) > > diff --git a/hw/rdma/vmw/pvrdma_qp_ops.c b/hw/rdma/vmw/pvrdma_qp_ops.c > index 0565eba981..ce5a60e184 100644 > --- a/hw/rdma/vmw/pvrdma_qp_ops.c > +++ b/hw/rdma/vmw/pvrdma_qp_ops.c > @@ -143,7 +143,7 @@ int pvrdma_qp_ops_init(void) > return 0; > } > > -int pvrdma_qp_send(PVRDMADev *dev, uint32_t qp_handle) > +void pvrdma_qp_send(PVRDMADev *dev, uint32_t qp_handle) > { > RdmaRmQP *qp; > PvrdmaSqWqe *wqe; > @@ -155,7 +155,8 @@ int pvrdma_qp_send(PVRDMADev *dev, uint32_t qp_handle) > > qp = rdma_rm_get_qp(&dev->rdma_dev_res, qp_handle); > if (unlikely(!qp)) { > - return -EINVAL; > + pr_dbg("Invalid qpn\n"); > + return; > } > > ring = (PvrdmaRing *)qp->opaque; > @@ -212,11 +213,9 @@ int pvrdma_qp_send(PVRDMADev *dev, uint32_t qp_handle) > > wqe = pvrdma_ring_next_elem_read(ring); > } > - > - return 0; > } > > -int pvrdma_qp_recv(PVRDMADev *dev, uint32_t qp_handle) > +void pvrdma_qp_recv(PVRDMADev *dev, uint32_t qp_handle) > { > RdmaRmQP *qp; > PvrdmaRqWqe *wqe; > @@ -226,7 +225,8 @@ int pvrdma_qp_recv(PVRDMADev *dev, uint32_t qp_handle) > > qp = rdma_rm_get_qp(&dev->rdma_dev_res, qp_handle); > if (unlikely(!qp)) { > - return -EINVAL; > + pr_dbg("Invalid qpn\n"); > + return; > } > > ring = &((PvrdmaRing *)qp->opaque)[1]; > @@ -262,8 +262,6 @@ int pvrdma_qp_recv(PVRDMADev *dev, uint32_t qp_handle) > > wqe = pvrdma_ring_next_elem_read(ring); > } > - > - return 0; > } > > void pvrdma_cq_poll(RdmaDeviceResources *dev_res, uint32_t cq_handle) > diff --git a/hw/rdma/vmw/pvrdma_qp_ops.h b/hw/rdma/vmw/pvrdma_qp_ops.h > index ac46bf7fdf..31cb48ba29 100644 > --- a/hw/rdma/vmw/pvrdma_qp_ops.h > +++ b/hw/rdma/vmw/pvrdma_qp_ops.h > @@ -20,8 +20,8 @@ > > int pvrdma_qp_ops_init(void); > void pvrdma_qp_ops_fini(void); > -int pvrdma_qp_send(PVRDMADev *dev, uint32_t qp_handle); > -int pvrdma_qp_recv(PVRDMADev *dev, uint32_t qp_handle); > +void pvrdma_qp_send(PVRDMADev *dev, uint32_t qp_handle); > +void pvrdma_qp_recv(PVRDMADev *dev, uint32_t qp_handle); > void pvrdma_cq_poll(RdmaDeviceResources *dev_res, uint32_t cq_handle); > > #endif Reviewed-by: Marcel Apfelbaum Thanks, Marcel