Re: [Qemu-devel] [PATCH v2] iotests: Filter 175's allocation information

[Eric Blake <eblake@redhat.com>]

[-- Attachment #1: Type: text/plain, Size: 1163 bytes --]

On 5/13/19 10:52 AM, Max Reitz wrote:
> It is possible for an empty file to take up blocks on a filesystem.
> Make iotest 175 take this into account.
> 
> Reported-by: Thomas Huth <thuth@redhat.com>
> Signed-off-by: Max Reitz <mreitz@redhat.com>
> ---
> v2: [Nir]
> - Use a function for filtering
> - s/empty_blocks/extra_blocks/
> ---

> +# Some file systems sometimes allocate extra blocks independently of
> +# the file size.  This function hides the resulting difference in the
> +# stat -c '%b' output.
> +# Parameter 1: Number of blocks an empty file occupies
> +# Parameter 2: Image size in bytes
> +_filter_blocks()
> +{
> +    extra_blocks=$1
> +    img_size=$2
> +
> +    sed -e "s/blocks=$extra_blocks/nothing allocated/" \
> +        -e "s/blocks=$((extra_blocks + img_size / 512))/everything allocated/"
> +}

That turned out nicely.

Reviewed-by: Eric Blake <eblake@redhat.com>

> -size=1m
> +size=$((1 * 1024 * 1024))

Had to change since bash doesn't understand '1m' inside $(()).

-- 
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3226
Virtualization:  qemu.org | libvirt.org


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]